)]}'
{"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"4e3d1bab6386075598a0ef35e16f88c3b92ec1be","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            mode \u003d \u0027rw\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if instance_uuid is None and host_name is None:"},{"line_number":102,"context_line":"            msg \u003d _(\"Invalid request to attach volume to an invalid target\")"},{"line_number":103,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9cd88cf1","line":101,"updated":"2016-01-12 06:36:48.000000000","message":"This means it allows to specify instance_uuid and host_name at same time.\n\nDo you mean the instance_uuid and host_name are same host when both specified here?\n \nI think you also need to do changes in manager.py:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L876\nif instance_uuid: check attachment\nif host_name_sanitized: check attachment\ninstead of current \"if ... else..\"","commit_id":"3632173486f89d541c121be8e041a1da636edf32"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"b342e3a00847d3ae6f0a2d73f1f7ab8ba37d8f11","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            mode \u003d \u0027rw\u0027"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if instance_uuid is None and host_name is None:"},{"line_number":102,"context_line":"            msg \u003d _(\"Invalid request to attach volume to an invalid target\")"},{"line_number":103,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_d6e1aed1","line":101,"in_reply_to":"da6ed579_9cd88cf1","updated":"2016-01-13 13:06:46.000000000","message":"Yes, the purpose of this change is to provide the possibility to Nova to pass the host_name during attach, which makes it easier to track detach in multiattach volume cases.\n\nI don\u0027t know whether it\u0027s a valid scenario to try to attach a host and an instance at the same time. That if/else case should be fine as it handles the instance attach case if we have instance_uuid as much as I can see.","commit_id":"3632173486f89d541c121be8e041a1da636edf32"}]}