)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"bbcb307141fb787599b8dbf4b8069071242466aa","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                           \u0027vmware_host_password\u0027]"},{"line_number":258,"context_line":"        for param in required_params:"},{"line_number":259,"context_line":"            if not getattr(self.configuration, param, None):"},{"line_number":260,"context_line":"                raise exception.InvalidInput(_(\"%s not set.\") % param)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        port \u003d self.configuration.vmware_host_port"},{"line_number":263,"context_line":"        if not netutils.is_valid_port(port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_7ec7b512","line":260,"range":{"start_line":260,"start_character":50,"end_line":260,"end_character":51},"updated":"2016-01-19 09:34:58.000000000","message":"I think we should use InvalidInput(reason\u003dmsg). Would you change here?","commit_id":"0930604f57b2085b6f16714825a7aa22aa907e50"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"421d777783e9ef33d43ce27795406c51696dee2c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                           \u0027vmware_host_password\u0027]"},{"line_number":258,"context_line":"        for param in required_params:"},{"line_number":259,"context_line":"            if not getattr(self.configuration, param, None):"},{"line_number":260,"context_line":"                raise exception.InvalidInput(_(\"%s not set.\") % param)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        port \u003d self.configuration.vmware_host_port"},{"line_number":263,"context_line":"        if not netutils.is_valid_port(port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_593a0b38","line":260,"range":{"start_line":260,"start_character":50,"end_line":260,"end_character":51},"in_reply_to":"ba63e191_7ec7b512","updated":"2016-01-19 11:53:52.000000000","message":"It will work, but changed it for consistency.","commit_id":"0930604f57b2085b6f16714825a7aa22aa907e50"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"133e1a9539f0b4242f919ae1c0f5e8d1c0d4e3a6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"vmdk_opts \u003d ["},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"},{"line_number":69,"context_line":"               help\u003d\u0027IP address for connecting to VMware vCenter server.\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027vmware_host_port\u0027,"},{"line_number":71,"context_line":"               default\u003d443,"},{"line_number":72,"context_line":"               help\u003d\u0027Port number for connecting to VMware vCenter server.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_0f17ebed","line":70,"updated":"2016-03-22 19:48:39.000000000","message":"This should be a PortOpt rather than an IntOpt.","commit_id":"5a66f3ba9955fba1cd3e4db00ba15175a15c4288"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"160fc29260303462ad06617ee2559ad73c629017","unresolved":false,"context_lines":[{"line_number":67,"context_line":"vmdk_opts \u003d ["},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027vmware_host_ip\u0027,"},{"line_number":69,"context_line":"               help\u003d\u0027IP address for connecting to VMware vCenter server.\u0027),"},{"line_number":70,"context_line":"    cfg.IntOpt(\u0027vmware_host_port\u0027,"},{"line_number":71,"context_line":"               default\u003d443,"},{"line_number":72,"context_line":"               help\u003d\u0027Port number for connecting to VMware vCenter server.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027vmware_host_username\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_ea56d728","line":70,"in_reply_to":"fa0719c6_0f17ebed","updated":"2016-03-23 05:57:57.000000000","message":"Done","commit_id":"5a66f3ba9955fba1cd3e4db00ba15175a15c4288"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"133e1a9539f0b4242f919ae1c0f5e8d1c0d4e3a6","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                raise exception.InvalidInput(reason\u003dreason)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        port \u003d self.configuration.vmware_host_port"},{"line_number":265,"context_line":"        if not netutils.is_valid_port(port):"},{"line_number":266,"context_line":"            reason \u003d _(\"The port number: %s is invalid.\") % port"},{"line_number":267,"context_line":"            LOG.error(reason)"},{"line_number":268,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_4fd72323","line":265,"updated":"2016-03-22 19:48:39.000000000","message":"Which means you can then skip this check.","commit_id":"5a66f3ba9955fba1cd3e4db00ba15175a15c4288"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"160fc29260303462ad06617ee2559ad73c629017","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                raise exception.InvalidInput(reason\u003dreason)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        port \u003d self.configuration.vmware_host_port"},{"line_number":265,"context_line":"        if not netutils.is_valid_port(port):"},{"line_number":266,"context_line":"            reason \u003d _(\"The port number: %s is invalid.\") % port"},{"line_number":267,"context_line":"            LOG.error(reason)"},{"line_number":268,"context_line":"            raise exception.InvalidInput(reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_ca531338","line":265,"in_reply_to":"fa0719c6_4fd72323","updated":"2016-03-23 05:57:57.000000000","message":"Done","commit_id":"5a66f3ba9955fba1cd3e4db00ba15175a15c4288"}]}