)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a81462a76cd15ceba3ced875bd9dda9f13bfde92","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"            status \u003d attrs[\u0027status\u0027]"},{"line_number":1345,"context_line":""},{"line_number":1346,"context_line":"            if not allow_snaps:"},{"line_number":1347,"context_line":"                # Vdisk is the belong to a fcmapiing. Return False if"},{"line_number":1348,"context_line":"                # snapshot not allowed."},{"line_number":1349,"context_line":"                raise loopingcall.LoopingCallDone(retvalue\u003dFalse)"},{"line_number":1350,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_9a515511","line":1347,"updated":"2016-01-17 17:22:36.000000000","message":"s/is the belong to/belongs to/\ns/fcmapiing/fcmapping/","commit_id":"fc833e56e6cbfb52b947f93d30f3088e4e0a273f"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"3f6507745ac3e4869de93bff90c774b366218248","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"            return None"},{"line_number":1329,"context_line":"        return resp[0]"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"    def _check_vdisk_fc_mappings(self, name,"},{"line_number":1332,"context_line":"                                 allow_snaps\u003dTrue, allow_fctgt\u003dFalse):"},{"line_number":1333,"context_line":"        \"\"\"FlashCopy mapping check helper.\"\"\""},{"line_number":1334,"context_line":"        LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), vdisk %s.\u0027, name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_9a77629f","line":1331,"updated":"2016-03-31 18:50:15.000000000","message":"I like the design to add allow_fctgt to make the control flow very clear.","commit_id":"a02610662b82e3fef806c33cd3f837aa9315875f"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"9fab5d9753f58c1163a2fb8f14e1d0c2fe113677","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"            copy_rate \u003d attrs[\u0027copy_rate\u0027]"},{"line_number":1435,"context_line":"            status \u003d attrs[\u0027status\u0027]"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"            if allow_fctgt and target \u003d\u003d name:"},{"line_number":1438,"context_line":"                if status \u003d\u003d \u0027copying\u0027:"},{"line_number":1439,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":1440,"context_line":"                    attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":1441,"context_line":"                    if attrs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e7c7cb93","line":1438,"range":{"start_line":1437,"start_character":12,"end_line":1438,"end_character":39},"updated":"2016-07-07 10:56:07.000000000","message":"not that it\u0027s wrong, but it would look better in a single if statement.","commit_id":"94f5fdd6f80c8c747ec49cd3fab0c35b3d06a340"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"6ca2bc25a1df32e9e2b928e1babf70add2272006","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"            copy_rate \u003d attrs[\u0027copy_rate\u0027]"},{"line_number":1435,"context_line":"            status \u003d attrs[\u0027status\u0027]"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"            if allow_fctgt and target \u003d\u003d name:"},{"line_number":1438,"context_line":"                if status \u003d\u003d \u0027copying\u0027:"},{"line_number":1439,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":1440,"context_line":"                    attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":1441,"context_line":"                    if attrs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_c14cbf9f","line":1438,"range":{"start_line":1437,"start_character":12,"end_line":1438,"end_character":39},"in_reply_to":"1aa78d24_e7c7cb93","updated":"2016-07-11 01:43:27.000000000","message":"Thanks Alon for your review.","commit_id":"94f5fdd6f80c8c747ec49cd3fab0c35b3d06a340"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"9fab5d9753f58c1163a2fb8f14e1d0c2fe113677","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"                if status \u003d\u003d \u0027prepared\u0027:"},{"line_number":1472,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":1473,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1474,"context_line":"                elif status \u003d\u003d \u0027idle_or_copied\u0027 or status \u003d\u003d \u0027stopped\u0027:"},{"line_number":1475,"context_line":"                    # Prepare failed or stopped"},{"line_number":1476,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1477,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_87b6c7f6","line":1474,"range":{"start_line":1474,"start_character":21,"end_line":1474,"end_character":70},"updated":"2016-07-07 10:56:07.000000000","message":"status in [\u0027idle_or_copied\u0027, \u0027stopped\u0027]","commit_id":"94f5fdd6f80c8c747ec49cd3fab0c35b3d06a340"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"6ca2bc25a1df32e9e2b928e1babf70add2272006","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"                if status \u003d\u003d \u0027prepared\u0027:"},{"line_number":1472,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":1473,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1474,"context_line":"                elif status \u003d\u003d \u0027idle_or_copied\u0027 or status \u003d\u003d \u0027stopped\u0027:"},{"line_number":1475,"context_line":"                    # Prepare failed or stopped"},{"line_number":1476,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1477,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_4159ef5a","line":1474,"range":{"start_line":1474,"start_character":21,"end_line":1474,"end_character":70},"in_reply_to":"1aa78d24_60123364","updated":"2016-07-11 01:43:27.000000000","message":"Thanks Alon and xing, I have changed it. thanks again.","commit_id":"94f5fdd6f80c8c747ec49cd3fab0c35b3d06a340"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2ab2f30866d27b640b53e8833c0a13971404c5e7","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"                if status \u003d\u003d \u0027prepared\u0027:"},{"line_number":1472,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":1473,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1474,"context_line":"                elif status \u003d\u003d \u0027idle_or_copied\u0027 or status \u003d\u003d \u0027stopped\u0027:"},{"line_number":1475,"context_line":"                    # Prepare failed or stopped"},{"line_number":1476,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":1477,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_60123364","line":1474,"range":{"start_line":1474,"start_character":21,"end_line":1474,"end_character":70},"in_reply_to":"1aa78d24_87b6c7f6","updated":"2016-07-09 17:44:24.000000000","message":"+1","commit_id":"94f5fdd6f80c8c747ec49cd3fab0c35b3d06a340"}],"releasenotes/notes/del_volume_with_fc-f024b9f2d6eaca0f.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0cdd3fce20492258944b84ec7f90fa5aed96b209","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Currently the volume state stays in \u0027deleting\u0027 during"},{"line_number":4,"context_line":"    volume delete operation if there is fcmapping for IBM"},{"line_number":5,"context_line":"    storwize/SVC driver. Stop the fcmapping first if the"},{"line_number":6,"context_line":"    volume is the target volume of the fcmapping. So the"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_d91e276f","line":3,"updated":"2016-07-06 14:26:39.000000000","message":"This could be confusing to end users reading the release notes. Can you simplify this to something like:\n\nFixed StorWize/SVC error causing volume deletion to get stuck in the \u0027deleting\u0027 state when using FlashCopy.","commit_id":"6793a6f896d7148a677b6db6b08e8f282d467479"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"0f2fb791857fa24f756f94c62390a7efac7c01fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Currently the volume state stays in \u0027deleting\u0027 during"},{"line_number":4,"context_line":"    volume delete operation if there is fcmapping for IBM"},{"line_number":5,"context_line":"    storwize/SVC driver. Stop the fcmapping first if the"},{"line_number":6,"context_line":"    volume is the target volume of the fcmapping. So the"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_b5705ba5","line":3,"in_reply_to":"1aa78d24_d91e276f","updated":"2016-07-07 04:22:40.000000000","message":"Thanks Sean for your suggestion.I have changed it.please help to check it again.","commit_id":"6793a6f896d7148a677b6db6b08e8f282d467479"}]}