)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"204ac65106c15652628491e46c2427d25b54fba0","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"def backup_get_all_by_project(context, project_id):"},{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\","},{"line_number":1961,"context_line":"                       project_only\u003dTrue).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F25o%3D","line":1960,"updated":"2013-04-17 07:29:44.000000000","message":"Do we want read_deleted\u003d\"yes\" here?","commit_id":"8443ce70f26332c8cf3c5139de5f80b0709c16d1"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"6d6dd660d26c33450e175fdb8c90be3268c81fa0","unresolved":false,"context_lines":[{"line_number":1957,"context_line":"def backup_get_all_by_project(context, project_id):"},{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\","},{"line_number":1961,"context_line":"                       project_only\u003dTrue).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F25A%3D","line":1960,"in_reply_to":"AAAAOn%2F%2F25o%3D","updated":"2013-04-17 07:51:54.000000000","message":"Probable not, I am guessing.\n\nBut this is a separate issue, so I created a bug for it https://bugs.launchpad.net/cinder/+bug/1169857","commit_id":"8443ce70f26332c8cf3c5139de5f80b0709c16d1"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"9c9a378b1a9053f7183bee9b649c5fa62c2f234f","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\","},{"line_number":1961,"context_line":"                       project_only\u003dTrue).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F20Y%3D","line":1961,"updated":"2013-04-17 09:27:16.000000000","message":"Should this not be filter_by(project_id\u003dproject_id) (instead of/in addition to project_only\u003dTrue)\n\nIf not, should we not be passing in the project_id at all here as it is misleading?","commit_id":"8443ce70f26332c8cf3c5139de5f80b0709c16d1"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"64e906c1eb6806c253830ec8a9e7e1a6bce0d427","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\","},{"line_number":1961,"context_line":"                       project_only\u003dTrue).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F2z8%3D","line":1961,"in_reply_to":"AAAAOn%2F%2F20Y%3D","updated":"2013-04-17 09:40:16.000000000","message":"Agreed it is confusing. I honestly don\u0027t know which is the \"correct\" way of doing it. Is the project_id more correct then the context.project_id, I have no idea. I don\u0027t know where either come from. I hope to get a bit of time to figure that out shortly.\n\nI personally don\u0027t like the model_query method at all. I don\u0027t understand project_only, read_deleted arguments. model_query seems to be a abstraction above SQLAlchemy but sqlalchemy is meant to ad all this stuff anyway so I don\u0027t get why it is needed.\n\nSo after saying considering that I don\u0027t understand project_only and understand filter_by I am going to change it.","commit_id":"8443ce70f26332c8cf3c5139de5f80b0709c16d1"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"5c03b6f6a82ef964d473251fef56a9948e8ccfc9","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\").\\"},{"line_number":1961,"context_line":"        filter_by(project_id\u003dproject_id).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fvr8%3D","line":1961,"updated":"2013-04-25 04:54:46.000000000","message":"I\u0027m not sure about the read_deleted\u003d\"yes\" here","commit_id":"8f045d2dd2cb84099dd54701e9d27b12a779e191"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"f3810a53321c73c0fb11fbe8657aa5941c164ac5","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"    authorize_project_context(context, project_id)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    return model_query(context, models.Backup, read_deleted\u003d\"yes\").\\"},{"line_number":1961,"context_line":"        filter_by(project_id\u003dproject_id).all()"},{"line_number":1962,"context_line":""},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fvlc%3D","line":1961,"in_reply_to":"AAAAOn%2F%2Fvr8%3D","updated":"2013-04-25 07:47:23.000000000","message":"I didn\u0027t add the read_deleted\u003d\"yes\" here. This patch is to stop users from been able to see other users backup metadata.\n\nWhen solving my other problem with backups, https://review.openstack.org/#/c/27072/ I remove the read_deleted\u003d\"yes\" as it is appropriate to do so when solving that issue.\n\n(Note that both these reviews are going to conflict on merge but I will deal with that at that time as they solve two different issues)","commit_id":"8f045d2dd2cb84099dd54701e9d27b12a779e191"}]}