)]}'
{"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"fb367f943ccc4e1e881068553ed364a924fb732f","unresolved":false,"context_lines":[{"line_number":2495,"context_line":"        self.fc_driver.terminate_connection(volume, conn2)"},{"line_number":2496,"context_line":"        self.fc_driver.terminate_connection(volume, self._connector)"},{"line_number":2497,"context_line":""},{"line_number":2498,"context_line":"    def test_add_vdisk_copy_fc(self):"},{"line_number":2499,"context_line":"        # Ensure only FC is available"},{"line_number":2500,"context_line":"        self.fc_driver._state[\u0027enabled_protocols\u0027] \u003d set([\u0027FC\u0027])"},{"line_number":2501,"context_line":"        volume \u003d self._generate_vol_info(None, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_c727d110","line":2498,"range":{"start_line":2498,"start_character":8,"end_line":2498,"end_character":36},"updated":"2016-01-21 15:27:44.000000000","message":"We should probably add a similar test to iSCSI.","commit_id":"b811df997b047a74b8b1b57f84d31ab44d0ec846"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7e7e6ace2cad16608b66b2c0edfb33ad9f580d34","unresolved":false,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"    def do_setup(self, ctxt):"},{"line_number":1735,"context_line":"        \"\"\"Check that we have all configuration details from the storage.\"\"\""},{"line_number":1736,"context_line":"        LOG.debug(\u0027enter: do_setup\u0027)"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        # Get storage system name, id, and code level"},{"line_number":1739,"context_line":"        self._state.update(self._helpers.get_system_info())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_cc139a5b","side":"PARENT","line":1736,"updated":"2016-01-20 23:26:04.000000000","message":"Why was this removed?","commit_id":"adf35d0ee1b3c309a1722648de781b9e024899ff"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"7a6d1c154ee4636fddc29c86c17e4136b3af68e4","unresolved":false,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"    def do_setup(self, ctxt):"},{"line_number":1735,"context_line":"        \"\"\"Check that we have all configuration details from the storage.\"\"\""},{"line_number":1736,"context_line":"        LOG.debug(\u0027enter: do_setup\u0027)"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        # Get storage system name, id, and code level"},{"line_number":1739,"context_line":"        self._state.update(self._helpers.get_system_info())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_cf6dcc33","side":"PARENT","line":1736,"in_reply_to":"9a68dd71_cc139a5b","updated":"2016-01-21 00:11:13.000000000","message":"The trace logging for \"exit: do_setup\" was in each of the child drivers methods (which were removed). I don\u0027t see this trace logging for the method to be particularly useful so I removed this one (versus adding back in the exit one) - especially since the volume manager is logging that it\u0027s about to call do_setup.\n\nIf you want me to add both trace logging statements back in for some reason let me know.","commit_id":"adf35d0ee1b3c309a1722648de781b9e024899ff"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"fb367f943ccc4e1e881068553ed364a924fb732f","unresolved":false,"context_lines":[{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"    def do_setup(self, ctxt):"},{"line_number":1735,"context_line":"        \"\"\"Check that we have all configuration details from the storage.\"\"\""},{"line_number":1736,"context_line":"        LOG.debug(\u0027enter: do_setup\u0027)"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"        # Get storage system name, id, and code level"},{"line_number":1739,"context_line":"        self._state.update(self._helpers.get_system_info())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_02e877b3","side":"PARENT","line":1736,"in_reply_to":"9a68dd71_cf6dcc33","updated":"2016-01-21 15:27:44.000000000","message":"After reading Jay\u0027s comment and looking back at the code before the refactor, logging for \u0027enter: do_setup\u0027 and \u0027exit: do_setup\u0027 were located in the same method. Plus there are other methods that have similar logging. So I like the idea of adding them back in.","commit_id":"adf35d0ee1b3c309a1722648de781b9e024899ff"}]}