)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"cb779bdfef3a187073ecd5a282b4c54b75f673af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Wang \u003cbo.wang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-20 15:29:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix using functions for python2,3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_bbb0ea8c","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":19},"updated":"2016-01-27 16:39:15.000000000","message":"Does this need to be fixed in other places than just here? Or is this the only instance?","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"60b5f1fc49a03fb33173a8d7feae9703f89dfcda","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Wang \u003cbo.wang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-20 15:29:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix using functions for python2,3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_c3089ddc","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":19},"in_reply_to":"7a5de9d1_bbb0ea8c","updated":"2016-02-19 05:33:23.000000000","message":"thanks for review.\n\nFix it in patch set 2.","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"cb779bdfef3a187073ecd5a282b4c54b75f673af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix using functions for python2,3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."},{"line_number":11,"context_line":"ref:http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f38bfed7b0a8959bf4c8c9625ddc65dbb11164a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_1b401e56","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":68},"updated":"2016-01-27 16:39:15.000000000","message":"This kind of makes it sound like you are going to use map() instead of split(). Might want to clarify that split() just needs to be cast to a list because it returns different types from python 2 to python 3.","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"60b5f1fc49a03fb33173a8d7feae9703f89dfcda","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix using functions for python2,3 compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."},{"line_number":11,"context_line":"ref:http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f38bfed7b0a8959bf4c8c9625ddc65dbb11164a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_a302b9b2","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":68},"in_reply_to":"7a5de9d1_1b401e56","updated":"2016-02-19 05:33:23.000000000","message":"Done","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"cb779bdfef3a187073ecd5a282b4c54b75f673af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."},{"line_number":11,"context_line":"ref:http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f38bfed7b0a8959bf4c8c9625ddc65dbb11164a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_9b03ae0f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":74},"updated":"2016-01-27 16:39:15.000000000","message":"Since lines should wrap at 72 lines in the body of a commit, just move the url to a new line. Thanks!","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"60b5f1fc49a03fb33173a8d7feae9703f89dfcda","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"string.split() does not exist in python3."},{"line_number":10,"context_line":"In python3, map() returns an iterator but returns a list in python2."},{"line_number":11,"context_line":"ref:http://www.diveintopython3.net/porting-code-to-python-3-with-2to3.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3f38bfed7b0a8959bf4c8c9625ddc65dbb11164a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_e32a012f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":74},"in_reply_to":"7a5de9d1_9b03ae0f","updated":"2016-02-19 05:33:23.000000000","message":"Done","commit_id":"1cd9e0483c4924dc8bc5e8a4d03d003d94172da6"}],"cinder/volume/drivers/emc/emc_vmax_https.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"800da567c5d460c8f18ae5bbd45b0cf9b75eb0a7","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        for hdr in headers:"},{"line_number":312,"context_line":"            if isinstance(hdr, six.text_type):"},{"line_number":313,"context_line":"                hdr \u003d hdr.encode(\u0027utf-8\u0027)"},{"line_number":314,"context_line":"            s \u003d list(map(lambda x: x.strip(), hdr.split(\":\", 1)))"},{"line_number":315,"context_line":"            h.putheader(urllib.parse.quote(s[0]), urllib.parse.quote(s[1]))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_29097532","line":314,"updated":"2016-02-19 09:51:04.000000000","message":"nit: In all other patches we are replacing these cases with a list comprehension instead of a list(map()):\n\n s \u003d [x.strip() for x in hdr.split(\":\", 1)]","commit_id":"fedf74a15c1fa93019fbcfaad3978c63fc8e6298"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"b8413771d99594ecc49012d90ea5e5b9f651094e","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        for hdr in headers:"},{"line_number":312,"context_line":"            if isinstance(hdr, six.text_type):"},{"line_number":313,"context_line":"                hdr \u003d hdr.encode(\u0027utf-8\u0027)"},{"line_number":314,"context_line":"            s \u003d list(map(lambda x: x.strip(), hdr.split(\":\", 1)))"},{"line_number":315,"context_line":"            h.putheader(urllib.parse.quote(s[0]), urllib.parse.quote(s[1]))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_ddb4d1f3","line":314,"in_reply_to":"bae84128_29097532","updated":"2016-02-20 07:34:53.000000000","message":"Yes, this is more clear.\n\nDone in patch set 3","commit_id":"fedf74a15c1fa93019fbcfaad3978c63fc8e6298"}]}
