)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"415cdec2c0b30bd2c04af2f796c939a8482421df","unresolved":false,"context_lines":[{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":"Add an option args in uploading volume to image."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DocImapct"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I5bad2b9c0139f32c964612123cb10f5609943703"},{"line_number":27,"context_line":"Implements: blueprint uploading-volume-to-specific-image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_d39b4271","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":9},"updated":"2016-02-02 18:58:32.000000000","message":"just noticed this spelling error :)","commit_id":"8234b1b553dab1ea02ab0cb71f5dcd87fac106f6"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"01fd7d519cbf2730423667e7affaa44acfc8a3b5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"APIImpact"},{"line_number":22,"context_line":"Add an option args in uploading volume to image."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DocImapct"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I5bad2b9c0139f32c964612123cb10f5609943703"},{"line_number":27,"context_line":"Implements: blueprint uploading-volume-to-specific-image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_7e21c7b3","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"7a5de9d1_d39b4271","updated":"2016-02-04 09:24:07.000000000","message":"Wow, thanks. Good catch!","commit_id":"8234b1b553dab1ea02ab0cb71f5dcd87fac106f6"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"8c73062812fee0c9ef971011eff729f108ae4416","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":737,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"    def test_copy_volume_to_image_with_image_id(self):"},{"line_number":740,"context_line":"        self.stubs.Set(volume_api.API,"},{"line_number":741,"context_line":"                       \"copy_volume_to_image\","},{"line_number":742,"context_line":"                       stub_upload_volume_to_image_service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_1abfe061","line":739,"range":{"start_line":739,"start_character":8,"end_line":739,"end_character":47},"updated":"2016-01-25 18:07:19.000000000","message":"Maybe say copy_volume_to_existing_image?","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1c4c65ba65ba1f56a91716e7595d4038cc7ce6e3","unresolved":false,"context_lines":[{"line_number":736,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":737,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"    def test_copy_volume_to_image_with_image_id(self):"},{"line_number":740,"context_line":"        self.stubs.Set(volume_api.API,"},{"line_number":741,"context_line":"                       \"copy_volume_to_image\","},{"line_number":742,"context_line":"                       stub_upload_volume_to_image_service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_277ddab1","line":739,"range":{"start_line":739,"start_character":8,"end_line":739,"end_character":47},"in_reply_to":"9a68dd71_1abfe061","updated":"2016-01-26 08:23:27.000000000","message":"Done","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"}],"cinder/volume/api.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"257296b744a80396cf06a427b5710d439f42b6bd","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"            recv_metadata \u003d self.image_service.create("},{"line_number":1172,"context_line":"                context, self.image_service._translate_to_glance(metadata))"},{"line_number":1173,"context_line":"        else:"},{"line_number":1174,"context_line":"            recv_metadata \u003d self.image_service.show(context, image_id)"},{"line_number":1175,"context_line":"            # Tell manage no need to delete this image if exception is raised"},{"line_number":1176,"context_line":"            recv_metadata[\u0027specify_image\u0027] \u003d True"},{"line_number":1177,"context_line":"        self.update(context, volume, {\u0027status\u0027: \u0027uploading\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4bd5b0e5","line":1174,"updated":"2016-01-25 06:56:10.000000000","message":"Here if specified image_id, it will not update metadata of the image. \nI think you should check volume_image_metadata and the metadata of this image, and update the differences in volume_image_metadata.","commit_id":"acfa3d642591ae6258de96c7ad8a6b217569efe4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"66f305b4fa3ba171531b68e48de47545a81f95c2","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"            recv_metadata \u003d self.image_service.create("},{"line_number":1172,"context_line":"                context, self.image_service._translate_to_glance(metadata))"},{"line_number":1173,"context_line":"        else:"},{"line_number":1174,"context_line":"            recv_metadata \u003d self.image_service.show(context, image_id)"},{"line_number":1175,"context_line":"            # Tell manage no need to delete this image if exception is raised"},{"line_number":1176,"context_line":"            recv_metadata[\u0027specify_image\u0027] \u003d True"},{"line_number":1177,"context_line":"        self.update(context, volume, {\u0027status\u0027: \u0027uploading\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_3cec40f2","line":1174,"in_reply_to":"9a68dd71_4bd5b0e5","updated":"2016-01-25 08:36:26.000000000","message":"Yes, you\u0027re right, but I think no need to change the glance core properties, as it should keep as same as when user creates this image in glance, just update the custom_property.","commit_id":"acfa3d642591ae6258de96c7ad8a6b217569efe4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"8c73062812fee0c9ef971011eff729f108ae4416","unresolved":false,"context_lines":[{"line_number":1172,"context_line":"            recv_metadata \u003d self.image_service.create("},{"line_number":1173,"context_line":"                context, self.image_service._translate_to_glance(metadata))"},{"line_number":1174,"context_line":"        else:"},{"line_number":1175,"context_line":"            if properties:"},{"line_number":1176,"context_line":"                self.image_service.update(context, image_id,"},{"line_number":1177,"context_line":"                                          dict(properties\u003dproperties))"},{"line_number":1178,"context_line":"            recv_metadata \u003d self.image_service.show(context, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_7d17f644","line":1175,"updated":"2016-01-25 18:07:19.000000000","message":"what happens if the image specified is already in ACTIVE state? You can\u0027t change the bits of an ACTIVE image. Also, what happens if the image does not exist, is a 400 returned?","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1c4c65ba65ba1f56a91716e7595d4038cc7ce6e3","unresolved":false,"context_lines":[{"line_number":1172,"context_line":"            recv_metadata \u003d self.image_service.create("},{"line_number":1173,"context_line":"                context, self.image_service._translate_to_glance(metadata))"},{"line_number":1174,"context_line":"        else:"},{"line_number":1175,"context_line":"            if properties:"},{"line_number":1176,"context_line":"                self.image_service.update(context, image_id,"},{"line_number":1177,"context_line":"                                          dict(properties\u003dproperties))"},{"line_number":1178,"context_line":"            recv_metadata \u003d self.image_service.show(context, image_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_672192b4","line":1175,"in_reply_to":"9a68dd71_7d17f644","updated":"2016-01-26 08:23:27.000000000","message":"Yes, I miss this to check the image status, and image_service.show will raise exception.ImageNotFound if it\u0027s not existing, and a 400 returned.","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fdfa08a929fe79ef071abc7ff97cc1a190558aed","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"            if properties:"},{"line_number":1189,"context_line":"                self.image_service.update(context, image_id,"},{"line_number":1190,"context_line":"                                          dict(properties\u003dproperties))"},{"line_number":1191,"context_line":"            # Tell manage no need to delete this image if exception is raised"},{"line_number":1192,"context_line":"            recv_metadata[\u0027specify_image\u0027] \u003d True"},{"line_number":1193,"context_line":"        self.update(context, volume, {\u0027status\u0027: \u0027uploading\u0027})"},{"line_number":1194,"context_line":"        self.volume_rpcapi.copy_volume_to_image(context,"},{"line_number":1195,"context_line":"                                                volume,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6c514e0e","line":1192,"range":{"start_line":1191,"start_character":0,"end_line":1192,"end_character":49},"updated":"2016-01-26 18:39:11.000000000","message":"This should go through a separate new argument in the RPC method. It seems wrong to reuse already existing dict that is supposed to carry only the information that\u0027s behind API contract between Glance and Cinder.","commit_id":"ada12be305f1b4ac00f10b71af996e5e1311ca62"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c68142bffc43b95a4a62f422b95f58b780726b72","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"            if properties:"},{"line_number":1189,"context_line":"                self.image_service.update(context, image_id,"},{"line_number":1190,"context_line":"                                          dict(properties\u003dproperties))"},{"line_number":1191,"context_line":"            # Tell manage no need to delete this image if exception is raised"},{"line_number":1192,"context_line":"            recv_metadata[\u0027specify_image\u0027] \u003d True"},{"line_number":1193,"context_line":"        self.update(context, volume, {\u0027status\u0027: \u0027uploading\u0027})"},{"line_number":1194,"context_line":"        self.volume_rpcapi.copy_volume_to_image(context,"},{"line_number":1195,"context_line":"                                                volume,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_de548ecb","line":1192,"range":{"start_line":1191,"start_character":0,"end_line":1192,"end_character":49},"in_reply_to":"9a68dd71_6c514e0e","updated":"2016-01-27 03:10:55.000000000","message":"Emm, make sense to me, it\u0027s better to use new argument.","commit_id":"ada12be305f1b4ac00f10b71af996e5e1311ca62"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"80731457f73ff6e36c1a830d2084f6b711fb624c","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_75948fe1","line":1185,"updated":"2016-01-28 14:00:08.000000000","message":"Hi,\n\nI am wondering why it can\u0027t allow format and contain_format as None.\n\nConsider the following case:\n\nThere is a volume created from an image. And now I want to upload it to glance.\n\nUsing the interface in this patch: I create an image: \n\nglance image-create --name test\n\nThe format and container_format are None. \n\nAnd then I upload the above volume to above image. I expect that the metadata of volume_glance_metadata of the volume will be updated to the image so that its info is complete.\n\nIf you think your patch is not suitable for above scenario, please give a description.","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"494f6bde6087440fbfd3261dcc90040edd28ff89","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_bf80e747","line":1185,"in_reply_to":"7a5de9d1_010be7d6","updated":"2016-02-03 02:31:44.000000000","message":"When uploading volume to image without specifying image, users can set --container-format and --disk-format, and these will be used to create an image.\n\nHere, if users specify --container-format and --disk-format (in metadata) when uploading to specified image, they are ignored. I think or you prohibit the uploading if the two data are different from the image, or can continue but update the two attributes of the image.","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"8d5e4ad778ccc35e71eabb9e32ed449c202ce56d","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_eb330c12","line":1185,"in_reply_to":"7a5de9d1_1a1ef86f","updated":"2016-02-02 07:49:59.000000000","message":"I don\u0027t think so. This will lead to problems. You can\u0027t make sure customers do right things.","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d028afe451e1cbbf3810be7cb95dd4ec254b451a","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_1a1ef86f","line":1185,"in_reply_to":"7a5de9d1_749adb6f","updated":"2016-02-02 06:18:37.000000000","message":"Okay, will update the specs.\nNo, I want keep this new feature\u0027s behavior consistent with uploading volume to image, so wouldn\u0027t do it.","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"e78a553a61e3b0c9b7ec04deb83bac3c0184a357","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_9428d0e3","line":1185,"in_reply_to":"7a5de9d1_75948fe1","updated":"2016-01-30 07:30:03.000000000","message":"Well, I\u0027m not sure your scenario can work, currently cinder will not use \u0027container_format\u0027 and \u0027disk_format\u0027 in volume_glance_metadata to create the image, the metadata of volume_glance_metadata just will be properties in new image, see line #1152.\n\nSo if you upload volume to image, either you specify those two arguments or cinder will use default value to create new image.\n\nIn the same way, of course we can update those two with default value in here if user didn\u0027t specify them in new image, and then show the image info. But it\u0027s a little complex for this ,so why not guide users specify disk_format and container_format when creating image and then upload volume to it.","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"8520cdca9fe1857b565b2449cee14cd24fa115e8","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_749adb6f","line":1185,"in_reply_to":"7a5de9d1_9428d0e3","updated":"2016-02-01 06:58:03.000000000","message":"If you do it like this. Please note it in your specs. \n\nMeanwhile, when uploading volume to specified image, if the format of volume volume_glance_metadata is different from the format of the image, should it be prohibited?","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d0401ffb9ef3aee27536abe2f029cd8868db8f11","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1183,"context_line":"                    reason\u003d_(\"Image status should be \u0027queued\u0027.\"))"},{"line_number":1184,"context_line":"            if container_format is None or disk_format is None:"},{"line_number":1185,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1186,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1187,"context_line":"                    reason\u003d_(\"Container format or Disk format should be \""},{"line_number":1188,"context_line":"                             \"specified.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_010be7d6","line":1185,"in_reply_to":"7a5de9d1_eb330c12","updated":"2016-02-02 08:23:18.000000000","message":"I didn\u0027t get you... forget this feature, customers also need to specify disk format and container format in upload volume to image API, if they don\u0027t, cinder will use default value \u0027raw\u0027 and \u0027bare\u0027. So what\u0027s problems will raise if the format of volume_glance_metadata is different from the format of the image?","commit_id":"7797d66867b866766f3469de7a163e5e19c27e9f"}],"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fdfa08a929fe79ef071abc7ff97cc1a190558aed","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        \"\"\""},{"line_number":1193,"context_line":"        payload \u003d {\u0027volume_id\u0027: volume_id, \u0027image_id\u0027: image_meta[\u0027id\u0027]}"},{"line_number":1194,"context_line":"        specify_image \u003d image_meta.pop(\u0027specify_image\u0027, None)"},{"line_number":1195,"context_line":"        image_service \u003d None"},{"line_number":1196,"context_line":"        try:"},{"line_number":1197,"context_line":"            volume \u003d self.db.volume_get(context, volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2c803646","line":1194,"range":{"start_line":1194,"start_character":8,"end_line":1194,"end_character":61},"updated":"2016-01-26 18:39:11.000000000","message":"I think this should be a separate argument of the method. I wonder if it wouldn\u0027t be even better","commit_id":"ada12be305f1b4ac00f10b71af996e5e1311ca62"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c68142bffc43b95a4a62f422b95f58b780726b72","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        \"\"\""},{"line_number":1193,"context_line":"        payload \u003d {\u0027volume_id\u0027: volume_id, \u0027image_id\u0027: image_meta[\u0027id\u0027]}"},{"line_number":1194,"context_line":"        specify_image \u003d image_meta.pop(\u0027specify_image\u0027, None)"},{"line_number":1195,"context_line":"        image_service \u003d None"},{"line_number":1196,"context_line":"        try:"},{"line_number":1197,"context_line":"            volume \u003d self.db.volume_get(context, volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_1edb06ef","line":1194,"range":{"start_line":1194,"start_character":8,"end_line":1194,"end_character":61},"in_reply_to":"9a68dd71_2c803646","updated":"2016-01-27 03:10:55.000000000","message":"separate argument is a good idea. Will change this.","commit_id":"ada12be305f1b4ac00f10b71af996e5e1311ca62"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"8c73062812fee0c9ef971011eff729f108ae4416","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        1.37 - Adds old_reservations parameter to retype to support quota"},{"line_number":89,"context_line":"               checks in the API."},{"line_number":90,"context_line":"        1.38 - Pass specify_image in image metadata if uploading volume to"},{"line_number":91,"context_line":"               specific image."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_5a2eb8a5","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":23},"updated":"2016-01-25 18:07:19.000000000","message":"\"to an existing image\" makes more sense here I think, as the image is always specific.","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1c4c65ba65ba1f56a91716e7595d4038cc7ce6e3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        1.37 - Adds old_reservations parameter to retype to support quota"},{"line_number":89,"context_line":"               checks in the API."},{"line_number":90,"context_line":"        1.38 - Pass specify_image in image metadata if uploading volume to"},{"line_number":91,"context_line":"               specific image."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    BASE_RPC_API_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_0a61bbd3","line":91,"range":{"start_line":91,"start_character":15,"end_line":91,"end_character":23},"in_reply_to":"9a68dd71_5a2eb8a5","updated":"2016-01-26 08:23:27.000000000","message":"Done","commit_id":"39138d619afd0c4679539612e3a83dc114294db3"}]}