)]}'
{"cinder/volume/drivers/huawei/huawei_iscsi.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"12ad8c90112fc0ee7ca305393acb079caaf0289c","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def _change_lun_controller(self, lun_id, controller):"},{"line_number":1464,"context_line":"        cli_cmd \u003d (\u0027chglun -lun %s -c %s\u0027 % (lun_id, controller))"},{"line_number":1465,"context_line":"        out \u003d self._execute_cli(cli_cmd)"},{"line_number":1466,"context_line":"        if not re.search(\u0027command operates successfully\u0027, out):"},{"line_number":1467,"context_line":"            err_msg \u003d (_(\u0027_change_lun_controller:Failed to change lun owning\u0027"},{"line_number":1468,"context_line":"                         \u0027controller. lun id:%(lunid)s. \u0027"},{"line_number":1469,"context_line":"                         \u0027new controller:%(controller)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FvxE%3D","line":1466,"updated":"2013-04-25 01:11:41.000000000","message":"I am worried about the way it processes here. It seems \"out\" can give out something indicating the command is NOT successfully executed. In this case, should we raise an exception? It is not a good approach to simply log the error message without doing anything else.","commit_id":"ca4c4eb13419e150a65e79384082ed324c36990b"},{"author":{"_account_id":6604,"name":"zhangchao","email":"zhangchao010@huawei.com","username":"zhangchao010"},"change_message_id":"c318ff7ade1efc8cca044410eeb9e8962bd54d8e","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def _change_lun_controller(self, lun_id, controller):"},{"line_number":1464,"context_line":"        cli_cmd \u003d (\u0027chglun -lun %s -c %s\u0027 % (lun_id, controller))"},{"line_number":1465,"context_line":"        out \u003d self._execute_cli(cli_cmd)"},{"line_number":1466,"context_line":"        if not re.search(\u0027command operates successfully\u0027, out):"},{"line_number":1467,"context_line":"            err_msg \u003d (_(\u0027_change_lun_controller:Failed to change lun owning\u0027"},{"line_number":1468,"context_line":"                         \u0027controller. lun id:%(lunid)s. \u0027"},{"line_number":1469,"context_line":"                         \u0027new controller:%(controller)s. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fvuc%3D","line":1466,"in_reply_to":"AAAAOn%2F%2FvxE%3D","updated":"2013-04-25 03:16:43.000000000","message":"Thanks for your review. I\u0027ll raise an exception in new patch.","commit_id":"ca4c4eb13419e150a65e79384082ed324c36990b"}]}