)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"a54d0e47ecfb3c455be46044ac5f3195f7348ac3","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"            if snapshots_model_update:"},{"line_number":2963,"context_line":"                for snap_model in snapshots_model_update:"},{"line_number":2964,"context_line":"                    # Update db if status is error"},{"line_number":2965,"context_line":"                    if snap_model[\u0027status\u0027] \u003d\u003d \u0027error\u0027:"},{"line_number":2966,"context_line":"                        # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2967,"context_line":"                        # snapshots_model_update should be a list of dicts."},{"line_number":2968,"context_line":"                        snap \u003d next((item for item in snapshots if"},{"line_number":2969,"context_line":"                                     item.id \u003d\u003d snap_model[\u0027id\u0027]), None)"},{"line_number":2970,"context_line":"                        if snap:"},{"line_number":2971,"context_line":"                            snap.status \u003d snap_model[\u0027status\u0027]"},{"line_number":2972,"context_line":"                            snap.save()"},{"line_number":2973,"context_line":""},{"line_number":2974,"context_line":"                    if (snap_model[\u0027status\u0027] in [\u0027error_deleting\u0027, \u0027error\u0027] and"},{"line_number":2975,"context_line":"                            model_update[\u0027status\u0027] not in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_24c8eca7","line":2972,"range":{"start_line":2965,"start_character":20,"end_line":2972,"end_character":39},"updated":"2016-02-05 04:22:52.000000000","message":"I don\u0027t think we would need to do this anymore since we will do the db update with the snap_model anyway, right?","commit_id":"746cdb9febc6083972471e2076f54bf616b1aad1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e4ef99d8efda826dd0a57deace334598349c2f3c","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"            if snapshots_model_update:"},{"line_number":2963,"context_line":"                for snap_model in snapshots_model_update:"},{"line_number":2964,"context_line":"                    # Update db if status is error"},{"line_number":2965,"context_line":"                    if snap_model[\u0027status\u0027] \u003d\u003d \u0027error\u0027:"},{"line_number":2966,"context_line":"                        # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2967,"context_line":"                        # snapshots_model_update should be a list of dicts."},{"line_number":2968,"context_line":"                        snap \u003d next((item for item in snapshots if"},{"line_number":2969,"context_line":"                                     item.id \u003d\u003d snap_model[\u0027id\u0027]), None)"},{"line_number":2970,"context_line":"                        if snap:"},{"line_number":2971,"context_line":"                            snap.status \u003d snap_model[\u0027status\u0027]"},{"line_number":2972,"context_line":"                            snap.save()"},{"line_number":2973,"context_line":""},{"line_number":2974,"context_line":"                    if (snap_model[\u0027status\u0027] in [\u0027error_deleting\u0027, \u0027error\u0027] and"},{"line_number":2975,"context_line":"                            model_update[\u0027status\u0027] not in"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_853987f4","line":2972,"range":{"start_line":2965,"start_character":20,"end_line":2972,"end_character":39},"in_reply_to":"5a5ae5dd_24c8eca7","updated":"2016-02-05 14:20:01.000000000","message":"I think you are right.  Let me fix it.  Thanks!","commit_id":"746cdb9febc6083972471e2076f54bf616b1aad1"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"ef805190eb13844b22e40e7ce512dd56d13a8fd7","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"                    # Update db for snapshot."},{"line_number":2970,"context_line":"                    # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2971,"context_line":"                    # snapshots_model_update should be a list of dicts."},{"line_number":2972,"context_line":"                    snap \u003d next((item for item in snapshots if"},{"line_number":2973,"context_line":"                                 item.id \u003d\u003d snap_model[\u0027id\u0027]), None)"},{"line_number":2974,"context_line":"                    if snap:"},{"line_number":2975,"context_line":"                        snap.update(snap_model)"},{"line_number":2976,"context_line":"                        snap.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_e575cd97","line":2973,"range":{"start_line":2972,"start_character":20,"end_line":2973,"end_character":68},"updated":"2016-02-05 18:55:58.000000000","message":"Could we just do the db update like in the last patchset and skip having to search the list of objects for the matching id? Seems like this is pretty inefficient just to use the db object :(","commit_id":"908d19a48687b7fa22e44770a8210e7e3c6e74d5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d78473a31977d3a9e8a82c36e6225600eaa4a4bc","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"                    # Update db for snapshot."},{"line_number":2970,"context_line":"                    # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2971,"context_line":"                    # snapshots_model_update should be a list of dicts."},{"line_number":2972,"context_line":"                    snap \u003d next((item for item in snapshots if"},{"line_number":2973,"context_line":"                                 item.id \u003d\u003d snap_model[\u0027id\u0027]), None)"},{"line_number":2974,"context_line":"                    if snap:"},{"line_number":2975,"context_line":"                        snap.update(snap_model)"},{"line_number":2976,"context_line":"                        snap.save()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_8942a7ac","line":2973,"range":{"start_line":2972,"start_character":20,"end_line":2973,"end_character":68},"in_reply_to":"5a5ae5dd_e575cd97","updated":"2016-02-08 19:24:04.000000000","message":"Sure.  I thought we are supposed to use object instead of db update directly.  I\u0027ll change it.","commit_id":"908d19a48687b7fa22e44770a8210e7e3c6e74d5"}]}