)]}'
{"cinder/volume/targets/lio.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d78211e05f664e6e7bdb4fac935465145e3dcef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Restore saved configuration file if no target exists."},{"line_number":37,"context_line":"        targets \u003d self._get_targets()"},{"line_number":38,"context_line":"        if not targets:"},{"line_number":39,"context_line":"            self._restore_configuration()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _verify_rtstool(self):"},{"line_number":42,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_4e32c3f3","line":39,"updated":"2016-02-05 18:03:26.000000000","message":"I\u0027m not sure this is where we want to do this...\n\nAnd if we are doing the _restore_configuration I believe we don\u0027t need to do the ensure_export in init_host.","commit_id":"cd48a9c2c607c44f4cfe42379bd2622bc4f81fe3"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"71128f541e5fa47725255bdcfadd40f0ac121193","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # Restore saved configuration file if no target exists."},{"line_number":37,"context_line":"        targets \u003d self._get_targets()"},{"line_number":38,"context_line":"        if not targets:"},{"line_number":39,"context_line":"            self._restore_configuration()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _verify_rtstool(self):"},{"line_number":42,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_d9561506","line":39,"in_reply_to":"5a5ae5dd_4e32c3f3","updated":"2016-02-09 22:59:18.000000000","message":"I understand. I moved this logic into ensure_export path. Thanks.","commit_id":"cd48a9c2c607c44f4cfe42379bd2622bc4f81fe3"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c5c010ec5769ecb1353ed2ccfab7e78a2c15f954","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        LOG.info(_LI(\u0027Creating iscsi_target for volume: %s\u0027), vol_id)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Restore saved configuration file if we are on ensure_export path"},{"line_number":108,"context_line":"        # and if no target exists."},{"line_number":109,"context_line":"        if kwargs.get(\u0027ensure\u0027, None) and not self._get_targets():"},{"line_number":110,"context_line":"            self._restore_configuration()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_1420d59a","line":107,"updated":"2016-02-10 13:24:44.000000000","message":"I don\u0027t think this would be the best place either...  If we really go with this solution, do we really need to manually create the targets?  They will be automatically created when we load the configuration file, so we can directly override ensure_export and just load the file in there and we don\u0027t have to anything else afaik.","commit_id":"5b955c7027c2379ab43e2047646131c59567bedb"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"3a66cfbe90eb135b551e2c7489bd56db0492e4fe","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        LOG.info(_LI(\u0027Creating iscsi_target for volume: %s\u0027), vol_id)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Restore saved configuration file if we are on ensure_export path"},{"line_number":108,"context_line":"        # and if no target exists."},{"line_number":109,"context_line":"        if kwargs.get(\u0027ensure\u0027, None) and not self._get_targets():"},{"line_number":110,"context_line":"            self._restore_configuration()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_83580afc","line":107,"in_reply_to":"3a57f1b5_1420d59a","updated":"2016-02-10 14:28:22.000000000","message":"Thank you for your suggestion. I think this idea is more reasonable.","commit_id":"5b955c7027c2379ab43e2047646131c59567bedb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c5c010ec5769ecb1353ed2ccfab7e78a2c15f954","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # Restore saved configuration file if we are on ensure_export path"},{"line_number":108,"context_line":"        # and if no target exists."},{"line_number":109,"context_line":"        if kwargs.get(\u0027ensure\u0027, None) and not self._get_targets():"},{"line_number":110,"context_line":"            self._restore_configuration()"},{"line_number":111,"context_line":"            return"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_992f20a1","line":109,"updated":"2016-02-10 13:24:44.000000000","message":"nit: No need to set None as get\u0027s default, it is the default value.","commit_id":"5b955c7027c2379ab43e2047646131c59567bedb"}]}