)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"acde469e2067b66f3043bc4fb1ffd011f2160c17","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Volume manage/unmanage support to ZFSSA drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow cinder to manage existing volumes on a ZFSSA backend"},{"line_number":10,"context_line":"and also unmanage them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f280a2dfdb9cc6ce739b340eefa562f98d4038f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_6bfee339","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2016-01-28 17:01:52.000000000","message":"Lines should be wrapped at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Volume manage/unmanage support to ZFSSA drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow cinder to manage existing volumes on a ZFSSA backend"},{"line_number":10,"context_line":"and also unmanage them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f280a2dfdb9cc6ce739b340eefa562f98d4038f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_775fa141","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"in_reply_to":"7a5de9d1_6bfee339","updated":"2016-01-28 18:51:47.000000000","message":"Done","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"acde469e2067b66f3043bc4fb1ffd011f2160c17","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow cinder to manage existing volumes on a ZFSSA backend"},{"line_number":10,"context_line":"and also unmanage them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f280a2dfdb9cc6ce739b340eefa562f98d4038f"},{"line_number":13,"context_line":"Implements: blueprint oracle-zfssa-volume-manage-unmanage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_6b7343e8","line":11,"updated":"2016-01-28 17:01:52.000000000","message":"We need a DocImpact tag here since config options are being added.","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow cinder to manage existing volumes on a ZFSSA backend"},{"line_number":10,"context_line":"and also unmanage them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f280a2dfdb9cc6ce739b340eefa562f98d4038f"},{"line_number":13,"context_line":"Implements: blueprint oracle-zfssa-volume-manage-unmanage"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a5de9d1_975a5d4f","line":11,"in_reply_to":"7a5de9d1_6b7343e8","updated":"2016-01-28 18:51:47.000000000","message":"Done","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"}],"cinder/tests/unit/test_zfssa.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"f0b7b1ce1befe79dd9b38fb47e2a974baa98b3a6","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1191,"context_line":"                          self.drv.manage_existing,"},{"line_number":1192,"context_line":"                          {\u0027name\u0027: \u0027volume-123\u0027},"},{"line_number":1193,"context_line":"                          {\u0027source-name\u0027: \u0027volume-567\u0027})"},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"        test_vol.update({\u0027cinder_managed\u0027: \u0027True\u0027})"},{"line_number":1196,"context_line":"        self.drv.zfssa.get_volume.return_value \u003d test_vol"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5e0dce8e","line":1193,"range":{"start_line":1193,"start_character":0,"end_line":1193,"end_character":26},"updated":"2016-01-29 02:53:56.000000000","message":"Your py27 check failed in line 1193 as a KeyError. Either you modify your test case or you will fix it in _verify_volume_manage() to use vol_props.get(\u0027cinder_managed\u0027, \"\") or something like this to avoid the failure.","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"6b6ca17d16a5f55dd832314dd92722605bd4fcae","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        self.assertRaises(exception.InvalidInput,"},{"line_number":1191,"context_line":"                          self.drv.manage_existing,"},{"line_number":1192,"context_line":"                          {\u0027name\u0027: \u0027volume-123\u0027},"},{"line_number":1193,"context_line":"                          {\u0027source-name\u0027: \u0027volume-567\u0027})"},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"        test_vol.update({\u0027cinder_managed\u0027: \u0027True\u0027})"},{"line_number":1196,"context_line":"        self.drv.zfssa.get_volume.return_value \u003d test_vol"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_e272bb10","line":1193,"range":{"start_line":1193,"start_character":0,"end_line":1193,"end_character":26},"in_reply_to":"7a5de9d1_5e0dce8e","updated":"2016-01-29 16:00:02.000000000","message":"Done","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6ddeea855eb38a48851e6e8e8a9844119f1894ba","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.StrOpt(\u0027zfssa_cache_project\u0027, default\u003d\u0027os-cinder-cache\u0027,"},{"line_number":88,"context_line":"               help\u003d\u0027Name of ZFSSA project where cache volumes are stored.\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027lenient\u0027,"},{"line_number":90,"context_line":"               choices\u003d[\u0027lenient\u0027, \u0027strict\u0027],"},{"line_number":91,"context_line":"               help\u003d\u0027Driver policy for volume manage.\u0027)"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_4278ba8f","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":32},"updated":"2016-01-28 13:03:54.000000000","message":"Not sure if the word lenient is too elaborated to use. Could it be something more like: \u0027loose\u0027?\nAlso you could make these 2 options a constant list so it can be reused in multiple places","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.StrOpt(\u0027zfssa_cache_project\u0027, default\u003d\u0027os-cinder-cache\u0027,"},{"line_number":88,"context_line":"               help\u003d\u0027Name of ZFSSA project where cache volumes are stored.\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027lenient\u0027,"},{"line_number":90,"context_line":"               choices\u003d[\u0027lenient\u0027, \u0027strict\u0027],"},{"line_number":91,"context_line":"               help\u003d\u0027Driver policy for volume manage.\u0027)"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_d75d357a","line":90,"range":{"start_line":90,"start_character":25,"end_line":90,"end_character":32},"in_reply_to":"7a5de9d1_4278ba8f","updated":"2016-01-28 18:51:47.000000000","message":"Done","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6ddeea855eb38a48851e6e8e8a9844119f1894ba","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"                                     name\u003dnew_vol_name,"},{"line_number":1008,"context_line":"                                     schema\u003d{\"custom:cinder_managed\": True})"},{"line_number":1009,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":1010,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1011,"context_line":"                LOG.error(_LE(\"Failed to rename volume %(existing)s to \""},{"line_number":1012,"context_line":"                              \"%(new)s. Volume manage failed.\"),"},{"line_number":1013,"context_line":"                          {\u0027existing\u0027: existing_vol[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_c2c02a7f","line":1010,"updated":"2016-01-28 13:03:54.000000000","message":"What is the intent of using excutils rather that using logging directly the exception","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"                                     name\u003dnew_vol_name,"},{"line_number":1008,"context_line":"                                     schema\u003d{\"custom:cinder_managed\": True})"},{"line_number":1009,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":1010,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1011,"context_line":"                LOG.error(_LE(\"Failed to rename volume %(existing)s to \""},{"line_number":1012,"context_line":"                              \"%(new)s. Volume manage failed.\"),"},{"line_number":1013,"context_line":"                          {\u0027existing\u0027: existing_vol[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_7c5a3352","line":1010,"in_reply_to":"7a5de9d1_c2c02a7f","updated":"2016-01-28 18:51:47.000000000","message":"save_and_reraise_exception() raises the exception that was returned from the call. It is similar to \"reraise\". If we didnt have save_and_reraise_exception() or \"reraise\" the exception would be masked and only an error message would get logged. My intent was to throw the exception as well along with an error message which explained the reason for the exception.","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6ddeea855eb38a48851e6e8e8a9844119f1894ba","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"        lcfg \u003d self.configuration"},{"line_number":1047,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027lenient\u0027:"},{"line_number":1050,"context_line":"            return"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if \u0027cinder_managed\u0027 not in volume:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_8268f288","line":1049,"range":{"start_line":1049,"start_character":40,"end_line":1049,"end_character":47},"updated":"2016-01-28 13:03:54.000000000","message":"Same comment about the term","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"        lcfg \u003d self.configuration"},{"line_number":1047,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027lenient\u0027:"},{"line_number":1050,"context_line":"            return"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if \u0027cinder_managed\u0027 not in volume:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_9c128f61","line":1049,"range":{"start_line":1049,"start_character":40,"end_line":1049,"end_character":47},"in_reply_to":"7a5de9d1_8268f288","updated":"2016-01-28 18:51:47.000000000","message":"Done","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"e1e1f469896f9b531f8b25e85aab7ef627ba6dfa","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.zfssa.add_to_targetgroup(iqn, lcfg.zfssa_target_group)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if lcfg.zfssa_manage_policy not in (\"loose\", \"strict\"):"},{"line_number":229,"context_line":"            err_msg \u003d (_(\"zfssa_manage_policy property needs to be set to\""},{"line_number":230,"context_line":"                         \" \u0027strict\u0027 or \u0027loose\u0027. Current value is: %s.\") %"},{"line_number":231,"context_line":"                       lcfg.zfssa_manage_policy)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_15f057fd","line":228,"updated":"2016-01-30 17:15:07.000000000","message":"Seems like you\u0027re enforcing to use the property? Maybe there should be a \u0027default\u0027 value/behavior if it\u0027s not defined.\nI\u0027m not too convince that throwing an exception is the right thing to do here.\nA warning might be better in case the user forgot to set the property.","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"a46dd42c44870d59abcff75c187214d2e1eb30bd","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.zfssa.add_to_targetgroup(iqn, lcfg.zfssa_target_group)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if lcfg.zfssa_manage_policy not in (\"loose\", \"strict\"):"},{"line_number":229,"context_line":"            err_msg \u003d (_(\"zfssa_manage_policy property needs to be set to\""},{"line_number":230,"context_line":"                         \" \u0027strict\u0027 or \u0027loose\u0027. Current value is: %s.\") %"},{"line_number":231,"context_line":"                       lcfg.zfssa_manage_policy)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_4b44eeb5","line":228,"in_reply_to":"7a5de9d1_15f057fd","updated":"2016-01-30 21:39:28.000000000","message":"the default value is \u0027loose\u0027 if it is not defined by the user. See the cinder.conf property defined at the top of this file(line 82). \nThis check is if the user overrides the default and chooses something different than \u0027loose\u0027 or \u0027strict\u0027. In that case we should throw exception to notify the user that the driver is misconfigured.","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"3e50a4de5940342d506165143aca2c8cba90de34","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        self.zfssa.add_to_targetgroup(iqn, lcfg.zfssa_target_group)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if lcfg.zfssa_manage_policy not in (\"loose\", \"strict\"):"},{"line_number":229,"context_line":"            err_msg \u003d (_(\"zfssa_manage_policy property needs to be set to\""},{"line_number":230,"context_line":"                         \" \u0027strict\u0027 or \u0027loose\u0027. Current value is: %s.\") %"},{"line_number":231,"context_line":"                       lcfg.zfssa_manage_policy)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_57bd6cb5","line":228,"in_reply_to":"7a5de9d1_4b44eeb5","updated":"2016-01-31 15:07:53.000000000","message":"Got it, actually is line 89 that sets the default value to \u0027loose\u0027","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"cc41f0831b31d35c13a1ac6463cd0dc36a7fc020","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027loose\u0027:"},{"line_number":1050,"context_line":"            return"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if \u0027cinder_managed\u0027 not in volume:"},{"line_number":1053,"context_line":"            err_msg \u003d (_(\"Unknown if the volume: %s to be managed is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_cda0a844","line":1050,"range":{"start_line":1050,"start_character":0,"end_line":1050,"end_character":12},"updated":"2016-02-03 02:51:38.000000000","message":"Maybe you can move line 1049~1050 before line 1047 as vol_name may not be used if return.","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"0793a273c66f5035bbdeeab05d269959d9fc9281","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        vol_name \u003d volume[\u0027name\u0027]"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if lcfg.zfssa_manage_policy \u003d\u003d \u0027loose\u0027:"},{"line_number":1050,"context_line":"            return"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if \u0027cinder_managed\u0027 not in volume:"},{"line_number":1053,"context_line":"            err_msg \u003d (_(\"Unknown if the volume: %s to be managed is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_8be7c83f","line":1050,"range":{"start_line":1050,"start_character":0,"end_line":1050,"end_character":12},"in_reply_to":"7a5de9d1_cda0a844","updated":"2016-02-03 16:29:41.000000000","message":"Done","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"cc41f0831b31d35c13a1ac6463cd0dc36a7fc020","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                         \"already being managed by Cinder. Aborting manage \""},{"line_number":1055,"context_line":"                         \"volume. Please add \u0027cinder_managed\u0027 custom schema \""},{"line_number":1056,"context_line":"                         \"property to the volume and set its value to False.\""},{"line_number":1057,"context_line":"                         \" Alternatively, Set the value of cinder config \""},{"line_number":1058,"context_line":"                         \"policy \u0027zfssa_manage_policy\u0027 to \u0027loose\u0027 to \""},{"line_number":1059,"context_line":"                         \"remove this restriction.\") % vol_name)"},{"line_number":1060,"context_line":"            LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_9f0bab7d","line":1057,"range":{"start_line":1057,"start_character":27,"end_line":1057,"end_character":40},"updated":"2016-02-03 02:51:38.000000000","message":"s/Set/set","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"0793a273c66f5035bbdeeab05d269959d9fc9281","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                         \"already being managed by Cinder. Aborting manage \""},{"line_number":1055,"context_line":"                         \"volume. Please add \u0027cinder_managed\u0027 custom schema \""},{"line_number":1056,"context_line":"                         \"property to the volume and set its value to False.\""},{"line_number":1057,"context_line":"                         \" Alternatively, Set the value of cinder config \""},{"line_number":1058,"context_line":"                         \"policy \u0027zfssa_manage_policy\u0027 to \u0027loose\u0027 to \""},{"line_number":1059,"context_line":"                         \"remove this restriction.\") % vol_name)"},{"line_number":1060,"context_line":"            LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_4bd0f053","line":1057,"range":{"start_line":1057,"start_character":27,"end_line":1057,"end_character":40},"in_reply_to":"5a5ae5dd_9f0bab7d","updated":"2016-02-03 16:29:41.000000000","message":"Done","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"cc41f0831b31d35c13a1ac6463cd0dc36a7fc020","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                                              lcfg.zfssa_project,"},{"line_number":1079,"context_line":"                                              existing_ref[\u0027source-name\u0027])"},{"line_number":1080,"context_line":"        except exception.VolumeNotFound:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Volume %s doesn\u0027t existing on the ZFSSA \""},{"line_number":1082,"context_line":"                         \"backend.\") % existing_vol[\u0027name\u0027])"},{"line_number":1083,"context_line":"            LOG.error(err_msg)"},{"line_number":1084,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_4d1a78c7","line":1081,"range":{"start_line":1081,"start_character":44,"end_line":1081,"end_character":52},"updated":"2016-02-03 02:51:38.000000000","message":"s/doesn\u0027t existing/doesn\u0027t exist","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"0793a273c66f5035bbdeeab05d269959d9fc9281","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                                              lcfg.zfssa_project,"},{"line_number":1079,"context_line":"                                              existing_ref[\u0027source-name\u0027])"},{"line_number":1080,"context_line":"        except exception.VolumeNotFound:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Volume %s doesn\u0027t existing on the ZFSSA \""},{"line_number":1082,"context_line":"                         \"backend.\") % existing_vol[\u0027name\u0027])"},{"line_number":1083,"context_line":"            LOG.error(err_msg)"},{"line_number":1084,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_2bcfb4b1","line":1081,"range":{"start_line":1081,"start_character":44,"end_line":1081,"end_character":52},"in_reply_to":"7a5de9d1_4d1a78c7","updated":"2016-02-03 16:29:41.000000000","message":"Done","commit_id":"6d1077206e64f14ebd18ae9e93d62bd9d9f10fb0"}],"cinder/volume/drivers/zfssa/zfssanfs.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6ddeea855eb38a48851e6e8e8a9844119f1894ba","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    cfg.StrOpt(\u0027zfssa_cache_directory\u0027, default\u003d\u0027os-cinder-cache\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Name of directory inside zfssa_nfs_share where cache \u0027"},{"line_number":63,"context_line":"                    \u0027volumes are stored.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027lenient\u0027,"},{"line_number":65,"context_line":"               choices\u003d[\u0027lenient\u0027, \u0027strict\u0027],"},{"line_number":66,"context_line":"               help\u003d\u0027Driver policy for volume manage.\u0027)"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_e2d1a6ce","line":64,"updated":"2016-01-28 13:03:54.000000000","message":"Same comment as the ones in zfssaiscsi.py","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    cfg.StrOpt(\u0027zfssa_cache_directory\u0027, default\u003d\u0027os-cinder-cache\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Name of directory inside zfssa_nfs_share where cache \u0027"},{"line_number":63,"context_line":"                    \u0027volumes are stored.\u0027),"},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027zfssa_manage_policy\u0027, default\u003d\u0027lenient\u0027,"},{"line_number":65,"context_line":"               choices\u003d[\u0027lenient\u0027, \u0027strict\u0027],"},{"line_number":66,"context_line":"               help\u003d\u0027Driver policy for volume manage.\u0027)"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_7c08f32d","line":64,"in_reply_to":"7a5de9d1_e2d1a6ce","updated":"2016-01-28 18:51:47.000000000","message":"Done","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"}],"cinder/volume/drivers/zfssa/zfssarest.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6ddeea855eb38a48851e6e8e8a9844119f1894ba","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            \u0027updated_at\u0027: self._parse_prop(resp, \u0027updated_at\u0027),"},{"line_number":1236,"context_line":"            \u0027image_id\u0027: self._parse_prop(resp, \u0027image_id\u0027),"},{"line_number":1237,"context_line":"            \u0027origin\u0027: self._parse_prop(resp, \u0027origin\u0027),"},{"line_number":1238,"context_line":"            \u0027cinder_managed\u0027: self._parse_prop(resp, \u0027cinder_managed\u0027),"},{"line_number":1239,"context_line":"        }"},{"line_number":1240,"context_line":"        return result"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_a2f96e82","line":1238,"updated":"2016-01-28 13:03:54.000000000","message":"Not sure if this prop is going to be available in case the volume comes from an old version of the driver, and it has not been \u0027tagged\u0027.","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"43a3d6121681b0f1c2e92ef701c97b15c6ac3ec7","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            \u0027updated_at\u0027: self._parse_prop(resp, \u0027updated_at\u0027),"},{"line_number":1236,"context_line":"            \u0027image_id\u0027: self._parse_prop(resp, \u0027image_id\u0027),"},{"line_number":1237,"context_line":"            \u0027origin\u0027: self._parse_prop(resp, \u0027origin\u0027),"},{"line_number":1238,"context_line":"            \u0027cinder_managed\u0027: self._parse_prop(resp, \u0027cinder_managed\u0027),"},{"line_number":1239,"context_line":"        }"},{"line_number":1240,"context_line":"        return result"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_1fa0d19e","line":1238,"in_reply_to":"7a5de9d1_a2f96e82","updated":"2016-01-28 18:51:47.000000000","message":"Actually _parse_prop will return \"\" if it doesnt find \"cinder_managed\" prop. The check in zfssanfs will check for \"\"(empty string) to verify if the volume has been tagged or not.","commit_id":"33878ec4ab32b874f8cd7c5e39ec77745caa2253"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"60a5a5a5e24b2c45792a2aa3b0eab6e6dc1b4f0c","unresolved":false,"context_lines":[{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        if \u0027schema\u0027 in kargs:"},{"line_number":903,"context_line":"            kargs.update(kargs[\u0027schema\u0027])"},{"line_number":904,"context_line":"            del kargs[\u0027schema\u0027]"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        ret \u003d self.rclient.put(svc, kargs)"},{"line_number":907,"context_line":"        if ret.status !\u003d restclient.Status.ACCEPTED:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c51b14c9","line":904,"range":{"start_line":904,"start_character":29,"end_line":904,"end_character":31},"updated":"2016-01-29 12:56:33.000000000","message":"You can replace the above two lines with:\n\nkargs.update(kwargs.pop(\u0027schema\u0027))\n\nWhich will eliminate the need to explicitly call del kargs[\u0027schema\u0027]","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"6b6ca17d16a5f55dd832314dd92722605bd4fcae","unresolved":false,"context_lines":[{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        if \u0027schema\u0027 in kargs:"},{"line_number":903,"context_line":"            kargs.update(kargs[\u0027schema\u0027])"},{"line_number":904,"context_line":"            del kargs[\u0027schema\u0027]"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        ret \u003d self.rclient.put(svc, kargs)"},{"line_number":907,"context_line":"        if ret.status !\u003d restclient.Status.ACCEPTED:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_02cd9765","line":904,"range":{"start_line":904,"start_character":29,"end_line":904,"end_character":31},"in_reply_to":"7a5de9d1_c51b14c9","updated":"2016-01-29 16:00:02.000000000","message":"Done","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"}],"releasenotes/notes/zfssa-volume-manage-unmanage-ccd80807103b69c8.yaml":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"60a5a5a5e24b2c45792a2aa3b0eab6e6dc1b4f0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - Volume manage/unmanage support for Oracle ZFSSA iSCSI and NFS drivers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a5de9d1_453e44db","line":2,"range":{"start_line":2,"start_character":66,"end_line":2,"end_character":73},"updated":"2016-01-29 12:56:33.000000000","message":"Just a question, does it add manage/unmanage support only for Oracle ZFSSA iSCSI driver or NFS driver as well.\n\nEither you need to update this release note or the commit message which only talks about ZFSSA driver.","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"6b6ca17d16a5f55dd832314dd92722605bd4fcae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"features:"},{"line_number":2,"context_line":"  - Volume manage/unmanage support for Oracle ZFSSA iSCSI and NFS drivers."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a5de9d1_827bc7f4","line":2,"range":{"start_line":2,"start_character":66,"end_line":2,"end_character":73},"in_reply_to":"7a5de9d1_453e44db","updated":"2016-01-29 16:00:02.000000000","message":"The commit message does talk about ZFSSA \"drivers\". plural. I will update the commit message to make it more explicit.","commit_id":"4e85090f003b6cc5f3d6a09b2d1fe2f0fdad3dab"}]}