)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"28a318dbe5a39871c55b9449cf08271dc8eafa2f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"specially designed for high throughput/low latency scenarios."},{"line_number":16,"context_line":"Addition of support for ZeroMQ would help cinder scale out with high"},{"line_number":17,"context_line":"performance and be highly available as there is no centralised broker."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic4b4301e5d7ca1692fc91155ba53f2dd12f99311"},{"line_number":20,"context_line":"Closes-Bug: #1440631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a68dd71_4db3120b","line":18,"updated":"2016-01-27 06:01:28.000000000","message":"Please add \"DOcImact\" to update the documentation for this functionality.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"},{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"52bddc7309caa6ba63d5bc341ce090eac7eac5c9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"specially designed for high throughput/low latency scenarios."},{"line_number":21,"context_line":"Addition of support for ZeroMQ would help cinder scale out with high"},{"line_number":22,"context_line":"performance and be highly available as there is no centralised broker."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ic4b4301e5d7ca1692fc91155ba53f2dd12f99311"},{"line_number":25,"context_line":"Closes-Bug: #1440631"},{"line_number":26,"context_line":"partially Implements bp cinder-zeromq-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_1a1ba674","line":23,"updated":"2016-01-30 15:24:55.000000000","message":"Add \"DocImpact\" here.","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0af9cb5010324896d7acc72f191ee541c8a013dd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"specially designed for high throughput/low latency scenarios."},{"line_number":21,"context_line":"Addition of support for ZeroMQ would help cinder scale out with high"},{"line_number":22,"context_line":"performance and be highly available as there is no centralised broker."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: Ic4b4301e5d7ca1692fc91155ba53f2dd12f99311"},{"line_number":25,"context_line":"Closes-Bug: #1440631"},{"line_number":26,"context_line":"partially Implements bp cinder-zeromq-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a5de9d1_3fa174f8","line":23,"updated":"2016-02-01 21:37:31.000000000","message":"This DocImpact flag with a brief explanations of what needs to be documented would be useful.","commit_id":"b6e6ef2add54be44fafd139b079945b1ac59f526"}],"cinder/rpc.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0af9cb5010324896d7acc72f191ee541c8a013dd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return cinder.context.RequestContext.from_dict(context)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def get_volume_rpc_host(host):"},{"line_number":146,"context_line":"    if CONF.rpc_backend and CONF.rpc_backend \u003d\u003d \"zmq\":"},{"line_number":147,"context_line":"        #ZeroMQ RPC driver requires only the hostname."},{"line_number":148,"context_line":"        #So, return just that."},{"line_number":149,"context_line":"        return utils.extract_host(host, \u0027host\u0027)"},{"line_number":150,"context_line":"    return utils.extract_host(host)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"def get_client(target, version_cap\u003dNone, serializer\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_bfcfa454","line":150,"range":{"start_line":145,"start_character":0,"end_line":150,"end_character":35},"updated":"2016-02-01 21:37:31.000000000","message":"I think you\u0027ve forgot to add an unit test for this method.","commit_id":"b6e6ef2add54be44fafd139b079945b1ac59f526"}],"cinder/tests/unit/test_volume_utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9ece26256ecfb8c86d3dccaee8018010f4aa1978","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        output \u003d volume_utils.generate_username()"},{"line_number":732,"context_line":"        self.assertEqual(mock_gen_pass.return_value, output)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":735,"context_line":"    def test_only_hostname_required(self, mock_conf):"},{"line_number":736,"context_line":"        mock_conf.rpc_backend \u003d \u0027zmq\u0027"},{"line_number":737,"context_line":"        self.assertTrue(volume_utils.only_hostname_required())"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_3a722212","line":734,"range":{"start_line":734,"start_character":4,"end_line":734,"end_character":43},"updated":"2016-01-30 16:28:35.000000000","message":"It isn\u0027t okay to mock a global variable on a module. This may be problematic when tests are running in parallel. I think the correct way of mocking config option is similar to [1] (you can access self.fixture also inside a test)\n\n[1] https://github.com/openstack/cinder/blob/87157473fbbaa7dbd42e15a4e58985bf7a1b7907/cinder/tests/unit/api/contrib/test_quotas.py#L99","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"75e2279801bd08357e96fd4de6cfc09fe94f2371","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        output \u003d volume_utils.generate_username()"},{"line_number":732,"context_line":"        self.assertEqual(mock_gen_pass.return_value, output)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":735,"context_line":"    def test_only_hostname_required(self, mock_conf):"},{"line_number":736,"context_line":"        mock_conf.rpc_backend \u003d \u0027zmq\u0027"},{"line_number":737,"context_line":"        self.assertTrue(volume_utils.only_hostname_required())"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_ecdb384d","line":734,"range":{"start_line":734,"start_character":4,"end_line":734,"end_character":43},"in_reply_to":"7a5de9d1_3a722212","updated":"2016-02-01 21:08:31.000000000","message":"Done","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"5278150fa4ccc29f9b9480f493915b17e901b070","unresolved":false,"context_lines":[{"line_number":731,"context_line":"        output \u003d volume_utils.generate_username()"},{"line_number":732,"context_line":"        self.assertEqual(mock_gen_pass.return_value, output)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"    @mock.patch(\u0027cinder.volume.utils.CONF\u0027)"},{"line_number":735,"context_line":"    def test_only_hostname_required(self, mock_conf):"},{"line_number":736,"context_line":"        mock_conf.rpc_backend \u003d \u0027zmq\u0027"},{"line_number":737,"context_line":"        self.assertTrue(volume_utils.only_hostname_required())"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_c2cc038b","line":734,"range":{"start_line":734,"start_character":4,"end_line":734,"end_character":43},"in_reply_to":"7a5de9d1_ecdb384d","updated":"2016-02-01 21:58:08.000000000","message":"Filed bug to investigate it...\nhttps://bugs.launchpad.net/cinder/+bug/1540641","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"00d92452bdee4387e399b911113ee1eaf1817b13","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_a598221d","line":113,"range":{"start_line":110,"start_character":8,"end_line":113,"end_character":56},"updated":"2016-01-25 00:58:52.000000000","message":"Following code should do the same.\n\n    cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)","commit_id":"87b0933a2194ed5191bf32a07aad0521e6ee3df5"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"4d90c7b2cf295f1fc66abae4bc26b518611996cf","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_43adf52f","line":113,"range":{"start_line":110,"start_character":8,"end_line":113,"end_character":56},"in_reply_to":"7a5de9d1_1ebc7304","updated":"2016-01-29 02:18:49.000000000","message":"Understood! Will fix it and submit patch set 4.","commit_id":"87b0933a2194ed5191bf32a07aad0521e6ee3df5"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"488c4276a319192cb33d096b4927e2432b5fead6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_8960b902","line":113,"range":{"start_line":110,"start_character":8,"end_line":113,"end_character":56},"in_reply_to":"7a5de9d1_43adf52f","updated":"2016-01-30 06:14:00.000000000","message":"Sorry I was wrong and so were you. Please see my response to Michal\u0027s comment on patch set 3. I have explained this there.","commit_id":"87b0933a2194ed5191bf32a07aad0521e6ee3df5"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9f0c30bc945330c18d43395fb140a851d56d893a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_1ebc7304","line":113,"range":{"start_line":110,"start_character":8,"end_line":113,"end_character":56},"in_reply_to":"9a68dd71_50f22b07","updated":"2016-01-28 06:06:54.000000000","message":"See the comment from Michal on patch set 3.","commit_id":"87b0933a2194ed5191bf32a07aad0521e6ee3df5"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"55ec81711161c7406fff7b229e83bc35b36f076f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_50f22b07","line":113,"range":{"start_line":110,"start_character":8,"end_line":113,"end_character":56},"in_reply_to":"9a68dd71_a598221d","updated":"2016-01-25 13:23:18.000000000","message":"If I\u0027m not missing something, the above code wouldn\u0027t do the same, because the default value of version is not \"None\" in the method definition. See @\nhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/client.py#L312","commit_id":"87b0933a2194ed5191bf32a07aad0521e6ee3df5"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1dda810d02718e573473dfb7a5622fd751b98d06","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_3b02a13f","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":56},"updated":"2016-01-26 23:34:34.000000000","message":"I think you can safely pass version\u003dNone and save us 3 lines of redundant code. From inside of the oslo.messaging:\n\n    def _prepare(cls, base,\n                 exchange\u003d_marker, topic\u003d_marker, namespace\u003d_marker,\n                 version\u003d_marker, server\u003d_marker, fanout\u003d_marker,\n                 timeout\u003d_marker, version_cap\u003d_marker, retry\u003d_marker):\n        \"\"\"Prepare a method invocation context. See RPCClient.prepare().\"\"\"\n        if version is not None and version is not cls._marker:\n\nLooks like _marker is ignored in case of version.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"55331d74b45f1c3048a995d13f3620b0e5f4792c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a9afb528","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":56},"in_reply_to":"7a5de9d1_c33565f7","updated":"2016-01-30 06:10:11.000000000","message":"Sorry I was wrong and so were u. The logic pseudo-code is\n\"\nif version is passed:\n    use the passed version\nelse:\n    use the BASE_RPC_API_VERSION(\u00271.0\u0027)\n\"\n\nSupporting code snippets:\nfrom - cinder/volume/rpcapi.py\n\"\n        target \u003d messaging.Target(topic\u003dCONF.volume_topic,\n                          version\u003dself.BASE_RPC_API_VERSION)\n\"\n\nfrom - oslo_messaging/rpc/client.py\n\"\n        kwargs \u003d dict(\n            exchange\u003dexchange,\n            topic\u003dtopic,\n            namespace\u003dnamespace,\n            version\u003dversion,\n            server\u003dserver,\n            fanout\u003dfanout)\n        kwargs \u003d dict([(k, v) for k, v in kwargs.items()\n                       if v is not cls._marker])\n        target \u003d base.target(**kwargs)\n\"\n\nThe behaviour in patch set 3 was - when no version was passed, the default value set in \u0027BASE_RPC_API_VERSION\u0027 was used; when version is passed, use the passed value.\n\nWhen I changed the patch set 3 with the change(\u0027version\u003dNone\u0027) you suggested,  the effect in patch set 4 was - Value \u0027None\u0027 began to be used in places where \u0027BASE_RPC_API_VERSION\u0027 had been used in patch set 3.\nMany tests in Jenkins \u0027gate-cinder-python27\u0027 and \u0027gate-cinder-python34\u0027 failed.\n\nSo, I uploaded a new patchset 6 which is the same as patchset 3. Now, Jenkins tests passed and gave a +1 on the patch.\n\nI think I\u0027ve made my case clear that the 3 lines of code are not redundant and are required.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"8c069777a965195d217aaecdd964a87b31b10d72","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            new_host \u003d utils.extract_host(host, \u0027host\u0027)"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            new_host \u003d utils.extract_host(host)"},{"line_number":110,"context_line":"        if version:"},{"line_number":111,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            cctxt \u003d self.client.prepare(server\u003dnew_host)"},{"line_number":114,"context_line":"        return cctxt"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_consistencygroup(self, ctxt, group, host):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_c33565f7","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":56},"in_reply_to":"9a68dd71_3b02a13f","updated":"2016-01-29 02:29:13.000000000","message":"Understood! Will fix it and submit patch set 4.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"}],"cinder/volume/utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1dda810d02718e573473dfb7a5622fd751b98d06","unresolved":false,"context_lines":[{"line_number":578,"context_line":"DEFAULT_POOL_NAME \u003d \u0027_pool0\u0027"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"def only_hostname_required():"},{"line_number":582,"context_line":"    \"\"\"Returns True if the RPC backend requires only hostname."},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    ZeroMQ RPC driver requires only the hostname."},{"line_number":585,"context_line":"    So, return True if the RPC backend is ZeroMQ."},{"line_number":586,"context_line":"    \"\"\""},{"line_number":587,"context_line":"    if CONF.rpc_backend and CONF.rpc_backend \u003d\u003d \"zmq\":"},{"line_number":588,"context_line":"        return True"},{"line_number":589,"context_line":"    return False"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"def extract_host(host, level\u003d\u0027backend\u0027, default_pool_name\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_befe7f03","line":589,"range":{"start_line":581,"start_character":0,"end_line":589,"end_character":16},"updated":"2016-01-26 23:34:34.000000000","message":"Isn\u0027t cinder.rpc more appropriate for this?","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"8c069777a965195d217aaecdd964a87b31b10d72","unresolved":false,"context_lines":[{"line_number":578,"context_line":"DEFAULT_POOL_NAME \u003d \u0027_pool0\u0027"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"def only_hostname_required():"},{"line_number":582,"context_line":"    \"\"\"Returns True if the RPC backend requires only hostname."},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    ZeroMQ RPC driver requires only the hostname."},{"line_number":585,"context_line":"    So, return True if the RPC backend is ZeroMQ."},{"line_number":586,"context_line":"    \"\"\""},{"line_number":587,"context_line":"    if CONF.rpc_backend and CONF.rpc_backend \u003d\u003d \"zmq\":"},{"line_number":588,"context_line":"        return True"},{"line_number":589,"context_line":"    return False"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"def extract_host(host, level\u003d\u0027backend\u0027, default_pool_name\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_9e27c6b5","line":589,"range":{"start_line":581,"start_character":0,"end_line":589,"end_character":16},"in_reply_to":"9a68dd71_befe7f03","updated":"2016-01-29 02:29:13.000000000","message":"Since the host extraction logic was here, I placed the hostname requirement logic as well here.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"}],"releasenotes/notes/support-zeromq-messaging-driver-d26a1141290f5548.yaml":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"28a318dbe5a39871c55b9449cf08271dc8eafa2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for ZeroMQ messaging driver"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a68dd71_ed1686f0","line":4,"updated":"2016-01-27 06:01:28.000000000","message":"Please add conf file steps for easy and quick setup.","commit_id":"af1285805c541554333d8d257c9fcdb0a01c9490"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9ece26256ecfb8c86d3dccaee8018010f4aa1978","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for ZeroMQ messaging driver"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a5de9d1_7a53ba6b","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":45},"updated":"2016-01-30 16:28:35.000000000","message":"You should also mention the multi backend restriction here. We shouldn\u0027t expect operators to read all the commit messages to figure out when an option works.","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"75e2279801bd08357e96fd4de6cfc09fe94f2371","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added support for ZeroMQ messaging driver"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a5de9d1_0c281432","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":45},"in_reply_to":"7a5de9d1_7a53ba6b","updated":"2016-02-01 21:08:31.000000000","message":"Done","commit_id":"6aab8b5f507db4a54b3a2217aee2937306ebca4e"}]}