)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"2eb583738165dd87222d124897a40f6371ccf556","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zwei \u003cleidong@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-25 09:05:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if this volume_backend_name is None so error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1537726"},{"line_number":10,"context_line":"Change-Id: Ie059c9381928d39385665df3615e00d6a4ec6fc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_04cc6bb9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2016-01-25 17:27:58.000000000","message":"Suggestion: Error when volume_backend_name is None","commit_id":"a91e1d6dd55a7c28651e6537324ff601b477e92e"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"2eb583738165dd87222d124897a40f6371ccf556","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-25 09:05:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if this volume_backend_name is None so error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1537726"},{"line_number":10,"context_line":"Change-Id: Ie059c9381928d39385665df3615e00d6a4ec6fc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_04f54beb","line":8,"updated":"2016-01-25 17:27:58.000000000","message":"It would be helpful if there was some additional info here about the bug and what was done to fix it.","commit_id":"a91e1d6dd55a7c28651e6537324ff601b477e92e"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"f25784177f5372010dffa4cc2770b2d032cc2f7e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-01-25 09:02:55 +0800"},{"line_number":4,"context_line":"Commit:     zwei \u003cleidong@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-29 00:50:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if volume_backend_name is not set,"},{"line_number":8,"context_line":"it would still try to get all the list of volumes."},{"line_number":9,"context_line":"This would prevent it to go an additional step to list volumes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5de9d1_0674e865","line":6,"updated":"2016-01-29 04:41:38.000000000","message":"Nimble: Avoid unexpected exception if volume_backend_name is not set\n\nAnd then add detailed description as Jay mentioned why change is necessary.","commit_id":"765ff0b6a195ee2ce3202cecd170f7eb16a188cb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"f25784177f5372010dffa4cc2770b2d032cc2f7e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-01-25 09:02:55 +0800"},{"line_number":4,"context_line":"Commit:     zwei \u003cleidong@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-29 00:50:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if volume_backend_name is not set,"},{"line_number":8,"context_line":"it would still try to get all the list of volumes."},{"line_number":9,"context_line":"This would prevent it to go an additional step to list volumes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a5de9d1_665cbced","line":6,"updated":"2016-01-29 04:41:38.000000000","message":"The title of the commit message can be:","commit_id":"765ff0b6a195ee2ce3202cecd170f7eb16a188cb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"af33aff087f85bd0d47eaf50c253bd736e3cd296","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    If volume_backend_name is not set,"},{"line_number":10,"context_line":"    it would still try to get all the list of volumes."},{"line_number":11,"context_line":"    This would prevent it to go an additional step to list volumes"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1537726"},{"line_number":14,"context_line":"Change-Id: Ie059c9381928d39385665df3615e00d6a4ec6fc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a5ae5dd_3339e1a4","line":12,"updated":"2016-02-06 08:21:33.000000000","message":"Nimble: No need to query DB if vol_backend_name is not set\n\nThe Nimble driver queries DB for all volumes to find out those are hosted by this service, but it should skip the query if volume_backend_name is not set because that is how the driver matches volume.","commit_id":"4bc77215ed7787b441f5b12d4376c90bd3aa89aa"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1ff00d8f6ff39412fe1054163cc58c7e629aac9b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zwei \u003cleidong@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-07 11:53:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nimble: No need to query DB if vol_backend_name is not set"},{"line_number":8,"context_line":"    The Nimble driver queries DB for all volumes to find out those are hosted by this service,"},{"line_number":9,"context_line":"    but it should skip the query if volume_backend_name is not set"},{"line_number":10,"context_line":"    because that is how the driver matches volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7af24918_16a0e28f","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":58},"updated":"2016-03-07 06:24:40.000000000","message":"Need a blank line after the subject line","commit_id":"e87a4a3d0d8dd63b30cc5f8e6ad893a5bc7e24b6"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"d81ac0a0d58ecd1ba4934e4dba29a3ed29781650","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nimble: No need to query DB if vol_backend_name is not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    The Nimble driver queries DB for all volumes to find out those are hosted by this service,"},{"line_number":10,"context_line":"    but it should skip the query if volume_backend_name is not set"},{"line_number":11,"context_line":"    because that is how the driver matches volume."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5aef4532_8ea3599e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":94},"updated":"2016-03-07 13:06:54.000000000","message":"You don\u0027t need this tab in the beginning of line. And the commit msg should be wrapped at 72 characters.","commit_id":"4131641d536c5dbbabc5b99f6aa2043a3466dc8d"}],"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"f25784177f5372010dffa4cc2770b2d032cc2f7e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":158,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":159,"context_line":"        if backend_name:"},{"line_number":160,"context_line":"            all_vols \u003d volume.VolumeList.get_all("},{"line_number":161,"context_line":"                context, None, None, None, None, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":162,"context_line":"            for vol in all_vols:"},{"line_number":163,"context_line":"                if backend_name in vol.host:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_465980fd","line":160,"updated":"2016-01-29 04:41:38.000000000","message":"A bigger problem is why a driver lists all volumes from DB, including volumes from possibly other backends?","commit_id":"765ff0b6a195ee2ce3202cecd170f7eb16a188cb"},{"author":{"_account_id":16793,"name":"Liucheng Jiang","email":"jiangliucheng@huawei.com","username":"Jiangliucheng"},"change_message_id":"50deca14b92750a383551b3364632d1dfb6f5b0b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if backend_name:"},{"line_number":160,"context_line":"            all_vols \u003d volume.VolumeList.get_all("},{"line_number":161,"context_line":"                context, None, None, None, None, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":162,"context_line":"            for vol in all_vols:"},{"line_number":163,"context_line":"                if backend_name in vol.host:"},{"line_number":164,"context_line":"                    try:"},{"line_number":165,"context_line":"                        self.APIExecutor.edit_vol("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_82b8a7c9","line":162,"range":{"start_line":162,"start_character":23,"end_line":162,"end_character":31},"updated":"2016-01-29 15:54:15.000000000","message":"If no volume exists, will it be None?","commit_id":"765ff0b6a195ee2ce3202cecd170f7eb16a188cb"},{"author":{"_account_id":16793,"name":"Liucheng Jiang","email":"jiangliucheng@huawei.com","username":"Jiangliucheng"},"change_message_id":"1651c9cf93c26a0c9c742155cfde888b3c920d73","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if backend_name:"},{"line_number":160,"context_line":"            all_vols \u003d volume.VolumeList.get_all("},{"line_number":161,"context_line":"                context, None, None, None, None, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":162,"context_line":"            for vol in all_vols:"},{"line_number":163,"context_line":"                if backend_name in vol.host:"},{"line_number":164,"context_line":"                    try:"},{"line_number":165,"context_line":"                        self.APIExecutor.edit_vol("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_a48a9019","line":162,"range":{"start_line":162,"start_character":23,"end_line":162,"end_character":31},"in_reply_to":"7a5de9d1_82b8a7c9","updated":"2016-01-29 16:08:55.000000000","message":"How is that be None, when backend_name is None?","commit_id":"765ff0b6a195ee2ce3202cecd170f7eb16a188cb"}]}