)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7e76f289ca4c932224aa8511652b4a31b2be029c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC VMAX - Limit SG and MV to 64 characters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Verifying that the storage group and masking view is less than"},{"line_number":10,"context_line":"or equal to 64 characters which is a VMAX restriction for these"},{"line_number":11,"context_line":"types of objects.  This patch only adds extra unit tests to"},{"line_number":12,"context_line":"prove that both MV and SG names are below the 64 chars in all"},{"line_number":13,"context_line":"scenarios"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_7ebc2edc","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":15},"updated":"2016-02-11 19:31:05.000000000","message":"Suggestion: VMAX restricts storage group and masking view objects to a maximum length of 64 characters.","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c957413139b09326e0cd409c78297abb5a713603","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC VMAX - Limit SG and MV to 64 characters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Verifying that the storage group and masking view is less than"},{"line_number":10,"context_line":"or equal to 64 characters which is a VMAX restriction for these"},{"line_number":11,"context_line":"types of objects.  This patch only adds extra unit tests to"},{"line_number":12,"context_line":"prove that both MV and SG names are below the 64 chars in all"},{"line_number":13,"context_line":"scenarios"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_a57903ca","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":15},"in_reply_to":"3a57f1b5_7ebc2edc","updated":"2016-02-12 16:37:11.000000000","message":"Done","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7e76f289ca4c932224aa8511652b4a31b2be029c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"or equal to 64 characters which is a VMAX restriction for these"},{"line_number":11,"context_line":"types of objects.  This patch only adds extra unit tests to"},{"line_number":12,"context_line":"prove that both MV and SG names are below the 64 chars in all"},{"line_number":13,"context_line":"scenarios"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I72917a56083eb25f876b9cdeaa30511793922497"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_3eb23607","line":13,"updated":"2016-02-11 19:31:05.000000000","message":". at EOL","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c957413139b09326e0cd409c78297abb5a713603","unresolved":false,"context_lines":[{"line_number":10,"context_line":"or equal to 64 characters which is a VMAX restriction for these"},{"line_number":11,"context_line":"types of objects.  This patch only adds extra unit tests to"},{"line_number":12,"context_line":"prove that both MV and SG names are below the 64 chars in all"},{"line_number":13,"context_line":"scenarios"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I72917a56083eb25f876b9cdeaa30511793922497"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_254c339d","line":13,"in_reply_to":"3a57f1b5_3eb23607","updated":"2016-02-12 16:37:11.000000000","message":"Done","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"}],"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"2c02c643b9b93b019e22878cf84ee6bff30e1c19","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027maskingViewName\u0027]), 64)"},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"    def test_populate_masking_dict_no_fast_both_exceeding(self):"},{"line_number":1927,"context_line":"        # If the length of the FAST policy name is greater than 14 chars and"},{"line_number":1928,"context_line":"        # the length of the short host is more than 38 characters"},{"line_number":1929,"context_line":"        extraSpecs \u003d self.populate_masking_dict_setup()"},{"line_number":1930,"context_line":"        connector \u003d {\u0027host\u0027: \u0027SHORT_HOST_MORE_THEN THIRTY_EIGHT_CHARACTERS\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_7a73534e","line":1927,"updated":"2016-01-27 15:02:52.000000000","message":"\"the FAST policy name is greater than 14\" --\u003e \"the pool name is greater than 16\"","commit_id":"977db15911485b758ac6312ef81eb9901c21741d"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"910740e5bb8fc00f0dcbf5b3304a13ec2ac2cb8c","unresolved":false,"context_lines":[{"line_number":1924,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027maskingViewName\u0027]), 64)"},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"    def test_populate_masking_dict_no_fast_both_exceeding(self):"},{"line_number":1927,"context_line":"        # If the length of the FAST policy name is greater than 14 chars and"},{"line_number":1928,"context_line":"        # the length of the short host is more than 38 characters"},{"line_number":1929,"context_line":"        extraSpecs \u003d self.populate_masking_dict_setup()"},{"line_number":1930,"context_line":"        connector \u003d {\u0027host\u0027: \u0027SHORT_HOST_MORE_THEN THIRTY_EIGHT_CHARACTERS\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_ba6a2b19","line":1927,"in_reply_to":"7a5de9d1_7a73534e","updated":"2016-01-27 15:05:56.000000000","message":"Good catch.  I will change this","commit_id":"977db15911485b758ac6312ef81eb9901c21741d"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7e76f289ca4c932224aa8511652b4a31b2be029c","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"            \u0027GOLD_MORE_THAN_FOURTEEN_CHARACTERS\u0027)"},{"line_number":1921,"context_line":"        maskingViewDict \u003d self.driver.common._populate_masking_dict("},{"line_number":1922,"context_line":"            self.data.test_volume, connector, extraSpecs)"},{"line_number":1923,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027sgGroupName\u0027]), 64)"},{"line_number":1924,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027maskingViewName\u0027]), 64)"},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"    def test_populate_masking_dict_no_fast_both_exceeding(self):"},{"line_number":1927,"context_line":"        # If the length of the FAST policy name is greater than 14 chars and"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_3b39e8f2","line":1924,"range":{"start_line":1923,"start_character":8,"end_line":1924,"end_character":73},"updated":"2016-02-11 19:31:05.000000000","message":"The parameters order in assertEqual is (expected, actual). I\u0027m not sure it applies to assertLessEqual also, but IMO it\u0027s better to keep the pattern.","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7e76f289ca4c932224aa8511652b4a31b2be029c","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"        extraSpecs[\u0027storagetype:fastpolicy\u0027] \u003d None"},{"line_number":1934,"context_line":"        maskingViewDict \u003d self.driver.common._populate_masking_dict("},{"line_number":1935,"context_line":"            self.data.test_volume, connector, extraSpecs)"},{"line_number":1936,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027sgGroupName\u0027]), 64)"},{"line_number":1937,"context_line":"        self.assertLessEqual(len(maskingViewDict[\u0027maskingViewName\u0027]), 64)"},{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"    def test_filter_list(self):"},{"line_number":1940,"context_line":"        portgroupnames \u003d [\u0027pg3\u0027, \u0027pg1\u0027, \u0027pg4\u0027, \u0027pg2\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_7e766ea5","line":1937,"range":{"start_line":1936,"start_character":8,"end_line":1937,"end_character":73},"updated":"2016-02-11 19:31:05.000000000","message":"ditto","commit_id":"cdb304dd4e707eb3e9480b5c390ff41f57bdc807"}]}