)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"a9db0af77cc9cf51ff571b25383815423a9273f0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LisaLi \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-01 11:11:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return updated volume type after updation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating volume type in db, it queries the object and"},{"line_number":10,"context_line":"would like to return the updated object."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_7e9b9966","line":7,"updated":"2016-02-01 07:39:13.000000000","message":"s/updation/updating/","commit_id":"c97ca0566865b1e4aa09e2e83652774ae385f0e8"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":16793,"name":"Liucheng Jiang","email":"jiangliucheng@huawei.com","username":"Jiangliucheng"},"change_message_id":"d5a3e091d814b1b53fd16b754967f6ded4d92e66","unresolved":false,"context_lines":[{"line_number":2448,"context_line":"        volume_type_ref.update(values)"},{"line_number":2449,"context_line":"        volume_type_ref.save(session\u003dsession)"},{"line_number":2450,"context_line":""},{"line_number":2451,"context_line":"        return volume_type_ref"},{"line_number":2452,"context_line":""},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_8e98bfc1","line":2451,"range":{"start_line":2451,"start_character":8,"end_line":2451,"end_character":30},"updated":"2016-01-30 03:03:03.000000000","message":"The return type is changed. I think return *_ref object is not good. Can it works to just put volume_type_get() function out of \u0027with session.begin()\u0027 statement?","commit_id":"e397b6489de59cbd183faa986215b9f95bf2d7ec"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"c9579f0f2486a77505dabba31611c72a90e9d9eb","unresolved":false,"context_lines":[{"line_number":2448,"context_line":"        volume_type_ref.update(values)"},{"line_number":2449,"context_line":"        volume_type_ref.save(session\u003dsession)"},{"line_number":2450,"context_line":""},{"line_number":2451,"context_line":"        return volume_type_ref"},{"line_number":2452,"context_line":""},{"line_number":2453,"context_line":""},{"line_number":2454,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_a8dd5ae1","line":2451,"range":{"start_line":2451,"start_character":8,"end_line":2451,"end_character":30},"in_reply_to":"7a5de9d1_8e98bfc1","updated":"2016-02-01 02:30:08.000000000","message":"Hi, volume_type_get() is for getting specified fields. But in this case, we don\u0027t set expected_fields. It is better to return cinder.db.sqlalchemy.models.VolumeTypes instead of dic.","commit_id":"e397b6489de59cbd183faa986215b9f95bf2d7ec"}]}