)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16793,"name":"Liucheng Jiang","email":"jiangliucheng@huawei.com","username":"Jiangliucheng"},"change_message_id":"3275d58dbbf1cb3ad21319474825a053e57e4761","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the zfssa_target_portal property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia059a9555af7e658fae32fbe60ceca33f657bb0a"},{"line_number":14,"context_line":"Implements: oracle-zfssa-target-portal-dns-lookup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_8eb2ff92","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":49},"updated":"2016-01-30 04:02:07.000000000","message":"Implements: bp oracle-zfssa-target-portal-dns-lookup\nMake it to be a hyper link.","commit_id":"6b77d9d77d402920a65c8d8ff2901ef6921950cc"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f2bdbb5240498f0b0d7b85b15b58e50c6105b867","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            LOG.error(err_msg)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # Lookup the zfssa_target_portal DNS name to an IP address"},{"line_number":246,"context_line":"        host, port \u003d lcfg.zfssa_target_portal.split(\u0027:\u0027)"},{"line_number":247,"context_line":"        host_ip_addr \u003d utils.resolve_hostname(host)"},{"line_number":248,"context_line":"        self.zfssa_target_portal \u003d host_ip_addr + \u0027:\u0027 + port"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_83fa7541","line":245,"updated":"2016-02-29 18:00:47.000000000","message":"This seems like an odd thing to do.  Is it not possible to just use the DNS name directly?\n\nIf not, IMO this should be re-resolved each time it\u0027s used.  Otherwise your cinder configuration is misleading and DNS changes won\u0027t have the expected effect in Cinder.","commit_id":"845abb9680d17ff0d0d7eabd787b284b632134be"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"56b7526aa661479edc4acc1f03a8158d520b00e8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            LOG.error(err_msg)"},{"line_number":243,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # Lookup the zfssa_target_portal DNS name to an IP address"},{"line_number":246,"context_line":"        host, port \u003d lcfg.zfssa_target_portal.split(\u0027:\u0027)"},{"line_number":247,"context_line":"        host_ip_addr \u003d utils.resolve_hostname(host)"},{"line_number":248,"context_line":"        self.zfssa_target_portal \u003d host_ip_addr + \u0027:\u0027 + port"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_1971b276","line":245,"in_reply_to":"9aed3d3a_83fa7541","updated":"2016-02-29 18:32:17.000000000","message":"The iscsiadm utility which finally attaches the volume to the cinder host requires an IP address. The re-resolve part was also discussed internally and it was felt that resolving only at driver initialization was ok. One of the reasons for this was that doing a DNS lookup each time an attach volume call is made could take an indeterminate amount of time causing clients to wait.\nThe decision to put the lookup in driver initialization code does means that the driver would have to restart if the DNS name is mapped to a different IP and that IP needs to now be used as the target portal.","commit_id":"845abb9680d17ff0d0d7eabd787b284b632134be"}]}