)]}'
{"cinder/scheduler/filters/capabilities_filter.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9bd3dd05e1cad8413f7c00b07174e264b2d9676f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            for index in range(len(scope)):"},{"line_number":49,"context_line":"                try:"},{"line_number":50,"context_line":"                    cap \u003d cap.get(scope[index])"},{"line_number":51,"context_line":"                except AttributeError:"},{"line_number":52,"context_line":"                    cap \u003d None"},{"line_number":53,"context_line":"                if cap is None:"},{"line_number":54,"context_line":"                    LOG.debug(\"Host doesn\u0027t provide capability \u0027%(cap)s\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_70e3cfa4","line":51,"updated":"2016-02-06 07:27:17.000000000","message":"This AttributeError should ever be caught because .get() is safe from raising this exception.  So the change be is not necessary.","commit_id":"a6420a0e6843d774715e7beb03e2fad569d83f23"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9bd3dd05e1cad8413f7c00b07174e264b2d9676f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    cap \u003d None"},{"line_number":53,"context_line":"                if cap is None:"},{"line_number":54,"context_line":"                    LOG.debug(\"Host doesn\u0027t provide capability \u0027%(cap)s\u0027 \""},{"line_number":55,"context_line":"                              \"in the extra spec.\" %"},{"line_number":56,"context_line":"                              {\u0027cap\u0027: scope[index]})"},{"line_number":57,"context_line":"                    return False"},{"line_number":58,"context_line":"            if not extra_specs_ops.match(cap, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_90e0cb97","line":55,"updated":"2016-02-06 07:27:17.000000000","message":"The wording is a bit confusing, because host provide capabilities via volume_states update, \u0027in the extra spec\u0027 should be removed.","commit_id":"a6420a0e6843d774715e7beb03e2fad569d83f23"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"82575ef8388df77e6a9aa30258b27bdb59218220","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    cap \u003d cap.get(scope[index])"},{"line_number":51,"context_line":"                except AttributeError:"},{"line_number":52,"context_line":"                    return False"},{"line_number":53,"context_line":"                if cap is None:"},{"line_number":54,"context_line":"                    LOG.debug(\"Host doesn\u0027t provide capability \u0027%(cap)s\u0027 \" %"},{"line_number":55,"context_line":"                              {\u0027cap\u0027: scope[index]})"},{"line_number":56,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_d03fc9d4","line":53,"updated":"2016-02-09 22:37:37.000000000","message":"Probably want \"... capability \u0027%(cap)s\u0027.\"","commit_id":"d36762fcf98774560fe82b32b2d64d2eba1ec72b"}]}