)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d0465c35d765f5d4bb1b4c6ec39d922ab70d5b06","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is duplicated code located in different test classes."},{"line_number":10,"context_line":"This patch reorganizes the classes to reduce some redundant code."},{"line_number":11,"context_line":"Also this patch changes the vairable names \u0027iscsi_driver\u0027 and"},{"line_number":12,"context_line":"\u0027fc_driver\u0027 to \u0027driver\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I97e660202c25200e1e698e75b9ccb8871a751548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_d417904f","line":11,"range":{"start_line":11,"start_character":28,"end_line":11,"end_character":36},"updated":"2016-02-15 17:57:19.000000000","message":"vairable-\u003e variable","commit_id":"dcdb6e41abc96509ef45ca3151b23e0d56cdc557"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d0465c35d765f5d4bb1b4c6ec39d922ab70d5b06","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch reorganizes the classes to reduce some redundant code."},{"line_number":11,"context_line":"Also this patch changes the vairable names \u0027iscsi_driver\u0027 and"},{"line_number":12,"context_line":"\u0027fc_driver\u0027 to \u0027driver\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I97e660202c25200e1e698e75b9ccb8871a751548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_1f3bd1d2","line":13,"updated":"2016-02-15 17:57:19.000000000","message":"I think you could also add the bp that you were using before here just so that this change has another way to be tracked since it is technically still a part of the ongoing refactor for storwize.","commit_id":"dcdb6e41abc96509ef45ca3151b23e0d56cdc557"}],"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"90c57bf4a8015b99a9f2b918def4ea4ccfa8f37c","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"        return ret"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"class DriverHelperFunctions(object):"},{"line_number":1766,"context_line":"    def _set_up_drivers(self, fake_driver):"},{"line_number":1767,"context_line":"        self.USESIM \u003d True"},{"line_number":1768,"context_line":"        if self.USESIM:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_275a042b","line":1765,"updated":"2016-02-05 22:25:09.000000000","message":"Instead of passing in fake_driver just to set self.driver \u003d fake_driver, it seems like it may be nicer to either:\n   a) pass the uninstantiated class object in e.g. StorwizeSVCISCSIFakeDriver instead of StorwizeSVCISCSIFakeDriver(), then we patch out \u0027sleep\u0027, instantiate and set self.driver \u003d driver() here\n   b) don\u0027t pass the driver in at all and just set self.driver in the setUp class\n\nThink I like a) better personally but either way seems good\n\nAlso think this should be _set_up_driver (not plural)","commit_id":"dcdb6e41abc96509ef45ca3151b23e0d56cdc557"}]}