)]}'
{"cinder/tests/unit/objects/test_volume.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"fd227cbe49ae8ce006355357ef64e7afa12d4fe1","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        serializer \u003d objects.base.CinderObjectSerializer()"},{"line_number":359,"context_line":"        serialized_volume \u003d serializer.serialize_entity(self.context, volume)"},{"line_number":360,"context_line":"        volume \u003d serializer.deserialize_entity(self.context, serialized_volume)"},{"line_number":361,"context_line":"        self.assertEqual({}, volume.obj_get_changes())"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"class TestVolumeList(test_objects.BaseObjectsTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_150ee0e4","line":361,"range":{"start_line":361,"start_character":13,"end_line":361,"end_character":24},"updated":"2016-02-08 13:59:29.000000000","message":"Can use assertDictEqual instead.","commit_id":"dfe11374c44c010e1399bd584f9586632f217fbc"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"fd227cbe49ae8ce006355357ef64e7afa12d4fe1","unresolved":false,"context_lines":[{"line_number":4490,"context_line":"        with mock.patch.object(self.volume.driver,"},{"line_number":4491,"context_line":"                               \u0027migrate_volume\u0027) as mock_migrate_volume:"},{"line_number":4492,"context_line":"            mock_migrate_volume.side_effect \u003d \\"},{"line_number":4493,"context_line":"                lambda x, y, z, new_type_id\u003dNone: (True, {\u0027user_id\u0027: \u0027foo\u0027})"},{"line_number":4494,"context_line":"            self.volume.migrate_volume(self.context, volume.id, host_obj,"},{"line_number":4495,"context_line":"                                       False, volume\u003dvolume)"},{"line_number":4496,"context_line":"        self.assertEqual(\u0027newhost\u0027, volume.host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_3528bc32","line":4493,"range":{"start_line":4493,"start_character":32,"end_line":4493,"end_character":43},"updated":"2016-02-08 13:59:29.000000000","message":"Do not use \"\\\" for line continuation use \"()\" instead.","commit_id":"dfe11374c44c010e1399bd584f9586632f217fbc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"21c90ab7919de13959eda021117fcc2213849775","unresolved":false,"context_lines":[{"line_number":4532,"context_line":"        host_obj \u003d {\u0027host\u0027: \u0027newhost\u0027, \u0027capabilities\u0027: {}}"},{"line_number":4533,"context_line":"        with mock.patch.object(self.volume.driver,"},{"line_number":4534,"context_line":"                               \u0027migrate_volume\u0027) as mock_migrate_volume:"},{"line_number":4535,"context_line":"            mock_migrate_volume.side_effect \u003d ("},{"line_number":4536,"context_line":"                lambda x, y, z, new_type_id\u003dNone: (True, {\u0027user_id\u0027: \u0027foo\u0027}))"},{"line_number":4537,"context_line":"            self.volume.migrate_volume(self.context, volume.id, host_obj,"},{"line_number":4538,"context_line":"                                       False, volume\u003dvolume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_60421140","line":4535,"updated":"2016-03-08 16:58:30.000000000","message":"nit: Wouldn\u0027t it be cleaner if the mock was done with autospec\u003dTrue and then we just used return value instead of using a lambda expression?:\n\n mock_migrate_volume.return_value \u003d (True, {\u0027user_id\u0027: \u0027foo\u0027})","commit_id":"6ead3b86b201b1aed8930464a48df35f1492674a"}]}
