)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"faf7f64682b117ba584fb9ab69c1373e963de7b5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"in separate patch."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Iefd809a02d455d4248d11034c655dfc5f92bb235"},{"line_number":20,"context_line":"Closes-bug: 1542610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_d18e3c2d","line":20,"updated":"2016-02-07 05:01:59.000000000","message":"Done","commit_id":"665acd5318a1b8b11029aa1ac3a2bfc75de7f20b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ee633a7d8be63485374131dbccdc668472b799c0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"in separate patch."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Iefd809a02d455d4248d11034c655dfc5f92bb235"},{"line_number":20,"context_line":"Closes-bug: 1542610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_e0f044cb","line":20,"updated":"2016-02-06 21:02:47.000000000","message":"Since this doesn\u0027t get rid of the DB access, I think this should be marked as \"Partial-bug\" #1542610\" since the main point made by the bug is to get rid of the DB access.","commit_id":"665acd5318a1b8b11029aa1ac3a2bfc75de7f20b"}],"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b478ba409c8d23fab8fad09ebdf7c59927512737","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def _update_existing_vols_agent_type(self, context):"},{"line_number":156,"context_line":"        LOG.debug(\"Updating existing volumes to have \""},{"line_number":157,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":158,"context_line":"        all_vols \u003d volume.VolumeList.get_all_by_host("},{"line_number":159,"context_line":"            context, self.host)"},{"line_number":160,"context_line":"        for vol in all_vols:"},{"line_number":161,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_60a4d1a5","line":158,"updated":"2016-03-08 17:54:38.000000000","message":"-1: Now you are getting all volumes, whereas before we were only getting available volumes.\n\nYou could solve it adding `{\u0027status\u0027: \u0027available\u0027}` to the call or just adding \u0027host\u0027: self.host to the filtering dictionary we were passing `get_all` call before.\n\nOr an explanation in the commit message on why this filtering has been removed.","commit_id":"9082fa4cb8f75deda50732699ba69e5b10acf1fb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"f2ea2d236d0f047f5ec0a24201375e0fdafdaf46","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def _update_existing_vols_agent_type(self, context):"},{"line_number":156,"context_line":"        LOG.debug(\"Updating existing volumes to have \""},{"line_number":157,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":158,"context_line":"        all_vols \u003d volume.VolumeList.get_all_by_host("},{"line_number":159,"context_line":"            context, self.host)"},{"line_number":160,"context_line":"        for vol in all_vols:"},{"line_number":161,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_7bec78f3","line":158,"updated":"2016-04-24 01:43:43.000000000","message":"Nice catch.","commit_id":"9082fa4cb8f75deda50732699ba69e5b10acf1fb"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b3099df9a37f01c2d0fcda5b4e116c0d8f05802e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":161,"context_line":"        all_vols \u003d volume.VolumeList.get_all_by_host("},{"line_number":162,"context_line":"            context, self.host, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":163,"context_line":"        for vol in all_vols:"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                self.APIExecutor.edit_vol("},{"line_number":166,"context_line":"                    vol.name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_0f718b0c","line":163,"updated":"2016-05-05 08:29:45.000000000","message":"We should filter by host name and backend name too. This code will work wrong for multi-backend configuration","commit_id":"918a3f053cb5411ac04b9ab392f80b848d91f65c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ca44171d833143abfa53b8285a2bb37f119ff92","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":161,"context_line":"        all_vols \u003d volume.VolumeList.get_all_by_host("},{"line_number":162,"context_line":"            context, self.host, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":163,"context_line":"        for vol in all_vols:"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                self.APIExecutor.edit_vol("},{"line_number":166,"context_line":"                    vol.name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_c1a6470e","line":163,"in_reply_to":"1a122d0e_0f718b0c","updated":"2016-05-05 09:24:25.000000000","message":"No, it will work just fine, because volume_get_all_by_host method is already taking into account multibackend (uses SQL LIKE)","commit_id":"918a3f053cb5411ac04b9ab392f80b848d91f65c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"88636e96f26f6b8d52b067364c6d4cd85d492ed0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                  \"agent_type \u003d \u0027OPENSTACK\u0027\")"},{"line_number":161,"context_line":"        all_vols \u003d volume.VolumeList.get_all_by_host("},{"line_number":162,"context_line":"            context, self.host, {\u0027status\u0027: \u0027available\u0027})"},{"line_number":163,"context_line":"        for vol in all_vols:"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                self.APIExecutor.edit_vol("},{"line_number":166,"context_line":"                    vol.name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_6d8da230","line":163,"in_reply_to":"1a122d0e_c1a6470e","updated":"2016-05-05 11:16:05.000000000","message":"Forget what I said in previous comment, that\u0027s for the pools...\n\nAnyway, afaik self.host will contain the backend info as well, it\u0027s not CFG.host but host@backend.","commit_id":"918a3f053cb5411ac04b9ab392f80b848d91f65c"}]}