)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"305ee1c9318c0e3a5b5731151d24705f5e44dfbd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to a wrong verification while getting the version of the utility"},{"line_number":12,"context_line":"package."},{"line_number":13,"context_line":"This patch fixes the referenced behaviour."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I29fb5d7199e10eafee329dbd4ccef524245fbc28"},{"line_number":16,"context_line":"Closes-Bug: 1543208"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a5ae5dd_020a098a","line":14,"updated":"2016-02-08 22:04:10.000000000","message":"Given that you have Pep8 errors to fix yet and given that it isn\u0027t totally clear to me how this fix works, could you add some details as to how the fix works here please?  Thank you.","commit_id":"3bab0f27267d09585fde0d25e99f68f27375dad2"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"66821ca63eb82c23fb4d6245a83675e12161927a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to a wrong verification while getting the version of the utility"},{"line_number":12,"context_line":"package."},{"line_number":13,"context_line":"This patch fixes the referenced behaviour."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I29fb5d7199e10eafee329dbd4ccef524245fbc28"},{"line_number":16,"context_line":"Closes-Bug: 1543208"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a5ae5dd_bd769304","line":14,"in_reply_to":"5a5ae5dd_020a098a","updated":"2016-02-09 12:41:01.000000000","message":"Done","commit_id":"3bab0f27267d09585fde0d25e99f68f27375dad2"}],"cinder/volume/drivers/hitachi/hnas_backend.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"e1bfab322494f2d3ec0eba0d5995997f796daaba","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0 \""},{"line_number":148,"context_line":"                   \"Utility_version: %s\" % (hardware, model, ver, util))"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0 \""},{"line_number":151,"context_line":"                   % (hardware, model, ver))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_cfcf4727","line":150,"range":{"start_line":150,"start_character":72,"end_line":150,"end_character":73},"updated":"2016-02-08 17:16:25.000000000","message":"Extra space.","commit_id":"0df05aafe4d5885ef5f7d5d6e575c6123daf1cef"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"671c242a005351681daebafa3350c41b196addec","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            if \u0027Software:\u0027 in line:"},{"line_number":139,"context_line":"                ver \u003d line.split()[1]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        #If not using SSH, the local utility version can be different from the"},{"line_number":142,"context_line":"        #one used in HNAS"},{"line_number":143,"context_line":"        if self.drv_configs[\u0027ssh_enabled\u0027] !\u003d \u0027True\u0027:"},{"line_number":144,"context_line":"            out, err \u003d utils.execute(cmd, \"-version\", check_exit_code\u003dTrue)"},{"line_number":145,"context_line":"            util \u003d out.split()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_a9a1a395","line":142,"range":{"start_line":141,"start_character":8,"end_line":142,"end_character":25},"updated":"2016-02-08 19:13:45.000000000","message":"pep8 errors","commit_id":"3bab0f27267d09585fde0d25e99f68f27375dad2"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"66821ca63eb82c23fb4d6245a83675e12161927a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            if \u0027Software:\u0027 in line:"},{"line_number":139,"context_line":"                ver \u003d line.split()[1]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        #If not using SSH, the local utility version can be different from the"},{"line_number":142,"context_line":"        #one used in HNAS"},{"line_number":143,"context_line":"        if self.drv_configs[\u0027ssh_enabled\u0027] !\u003d \u0027True\u0027:"},{"line_number":144,"context_line":"            out, err \u003d utils.execute(cmd, \"-version\", check_exit_code\u003dTrue)"},{"line_number":145,"context_line":"            util \u003d out.split()[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_3d0b837f","line":142,"range":{"start_line":141,"start_character":8,"end_line":142,"end_character":25},"in_reply_to":"5a5ae5dd_a9a1a395","updated":"2016-02-09 12:41:01.000000000","message":"Done","commit_id":"3bab0f27267d09585fde0d25e99f68f27375dad2"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c2b91f98ff1b603b646511157df0dc5da05c4a9d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            util \u003d out.split()[1]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":152,"context_line":"                   \"Utility_version: %s\" % (hardware, model, ver, util))"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":155,"context_line":"                   % (hardware, model, ver))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_d322d7a2","line":152,"range":{"start_line":152,"start_character":44,"end_line":152,"end_character":52},"updated":"2016-02-12 12:12:16.000000000","message":"I think you can map the string formatting here, it can be better to read the code, debug, adding more information and to translation. Also, add a space in the end of first line: \n\nout \u003d (\"Array_ID: %(hw)s (%(model)s) version: %(ver)s LU: 256 RG: 0 RG_LU: 0 \"\n\"Utility_version: %(util)s\" % {\u0027hw\u0027: hardware, \u0027model\u0027: model, \u0027ver\u0027: ver,\u0027util\u0027: util})","commit_id":"c29eb26e23f56ec883b59af2f03fc0dfc72ff8e5"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a904cf58ef4bf57305e6588a920353d71935661f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            util \u003d out.split()[1]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":152,"context_line":"                   \"Utility_version: %s\" % (hardware, model, ver, util))"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":155,"context_line":"                   % (hardware, model, ver))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_2975fef8","line":152,"range":{"start_line":152,"start_character":44,"end_line":152,"end_character":52},"in_reply_to":"3a57f1b5_d322d7a2","updated":"2016-02-12 13:29:11.000000000","message":"Done","commit_id":"c29eb26e23f56ec883b59af2f03fc0dfc72ff8e5"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c2b91f98ff1b603b646511157df0dc5da05c4a9d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                   \"Utility_version: %s\" % (hardware, model, ver, util))"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":155,"context_line":"                   % (hardware, model, ver))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        LOG.debug(\u0027get_version: %(out)s -- %(err)s\u0027, {\u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":158,"context_line":"        return out"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_1354effc","line":155,"range":{"start_line":155,"start_character":32,"end_line":155,"end_character":37},"updated":"2016-02-12 12:12:16.000000000","message":"Same as above.","commit_id":"c29eb26e23f56ec883b59af2f03fc0dfc72ff8e5"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a904cf58ef4bf57305e6588a920353d71935661f","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                   \"Utility_version: %s\" % (hardware, model, ver, util))"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            out \u003d (\"Array_ID: %s (%s) version: %s LU: 256 RG: 0 RG_LU: 0\""},{"line_number":155,"context_line":"                   % (hardware, model, ver))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        LOG.debug(\u0027get_version: %(out)s -- %(err)s\u0027, {\u0027out\u0027: out, \u0027err\u0027: err})"},{"line_number":158,"context_line":"        return out"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_0967e24d","line":155,"range":{"start_line":155,"start_character":32,"end_line":155,"end_character":37},"in_reply_to":"3a57f1b5_1354effc","updated":"2016-02-12 13:29:11.000000000","message":"Done","commit_id":"c29eb26e23f56ec883b59af2f03fc0dfc72ff8e5"}]}
