)]}'
{"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ab9516a78d049ed58f77de014939956d89d5f043","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def tearDown(self):"},{"line_number":59,"context_line":"        super(NetAppCmodeClientTestCase, self).tearDown()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_has_records(self):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        result \u003d self.client._has_records(netapp_api.NaElement("},{"line_number":64,"context_line":"            fake_client.QOS_POLICY_GROUP_GET_ITER_RESPONSE))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_2786e913","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":24},"updated":"2016-02-10 21:38:52.000000000","message":"I know unit tests give us all a warm fuzzy feeling inside, but what in the Cinder code path is this actually testing?  Appears this is just a test that the client (which is mocked) handles a mocked response properly.\n\nSo if I follow we\u0027re testing your ability to mock handle a mock response?\n\nNot trying to be snarky, just wondering about our \"test for the sake of testing\" strategy.","commit_id":"af1a69fc45a7ccad63fcd5bcac0fa21b3d45fdaa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b6b1924599ab9095e34dbb7f90f63f86a93f0249","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def tearDown(self):"},{"line_number":59,"context_line":"        super(NetAppCmodeClientTestCase, self).tearDown()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_has_records(self):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        result \u003d self.client._has_records(netapp_api.NaElement("},{"line_number":64,"context_line":"            fake_client.QOS_POLICY_GROUP_GET_ITER_RESPONSE))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_38de0612","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":24},"in_reply_to":"3a57f1b5_2786e913","updated":"2016-02-10 22:25:12.000000000","message":"Hi, John.  Not tests for the sake of testing, but I have a habit of trying to cover every code line with a unit test.  This test tests a private method in client_cmode.py that examines a list of records from a cDOT getter API and checks that one or more records were returned.  Like most API client tests, this test is driven with XML data in the fakes file which is captured from actual API calls to a real controller, so it\u0027s as good a test as I can devise.","commit_id":"af1a69fc45a7ccad63fcd5bcac0fa21b3d45fdaa"}]}