)]}'
{"cinder/volume/drivers/netapp/eseries/client.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"a04e80c515ff4d815338ab8ed16fab5e631c8494","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        return api_operating_mode, about_response_dict[\u0027version\u0027]"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def list_backend_store(self, key):"},{"line_number":846,"context_line":"        \"\"\"Retrieve data by key from the the persistent store on the backend."},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        Example response: {\"key\": \"cinder-snapshots\", \"value\": \"[]\"}"},{"line_number":849,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1e401356","line":846,"range":{"start_line":846,"start_character":41,"end_line":846,"end_character":44},"updated":"2016-02-15 08:41:43.000000000","message":"Please remove the redundant \"the\" here.","commit_id":"eb4f9734defeaf60aefa39316c151b63222ca193"}],"cinder/volume/drivers/netapp/eseries/library.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"a04e80c515ff4d815338ab8ed16fab5e631c8494","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        identify the snapshot, so any snapshots previously defined in this"},{"line_number":399,"context_line":"        way must be updated."},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        :param snapshot_id: Cinder snapshot identifer"},{"line_number":402,"context_line":"        :return: An E-Series snapshot image"},{"line_number":403,"context_line":"        \"\"\""},{"line_number":404,"context_line":"        label \u003d utils.convert_uuid_to_es_fmt(snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a4b6363b","line":401,"range":{"start_line":401,"start_character":28,"end_line":401,"end_character":34},"updated":"2016-02-15 08:41:43.000000000","message":"The param should be snapshot not id.","commit_id":"eb4f9734defeaf60aefa39316c151b63222ca193"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"a04e80c515ff4d815338ab8ed16fab5e631c8494","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        identify it. We retrieve the snapshot volume with the matching name,"},{"line_number":427,"context_line":"        and then we find its underlying snapshot."},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        :param snapshot_id: Cinder snapshot identifer"},{"line_number":430,"context_line":"        :return: An E-Series snapshot image"},{"line_number":431,"context_line":"        \"\"\""},{"line_number":432,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_84ddf272","line":429,"range":{"start_line":429,"start_character":15,"end_line":429,"end_character":26},"updated":"2016-02-15 08:41:43.000000000","message":"ditto. Also the line 422, it\u0027s not by Cinder id but snapshot.","commit_id":"eb4f9734defeaf60aefa39316c151b63222ca193"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"a04e80c515ff4d815338ab8ed16fab5e631c8494","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                LOG.debug(\u0027Unable to locate snapshot by its id, falling \u0027"},{"line_number":439,"context_line":"                          \u0027back to legacy behavior.\u0027)"},{"line_number":440,"context_line":"                return self._get_snapshot_legacy(snapshot)"},{"line_number":441,"context_line":"            except exception.NetAppDriverException:"},{"line_number":442,"context_line":"                raise exception.NotFound(_(\u0027Snapshot with id of %s could not\u0027"},{"line_number":443,"context_line":"                                           \u0027 be found.\u0027) % snapshot[\u0027id\u0027])"},{"line_number":444,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a4ee36ea","line":441,"range":{"start_line":441,"start_character":29,"end_line":441,"end_character":50},"updated":"2016-02-15 08:41:43.000000000","message":"Line 440 may raise exception as \"exception.NotFound\" in Line 418, will we catch that or just leave it there?","commit_id":"eb4f9734defeaf60aefa39316c151b63222ca193"}],"cinder/volume/drivers/netapp/utils.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c5cd21bcef72881c49dd9e54faf65bcc095fe7d9","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        return self.supported"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class BitSet(object):"},{"line_number":512,"context_line":"    def __init__(self, value\u003d0):"},{"line_number":513,"context_line":"        self._value \u003d value"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_195b66f7","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":21},"updated":"2016-02-23 19:05:05.000000000","message":"is there much value in adding these one-line helpers as opposed to just performing the operation in code where needed?\n\nSure, it works fine, but it creates a bit of hopping around when following the code.","commit_id":"2ecfb1ba2235838e01348bf51471025572561123"},{"author":{"_account_id":16821,"name":"Michael Price","email":"michael.price@netapp.com","username":"michael.price"},"change_message_id":"d124baeded4d6a4bdf393e8c1d5fea9aa3bf15d3","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        return self.supported"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class BitSet(object):"},{"line_number":512,"context_line":"    def __init__(self, value\u003d0):"},{"line_number":513,"context_line":"        self._value \u003d value"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_28aa5319","line":511,"range":{"start_line":511,"start_character":0,"end_line":511,"end_character":21},"in_reply_to":"bae84128_195b66f7","updated":"2016-02-23 20:38:43.000000000","message":"I definitely see your point on that; most of these operations are pretty simple. However, I thought it would enhance the readability and testability of the code to extract the behavior to a helper class.","commit_id":"2ecfb1ba2235838e01348bf51471025572561123"}]}