)]}'
{"cinder/volume/iscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"500de825a3fe70be9757cd4e2fdb7fdbbc58579d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # directly to iet calls, so pop it if it\u0027s there"},{"line_number":243,"context_line":"        if kwargs.get(\u0027old_name\u0027, None) is not None:"},{"line_number":244,"context_line":"            kwargs.pop(\u0027old_name\u0027, None)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        self._new_target(name, tid, **kwargs)"},{"line_number":247,"context_line":"        self._new_logicalunit(tid, lun, path, **kwargs)"},{"line_number":248,"context_line":"        if chap_auth is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fnl8%3D","line":245,"updated":"2013-05-01 17:32:19.000000000","message":"I realize that adding the \"None\" alternative to kwargs.pop here is redundant, I\u0027ll remove if folks object but it\u0027s a safety habit.","commit_id":"e0ce3fe323870d947cdaddfe1b0e19cb0c4e516c"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1f1c2a501eab3870b3e9848b189351bd98b9d778","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # directly to iet calls, so pop it if it\u0027s there"},{"line_number":243,"context_line":"        if kwargs.get(\u0027old_name\u0027, None) is not None:"},{"line_number":244,"context_line":"            kwargs.pop(\u0027old_name\u0027, None)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        self._new_target(name, tid, **kwargs)"},{"line_number":247,"context_line":"        self._new_logicalunit(tid, lun, path, **kwargs)"},{"line_number":248,"context_line":"        if chap_auth is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FlvI%3D","line":245,"in_reply_to":"AAAAOn%2F%2FmeM%3D","updated":"2013-05-02 17:54:03.000000000","message":"Done  Thanks Rushi, you\u0027re absolutely right... forest for the trees :)","commit_id":"e0ce3fe323870d947cdaddfe1b0e19cb0c4e516c"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8a7eca4e62e37b0071d4b89070f05719f72ee688","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        # directly to iet calls, so pop it if it\u0027s there"},{"line_number":243,"context_line":"        if kwargs.get(\u0027old_name\u0027, None) is not None:"},{"line_number":244,"context_line":"            kwargs.pop(\u0027old_name\u0027, None)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        self._new_target(name, tid, **kwargs)"},{"line_number":247,"context_line":"        self._new_logicalunit(tid, lun, path, **kwargs)"},{"line_number":248,"context_line":"        if chap_auth is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FmeM%3D","line":245,"in_reply_to":"AAAAOn%2F%2Fnl8%3D","updated":"2013-05-02 08:51:14.000000000","message":"I think the above two lines can easily be replaced with \n kwargs.pop(\u0027old_name\u0027,None)","commit_id":"e0ce3fe323870d947cdaddfe1b0e19cb0c4e516c"}]}