)]}'
{"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"50af6b20f060d2a23c3d69626033b40fca434e6c","unresolved":false,"context_lines":[{"line_number":2332,"context_line":"                    \"Snapshot %(snapshotname)s not found on the array. \""},{"line_number":2333,"context_line":"                    \"No volume to delete.\"),"},{"line_number":2334,"context_line":"                    {\u0027snapshotname\u0027: snapshotname})"},{"line_number":2335,"context_line":"                return errorRet"},{"line_number":2336,"context_line":"            storageSystem \u003d snapshotInstance[\u0027SystemName\u0027]"},{"line_number":2337,"context_line":""},{"line_number":2338,"context_line":"            # Wait for it to fully sync in case there is an ongoing"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_8377acd3","line":2335,"range":{"start_line":2335,"start_character":23,"end_line":2335,"end_character":31},"updated":"2016-02-15 06:59:15.000000000","message":"As errorRet is only used in line 2335, may we remove line 2320~2321 and just return(-1, snapshotname)?","commit_id":"fd3f5e1a78ebcf100e6285a42c37fc4a4ddbd64f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4bb9446a8103d4f06ad67a662a0b69bedefcf58b","unresolved":false,"context_lines":[{"line_number":2332,"context_line":"                    \"Snapshot %(snapshotname)s not found on the array. \""},{"line_number":2333,"context_line":"                    \"No volume to delete.\"),"},{"line_number":2334,"context_line":"                    {\u0027snapshotname\u0027: snapshotname})"},{"line_number":2335,"context_line":"                return errorRet"},{"line_number":2336,"context_line":"            storageSystem \u003d snapshotInstance[\u0027SystemName\u0027]"},{"line_number":2337,"context_line":""},{"line_number":2338,"context_line":"            # Wait for it to fully sync in case there is an ongoing"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_ac69c6c0","line":2335,"range":{"start_line":2335,"start_character":23,"end_line":2335,"end_character":31},"in_reply_to":"dae33548_8377acd3","updated":"2016-02-16 09:30:29.000000000","message":"Sure. I will change it","commit_id":"fd3f5e1a78ebcf100e6285a42c37fc4a4ddbd64f"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"50af6b20f060d2a23c3d69626033b40fca434e6c","unresolved":false,"context_lines":[{"line_number":3792,"context_line":"                {\u0027cloneName\u0027: cloneName})"},{"line_number":3793,"context_line":"            # Check if the copy session exists."},{"line_number":3794,"context_line":"            if targetInstance:"},{"line_number":3795,"context_line":"                if targetInstance:"},{"line_number":3796,"context_line":"                    self._cleanup_target("},{"line_number":3797,"context_line":"                        repServiceInstanceName, targetInstance, extraSpecs)"},{"line_number":3798,"context_line":"                # Re-throw the exception."}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_5eda9b79","line":3795,"range":{"start_line":3795,"start_character":19,"end_line":3795,"end_character":33},"updated":"2016-02-15 06:59:15.000000000","message":"line 3794 and 3795 are the same?","commit_id":"fd3f5e1a78ebcf100e6285a42c37fc4a4ddbd64f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35334cb2603aea54d21864bc7edd3ce87323ab31","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"            self.conn, job[\u0027Job\u0027])"},{"line_number":3826,"context_line":"        targetVolumeInstance \u003d ("},{"line_number":3827,"context_line":"            self.provisionv3.get_volume_from_job(self.conn, job[\u0027Job\u0027]))"},{"line_number":3828,"context_line":"        LOG.info(_LI(\"The target instance device id is: %(deviceid)s. \"),"},{"line_number":3829,"context_line":"                 {\u0027deviceid\u0027: targetVolumeInstance[\u0027DeviceID\u0027]})"},{"line_number":3830,"context_line":""},{"line_number":3831,"context_line":"        cloneVolume[\u0027provider_location\u0027] \u003d six.text_type(cloneDict)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_0655a5c4","line":3828,"updated":"2016-03-10 15:08:36.000000000","message":"Extra space on the end can be removed. Not critical, but would be good to clean up if another patch ends up being necessary.","commit_id":"c26d7fd2ff5b099d3272e0f5c6cb924c3e49aded"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ab74459728c886bc32e89a8ad590cf85fd8a3784","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"            self.conn, job[\u0027Job\u0027])"},{"line_number":3826,"context_line":"        targetVolumeInstance \u003d ("},{"line_number":3827,"context_line":"            self.provisionv3.get_volume_from_job(self.conn, job[\u0027Job\u0027]))"},{"line_number":3828,"context_line":"        LOG.info(_LI(\"The target instance device id is: %(deviceid)s. \"),"},{"line_number":3829,"context_line":"                 {\u0027deviceid\u0027: targetVolumeInstance[\u0027DeviceID\u0027]})"},{"line_number":3830,"context_line":""},{"line_number":3831,"context_line":"        cloneVolume[\u0027provider_location\u0027] \u003d six.text_type(cloneDict)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_4f34dd48","line":3828,"in_reply_to":"5aef4532_0655a5c4","updated":"2016-03-10 16:02:30.000000000","message":"Sure, I will change those things now","commit_id":"c26d7fd2ff5b099d3272e0f5c6cb924c3e49aded"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35334cb2603aea54d21864bc7edd3ce87323ab31","unresolved":false,"context_lines":[{"line_number":4436,"context_line":""},{"line_number":4437,"context_line":"    def _create_duplicate_volume("},{"line_number":4438,"context_line":"            self, sourceInstance, cloneName, extraSpecs):"},{"line_number":4439,"context_line":"        \"\"\"Create a volume in the same dimensions of the source volume"},{"line_number":4440,"context_line":""},{"line_number":4441,"context_line":"        :param sourceInstance: the source volume instance"},{"line_number":4442,"context_line":"        :param cloneName: the user supplied snap name"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_0603e5b8","line":4439,"updated":"2016-03-10 15:08:36.000000000","message":"Trivial nit: should end with a period.","commit_id":"c26d7fd2ff5b099d3272e0f5c6cb924c3e49aded"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"785b562cd3016d5de0a81f63b8dc5154f1dcd535","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            \"\"\""},{"line_number":406,"context_line":"            retries \u003d kwargs[\u0027retries\u0027]"},{"line_number":407,"context_line":"            maxJobRetries \u003d self._get_max_job_retries(extraSpecs)"},{"line_number":408,"context_line":"            if retries \u003e maxJobRetries:"},{"line_number":409,"context_line":"                LOG.error(_LE(\"_wait_for_sync failed after %(retries)d \""},{"line_number":410,"context_line":"                              \"tries.\"),"},{"line_number":411,"context_line":"                          {\u0027retries\u0027: retries})"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_8bded5da","line":408,"updated":"2016-02-18 13:41:30.000000000","message":"Why is the retries counter checked here? Let\u0027s say the synchronization is now complete. But since _is_sync_complete() is not checked prior to checking the retries count, an ERROR is logged. Might as well do this check at the end of the method rather than having to wait an extra \"Interval\" seconds to find out that we timed out.\n\nSame for job completion checking.","commit_id":"b82bc2f06526b6dacf67cf7e5cc7e98fd3eec004"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5b4c5e4ad214fbb32c036f264ee24c007fc588d7","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            \"\"\""},{"line_number":406,"context_line":"            retries \u003d kwargs[\u0027retries\u0027]"},{"line_number":407,"context_line":"            maxJobRetries \u003d self._get_max_job_retries(extraSpecs)"},{"line_number":408,"context_line":"            if retries \u003e maxJobRetries:"},{"line_number":409,"context_line":"                LOG.error(_LE(\"_wait_for_sync failed after %(retries)d \""},{"line_number":410,"context_line":"                              \"tries.\"),"},{"line_number":411,"context_line":"                          {\u0027retries\u0027: retries})"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_4ee7bbab","line":408,"in_reply_to":"dae33548_8bded5da","updated":"2016-02-18 13:56:33.000000000","message":"Thanks Carl, we will change it in both","commit_id":"b82bc2f06526b6dacf67cf7e5cc7e98fd3eec004"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"35334cb2603aea54d21864bc7edd3ce87323ab31","unresolved":false,"context_lines":[{"line_number":2500,"context_line":"                                                       extraSpecs)"},{"line_number":2501,"context_line":"            if rc !\u003d 0:"},{"line_number":2502,"context_line":"                exceptionMessage \u003d (_("},{"line_number":2503,"context_line":"                    \"Error getting ReplicationSettingData\""},{"line_number":2504,"context_line":"                    \"Return code: %(rc)lu. \""},{"line_number":2505,"context_line":"                    \"Error: %(error)s.\")"},{"line_number":2506,"context_line":"                    % {\u0027rc\u0027: rc,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_26954132","line":2503,"updated":"2016-03-10 15:08:36.000000000","message":"Needs a space at the end so the two lines don\u0027t run together.","commit_id":"c26d7fd2ff5b099d3272e0f5c6cb924c3e49aded"}]}
