)]}'
{"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7ab12f78a2642d89c0b9be1a6e1c73d1715cd79e","unresolved":false,"context_lines":[{"line_number":7318,"context_line":"                controllerConfigService, maskingviewdict[\u0027volumeName\u0027]))"},{"line_number":7319,"context_line":"        self.assertIsNone(result)"},{"line_number":7320,"context_line":""},{"line_number":7321,"context_line":"    def test_return_volume_to_default_storage_group_v3(self):"},{"line_number":7322,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7323,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7324,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_aa07e57f","line":7321,"range":{"start_line":7321,"start_character":8,"end_line":7321,"end_character":54},"updated":"2016-02-16 10:36:53.000000000","message":"I didn\u0027t get how this test work without any assert. Am I missing something?","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"18d8929730c20032930a2b88347cad2667b4af7e","unresolved":false,"context_lines":[{"line_number":7318,"context_line":"                controllerConfigService, maskingviewdict[\u0027volumeName\u0027]))"},{"line_number":7319,"context_line":"        self.assertIsNone(result)"},{"line_number":7320,"context_line":""},{"line_number":7321,"context_line":"    def test_return_volume_to_default_storage_group_v3(self):"},{"line_number":7322,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7323,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7324,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_dbf67df8","line":7321,"range":{"start_line":7321,"start_character":8,"end_line":7321,"end_character":54},"in_reply_to":"dae33548_2d22cf01","updated":"2016-02-16 11:15:07.000000000","message":"Thanks to you both.  I will use this","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"dcfd752f2ba7e2544d7b396d0e0aed90d9f69480","unresolved":false,"context_lines":[{"line_number":7318,"context_line":"                controllerConfigService, maskingviewdict[\u0027volumeName\u0027]))"},{"line_number":7319,"context_line":"        self.assertIsNone(result)"},{"line_number":7320,"context_line":""},{"line_number":7321,"context_line":"    def test_return_volume_to_default_storage_group_v3(self):"},{"line_number":7322,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7323,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7324,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_8d1b1b1b","line":7321,"range":{"start_line":7321,"start_character":8,"end_line":7321,"end_character":54},"in_reply_to":"dae33548_4a78d9c4","updated":"2016-02-16 10:49:58.000000000","message":"Helen, you can use something like assert_called_with","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"3c6da03fccd96be674dc38f394393c1597b8bd06","unresolved":false,"context_lines":[{"line_number":7318,"context_line":"                controllerConfigService, maskingviewdict[\u0027volumeName\u0027]))"},{"line_number":7319,"context_line":"        self.assertIsNone(result)"},{"line_number":7320,"context_line":""},{"line_number":7321,"context_line":"    def test_return_volume_to_default_storage_group_v3(self):"},{"line_number":7322,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7323,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7324,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_2d22cf01","line":7321,"range":{"start_line":7321,"start_character":8,"end_line":7321,"end_character":54},"in_reply_to":"dae33548_8d1b1b1b","updated":"2016-02-16 10:53:25.000000000","message":"I guess it\u0027s not necessary to return a boolean if it won\u0027t be used. I thought in some assert_called_with() as well.","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"66728ac08b13863d373a5c21f052a09ba94947dd","unresolved":false,"context_lines":[{"line_number":7318,"context_line":"                controllerConfigService, maskingviewdict[\u0027volumeName\u0027]))"},{"line_number":7319,"context_line":"        self.assertIsNone(result)"},{"line_number":7320,"context_line":""},{"line_number":7321,"context_line":"    def test_return_volume_to_default_storage_group_v3(self):"},{"line_number":7322,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7323,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7324,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_4a78d9c4","line":7321,"range":{"start_line":7321,"start_character":8,"end_line":7321,"end_character":54},"in_reply_to":"dae33548_aa07e57f","updated":"2016-02-16 10:41:52.000000000","message":"return_volume_to_default_storage_group_v3 does not return any value so I have nothing to assert on, any suggestions?  I could return a Boolean I guess","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7ab12f78a2642d89c0b9be1a6e1c73d1715cd79e","unresolved":false,"context_lines":[{"line_number":7385,"context_line":"            volumeInstance, volumeName, sgGroupName, extraSpecs)"},{"line_number":7386,"context_line":"        self.assertIsNone(msg)"},{"line_number":7387,"context_line":""},{"line_number":7388,"context_line":"    def test_remove_volume_from_sg(self):"},{"line_number":7389,"context_line":"        masking \u003d self.driver.common.masking"},{"line_number":7390,"context_line":"        conn \u003d self.fake_ecom_connection()"},{"line_number":7391,"context_line":"        volumeInstanceName \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_4af9f97f","line":7388,"range":{"start_line":7388,"start_character":8,"end_line":7388,"end_character":34},"updated":"2016-02-16 10:36:53.000000000","message":"ditto","commit_id":"f9bb2b3d838ab8211258568d69bccd28c78fb532"}],"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"eee1278e332fd4c8c55c37814b05028f50df169a","unresolved":false,"context_lines":[{"line_number":3391,"context_line":"        :param volumeInstance: the volume instance"},{"line_number":3392,"context_line":"        :param volumeName: the volume Name"},{"line_number":3393,"context_line":"        :param deviceId: the device ID of the volume"},{"line_number":3394,"context_line":"        :param storageGroupName: the name of the default SG"},{"line_number":3395,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":3396,"context_line":"        :returns: int -- return code"},{"line_number":3397,"context_line":"        :raises: VolumeBackendAPIException"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_fb5bcf2c","side":"PARENT","line":3394,"range":{"start_line":3394,"start_character":56,"end_line":3394,"end_character":57},"updated":"2016-02-15 02:07:21.000000000","message":"Please also remove the comment for the parameter. :-)","commit_id":"04b2cdf9b5676fb49bdc2dcbd1115b9e34287f8c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"7ddf8a4c677d8d4db1a2866e733880ca22aa73c7","unresolved":false,"context_lines":[{"line_number":3391,"context_line":"        :param volumeInstance: the volume instance"},{"line_number":3392,"context_line":"        :param volumeName: the volume Name"},{"line_number":3393,"context_line":"        :param deviceId: the device ID of the volume"},{"line_number":3394,"context_line":"        :param storageGroupName: the name of the default SG"},{"line_number":3395,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":3396,"context_line":"        :returns: int -- return code"},{"line_number":3397,"context_line":"        :raises: VolumeBackendAPIException"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_24f866e5","side":"PARENT","line":3394,"range":{"start_line":3394,"start_character":56,"end_line":3394,"end_character":57},"in_reply_to":"dae33548_fb5bcf2c","updated":"2016-02-15 08:13:03.000000000","message":"I will.  Thanks","commit_id":"04b2cdf9b5676fb49bdc2dcbd1115b9e34287f8c"}],"cinder/volume/drivers/emc/emc_vmax_masking.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"eee1278e332fd4c8c55c37814b05028f50df169a","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        :param volumeInstance: the volume instance"},{"line_number":537,"context_line":"        :param volumeName: the volume name"},{"line_number":538,"context_line":"        :param sgGroupName: the storage group name"},{"line_number":539,"context_line":"        :param extraSpecs: the extra specifications"},{"line_number":540,"context_line":"        :returns: string -- the error message"},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":"        msg \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_7bc17f2e","line":539,"range":{"start_line":539,"start_character":9,"end_line":539,"end_character":14},"updated":"2016-02-15 02:07:21.000000000","message":"Parameter storageGroupInstanceName is lost in the comments.","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"7ddf8a4c677d8d4db1a2866e733880ca22aa73c7","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        :param volumeInstance: the volume instance"},{"line_number":537,"context_line":"        :param volumeName: the volume name"},{"line_number":538,"context_line":"        :param sgGroupName: the storage group name"},{"line_number":539,"context_line":"        :param extraSpecs: the extra specifications"},{"line_number":540,"context_line":"        :returns: string -- the error message"},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":"        msg \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e43b1e9b","line":539,"range":{"start_line":539,"start_character":9,"end_line":539,"end_character":14},"in_reply_to":"dae33548_7bc17f2e","updated":"2016-02-15 08:13:03.000000000","message":"I will add it.  Thanks","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"eee1278e332fd4c8c55c37814b05028f50df169a","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"        :param volumeInstance: the volume Instance"},{"line_number":1771,"context_line":"        :param volumeName: the volume name"},{"line_number":1772,"context_line":"        :param extraSpecs: additional info"},{"line_number":1773,"context_line":"        :param connector: optional"},{"line_number":1774,"context_line":"        :returns: storageGroupInstanceName"},{"line_number":1775,"context_line":"        \"\"\""},{"line_number":1776,"context_line":"        storageGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_cfad5b8a","line":1773,"range":{"start_line":1773,"start_character":15,"end_line":1773,"end_character":24},"updated":"2016-02-15 02:07:21.000000000","message":"Please add the comment for parameter \"reset\"","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"7ddf8a4c677d8d4db1a2866e733880ca22aa73c7","unresolved":false,"context_lines":[{"line_number":1770,"context_line":"        :param volumeInstance: the volume Instance"},{"line_number":1771,"context_line":"        :param volumeName: the volume name"},{"line_number":1772,"context_line":"        :param extraSpecs: additional info"},{"line_number":1773,"context_line":"        :param connector: optional"},{"line_number":1774,"context_line":"        :returns: storageGroupInstanceName"},{"line_number":1775,"context_line":"        \"\"\""},{"line_number":1776,"context_line":"        storageGroupInstanceName \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_6448ae2e","line":1773,"range":{"start_line":1773,"start_character":15,"end_line":1773,"end_character":24},"in_reply_to":"dae33548_cfad5b8a","updated":"2016-02-15 08:13:03.000000000","message":"I will.  Thanks","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"eee1278e332fd4c8c55c37814b05028f50df169a","unresolved":false,"context_lines":[{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        :param conn: connection the the ecom server"},{"line_number":2008,"context_line":"        :param controllerConfigService: the controller configuration service"},{"line_number":2009,"context_line":"        :param storageGroupName: the storage group name"},{"line_number":2010,"context_line":"        :param volumeInstance: the volume Instance"},{"line_number":2011,"context_line":"        :param volumeName: the volume name"},{"line_number":2012,"context_line":"        :param extraSpecs: extra specs"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_2f5fa773","line":2009,"range":{"start_line":2009,"start_character":0,"end_line":2009,"end_character":55},"updated":"2016-02-15 02:07:21.000000000","message":"Please remove the comment for the noexist parameter.","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"7ddf8a4c677d8d4db1a2866e733880ca22aa73c7","unresolved":false,"context_lines":[{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        :param conn: connection the the ecom server"},{"line_number":2008,"context_line":"        :param controllerConfigService: the controller configuration service"},{"line_number":2009,"context_line":"        :param storageGroupName: the storage group name"},{"line_number":2010,"context_line":"        :param volumeInstance: the volume Instance"},{"line_number":2011,"context_line":"        :param volumeName: the volume name"},{"line_number":2012,"context_line":"        :param extraSpecs: extra specs"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_045e02e9","line":2009,"range":{"start_line":2009,"start_character":0,"end_line":2009,"end_character":55},"in_reply_to":"dae33548_2f5fa773","updated":"2016-02-15 08:13:03.000000000","message":"I will.  Thanks","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"eee1278e332fd4c8c55c37814b05028f50df169a","unresolved":false,"context_lines":[{"line_number":2155,"context_line":"        :param storageSystemInstanceName: the storage system instance name"},{"line_number":2156,"context_line":"        :param extraSpecs: additional info"},{"line_number":2157,"context_line":"        :raises: VolumeBackendAPIException"},{"line_number":2158,"context_line":"        \"\"\""},{"line_number":2159,"context_line":"        storageGroupName \u003d self.utils.get_v3_storage_group_name("},{"line_number":2160,"context_line":"            extraSpecs[self.utils.POOL], extraSpecs[self.utils.SLO],"},{"line_number":2161,"context_line":"            extraSpecs[self.utils.WORKLOAD])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_6f51af62","line":2158,"range":{"start_line":2158,"start_character":8,"end_line":2158,"end_character":11},"updated":"2016-02-15 02:07:21.000000000","message":"ditto. Please rewrite the comments for some parameters to suit current change.","commit_id":"8b30ae760b83599515dd8bada5af66da4e7ea1e6"}]}