)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18142,"name":"David Sariel","email":"dsariel@redhat.com","username":"dsariel"},"change_message_id":"82e495214e731da1df681a7d9f98271711c8baa2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Replace a/b wit a//b to get an integer on Python 3."},{"line_number":14,"context_line":"* Replace map(...) and filter(...) with a list-comprehension to get a"},{"line_number":15,"context_line":"  list on Python 3."},{"line_number":16,"context_line":"* Replace dict.keys() with list(dict.keys()) to get a list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_147578ca","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":17},"updated":"2016-02-15 17:48:44.000000000","message":"Hi Victor \nCould you please s/wit/with\nthanks","commit_id":"48c9ec52b90ae823b95062209ebace20d2884e0b"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5662c2b3a7b06839f89d2fb4d47405b75eb506ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Replace a/b wit a//b to get an integer on Python 3."},{"line_number":14,"context_line":"* Replace map(...) and filter(...) with a list-comprehension to get a"},{"line_number":15,"context_line":"  list on Python 3."},{"line_number":16,"context_line":"* Replace dict.keys() with list(dict.keys()) to get a list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_27de7111","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":17},"in_reply_to":"dae33548_147578ca","updated":"2016-02-16 09:56:24.000000000","message":"Done","commit_id":"48c9ec52b90ae823b95062209ebace20d2884e0b"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"133ab0712bc4d28fbab73a24d959c9a07564c6b6","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    child \u003d NaElement(key)"},{"line_number":466,"context_line":"                    child.add_child_elem(value)"},{"line_number":467,"context_line":"                    self.add_child_elem(child)"},{"line_number":468,"context_line":"                elif isinstance(value, six.integer_types + (str, float)):"},{"line_number":469,"context_line":"                    self.add_new_child(key, six.text_type(value))"},{"line_number":470,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":471,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_aaa22fac","line":468,"updated":"2016-02-16 16:25:46.000000000","message":"nit: I\u0027d rather this used six.string_types instead of str, but that\u0027s besides the point of this patch, since that\u0027s what the original code had. :-(","commit_id":"5bc560394e66e133e36ff7a04f28d576e3e1e85b"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"8fee08827ca1c85314275a43b1055bc0abfb95c0","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                    child \u003d NaElement(key)"},{"line_number":466,"context_line":"                    child.add_child_elem(value)"},{"line_number":467,"context_line":"                    self.add_child_elem(child)"},{"line_number":468,"context_line":"                elif isinstance(value, six.integer_types + (str, float)):"},{"line_number":469,"context_line":"                    self.add_new_child(key, six.text_type(value))"},{"line_number":470,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":471,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_2e4a8e55","line":468,"in_reply_to":"dae33548_aaa22fac","updated":"2016-02-17 08:38:18.000000000","message":"Sorry, I don\u0027t know this code well enough to make such change (replace str with six.text_type). I\u0027m not sure that the change is needed neither.","commit_id":"5bc560394e66e133e36ff7a04f28d576e3e1e85b"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"353620b490bb405a2fe6bd6168ee6d3e4c5072bb","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                    child \u003d NaElement(key)"},{"line_number":467,"context_line":"                    child.add_child_elem(value)"},{"line_number":468,"context_line":"                    self.add_child_elem(child)"},{"line_number":469,"context_line":"                elif isinstance(value, six.integer_types + (str, float)):"},{"line_number":470,"context_line":"                    self.add_new_child(key, six.text_type(value))"},{"line_number":471,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":472,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0693e1fa","line":469,"range":{"start_line":469,"start_character":42,"end_line":469,"end_character":43},"updated":"2016-02-24 10:12:27.000000000","message":"I\u0027m not sure this is any better, it is certainly less readable - is it actually needed?","commit_id":"66273f3a414f258a991c0056def78bdbdcffdbc4"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"f323e7b2794433983e670c44f07b8a1b9038ec0a","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                    child \u003d NaElement(key)"},{"line_number":467,"context_line":"                    child.add_child_elem(value)"},{"line_number":468,"context_line":"                    self.add_child_elem(child)"},{"line_number":469,"context_line":"                elif isinstance(value, six.integer_types + (str, float)):"},{"line_number":470,"context_line":"                    self.add_new_child(key, six.text_type(value))"},{"line_number":471,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":472,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_38ad5d9b","line":469,"range":{"start_line":469,"start_character":42,"end_line":469,"end_character":43},"in_reply_to":"bae84128_0693e1fa","updated":"2016-02-24 11:18:53.000000000","message":"The long type is gone in Python 3: you get a NameError if you write isinstance(value, (str, int, float, long)).\n\nWhat do you suggest?","commit_id":"66273f3a414f258a991c0056def78bdbdcffdbc4"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"13f225a6feae1851cdddb9c581b3668ac25d0c6c","unresolved":false,"context_lines":[{"line_number":466,"context_line":"                    child \u003d NaElement(key)"},{"line_number":467,"context_line":"                    child.add_child_elem(value)"},{"line_number":468,"context_line":"                    self.add_child_elem(child)"},{"line_number":469,"context_line":"                elif isinstance(value, six.integer_types + (str, float)):"},{"line_number":470,"context_line":"                    self.add_new_child(key, six.text_type(value))"},{"line_number":471,"context_line":"                elif isinstance(value, (list, tuple, dict)):"},{"line_number":472,"context_line":"                    child \u003d NaElement(key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_4a16794c","line":469,"range":{"start_line":469,"start_character":42,"end_line":469,"end_character":43},"in_reply_to":"bae84128_38ad5d9b","updated":"2016-02-24 15:07:30.000000000","message":"Ok, so there is a good reason for it. Thanks.","commit_id":"66273f3a414f258a991c0056def78bdbdcffdbc4"}]}
