)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6cbf215c51292915bbe6d09bd8758ded0fa2aa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create snapshot, if the volume is not exist"},{"line_number":10,"context_line":"will lead to a log error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_c6d33d5e","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":11},"updated":"2016-02-16 13:01:16.000000000","message":"s/create/creating","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6cbf215c51292915bbe6d09bd8758ded0fa2aa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create snapshot, if the volume is not exist"},{"line_number":10,"context_line":"will lead to a log error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_a6bf19fa","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":38},"updated":"2016-02-16 13:01:16.000000000","message":"s/is/does","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"1cb10cd3db12e004ba1b01291b1eea2d1182e031","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create snapshot, if the volume is not exist"},{"line_number":10,"context_line":"will lead to a log error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_bd537a6a","line":9,"range":{"start_line":9,"start_character":36,"end_line":9,"end_character":38},"in_reply_to":"dae33548_a6bf19fa","updated":"2016-02-17 07:43:14.000000000","message":"Done\nThank you for your opinion","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"1cb10cd3db12e004ba1b01291b1eea2d1182e031","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create snapshot, if the volume is not exist"},{"line_number":10,"context_line":"will lead to a log error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_1d4d46c4","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":11},"in_reply_to":"dae33548_c6d33d5e","updated":"2016-02-17 07:43:14.000000000","message":"Done\nThank you for your opinion","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"f7a60bfe99aec06337196017c6eef87c1bb71764","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"will lead to a log error. The problem modify the volume"},{"line_number":11,"context_line":"is found from the db to the volume is got from the"},{"line_number":12,"context_line":"snapshot."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_b15558fb","line":10,"updated":"2016-02-23 06:22:38.000000000","message":"\"will lead to\" -\u003e \"there will be\"","commit_id":"88d14e8e6181041ee660ac778cc0d8328a0b6bde"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"a207c2507b0e46c25102698f7d88279bfddcb565","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Create snapshot have a log error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"will lead to a log error. The problem modify the volume"},{"line_number":11,"context_line":"is found from the db to the volume is got from the"},{"line_number":12,"context_line":"snapshot."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_9cb30be9","line":10,"in_reply_to":"bae84128_b15558fb","updated":"2016-02-23 07:11:26.000000000","message":"Done\nThank you for your opinions","commit_id":"88d14e8e6181041ee660ac778cc0d8328a0b6bde"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"f7a60bfe99aec06337196017c6eef87c1bb71764","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"will lead to a log error. The problem modify the volume"},{"line_number":11,"context_line":"is found from the db to the volume is got from the"},{"line_number":12,"context_line":"snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug:#1545912"},{"line_number":15,"context_line":"Change-Id:Ic99531dad4fab5e22e295e19bbfa94c7892e3ddc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_917134ab","line":12,"updated":"2016-02-23 06:22:38.000000000","message":"The last sentence could be changed to \"This patch will fix this.\" for simplify.","commit_id":"88d14e8e6181041ee660ac778cc0d8328a0b6bde"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"a207c2507b0e46c25102698f7d88279bfddcb565","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"will lead to a log error. The problem modify the volume"},{"line_number":11,"context_line":"is found from the db to the volume is got from the"},{"line_number":12,"context_line":"snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug:#1545912"},{"line_number":15,"context_line":"Change-Id:Ic99531dad4fab5e22e295e19bbfa94c7892e3ddc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bae84128_5ce4e3df","line":12,"in_reply_to":"bae84128_917134ab","updated":"2016-02-23 07:11:26.000000000","message":"Done\nThank you for your opinions","commit_id":"88d14e8e6181041ee660ac778cc0d8328a0b6bde"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"98be2a6dac2bc01ff2a893ba987d1bb103375ebf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"there will be lead to a log error. This patch will"},{"line_number":11,"context_line":"fix this volume is found from the db modify to this"},{"line_number":12,"context_line":"volume is got from the snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_6143f042","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":33},"updated":"2016-02-23 13:13:33.000000000","message":"The English expression looks a bit strange here. Would you reformat it?","commit_id":"f8f71d67e12fed273f6c5c46315e31da258993fa"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"67f31c623ead5f4c4749e0e31c6d78cd44ea5da9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating snapshot, if the volume does not exist"},{"line_number":10,"context_line":"there will be lead to a log error. This patch will"},{"line_number":11,"context_line":"fix this volume is found from the db modify to this"},{"line_number":12,"context_line":"volume is got from the snapshot."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug:#1545912"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_087b04c2","line":11,"range":{"start_line":11,"start_character":30,"end_line":11,"end_character":33},"in_reply_to":"bae84128_6143f042","updated":"2016-02-24 01:27:02.000000000","message":"Done\nThank you for your opinions","commit_id":"f8f71d67e12fed273f6c5c46315e31da258993fa"}],"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6cbf215c51292915bbe6d09bd8758ded0fa2aa8","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\") %"},{"line_number":713,"context_line":"                   {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        volume_name \u003d huawei_utils.encode_name(snapshot[\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_c677bd9d","line":714,"range":{"start_line":712,"start_character":12,"end_line":714,"end_character":26},"updated":"2016-02-16 13:01:16.000000000","message":"Use marker of translatable string here\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#using-a-marker-function","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"1cb10cd3db12e004ba1b01291b1eea2d1182e031","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\") %"},{"line_number":713,"context_line":"                   {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        volume_name \u003d huawei_utils.encode_name(snapshot[\u0027volume_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_7db9f278","line":714,"range":{"start_line":712,"start_character":12,"end_line":714,"end_character":26},"in_reply_to":"dae33548_c677bd9d","updated":"2016-02-17 07:43:14.000000000","message":"Thank you for your opinions\nThe docs have the example\nFor example, do not do this:\n# WRONG\nmsg \u003d _LE(\u0027There was an error.\u0027)\nLOG.exception(msg)\nraise LocalExceptionClass(msg)\nInstead, use this style:\n# RIGHT\nmsg \u003d _(\u0027There was an error.\u0027)\nLOG.exception(msg)\nraise LocalExceptionClass(msg)","commit_id":"8f017b93aa7d45e901887302321f6358cd67f06d"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"949cb4cbb151a205557b0c3d60b157d97d9f7e0d","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d _(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\") %"},{"line_number":713,"context_line":"                   {\"id\": snapshot[\u0027id\u0027]}"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d41f2c06","line":713,"range":{"start_line":712,"start_character":18,"end_line":713,"end_character":41},"updated":"2016-02-17 11:44:28.000000000","message":"You need the parentheses to wrap the line. This is an invalid syntax.","commit_id":"be785ee4f0aa80dc43668aada3879c60fb5b84ab"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"30f99fa5cf740d2d318328f3c82a2d59791edbe9","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d _(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\") %"},{"line_number":713,"context_line":"                   {\"id\": snapshot[\u0027id\u0027]}"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":716,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_881b9280","line":713,"range":{"start_line":712,"start_character":18,"end_line":713,"end_character":41},"in_reply_to":"dae33548_d41f2c06","updated":"2016-02-18 06:40:19.000000000","message":"Done\nThank you for your opinions","commit_id":"be785ee4f0aa80dc43668aada3879c60fb5b84ab"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"179bf696e2a37460c41185086457669d2c8eb404","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\")"},{"line_number":713,"context_line":"                   % {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_6015799a","line":712,"range":{"start_line":712,"start_character":38,"end_line":712,"end_character":39},"updated":"2016-02-18 10:56:38.000000000","message":"s/volume id/volume\nMaybe that will be better as here we try to get volume not volume id exactly.","commit_id":"acdb7860c87cfad2c906e29681e660f41cd99643"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"d575fca12e3f1c06cae87ccee260900c204aaa0f","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\")"},{"line_number":713,"context_line":"                   % {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_0b15a59a","line":712,"range":{"start_line":712,"start_character":38,"end_line":712,"end_character":39},"in_reply_to":"dae33548_6015799a","updated":"2016-02-18 13:39:50.000000000","message":"Thank you for your opinions\nThis log is described below will be used volume_id","commit_id":"acdb7860c87cfad2c906e29681e660f41cd99643"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f7e718f8d5776880692e782ecdb6a339752c4325","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\")"},{"line_number":713,"context_line":"                   % {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_deb8992c","line":712,"updated":"2016-02-24 11:40:44.000000000","message":"This should be _LE(\"Can\u0027t ...\n\nI realized that the plain _(\"Can\u0027t was not introduced by your change here but you are touching that line so it should be fixed as a part of this change.","commit_id":"43277f291519e82bffd100705944c192b6262376"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"74513df2c3ad8e1b2a20fba6933fc30d53b3cfda","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\")"},{"line_number":713,"context_line":"                   % {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_3299b120","line":712,"in_reply_to":"bae84128_47576eca","updated":"2016-02-25 10:58:13.000000000","message":"Sorry, I was confused.","commit_id":"43277f291519e82bffd100705944c192b6262376"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"465ac6c602708f81c6c312926146246b9f1fb3e5","unresolved":false,"context_lines":[{"line_number":709,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":710,"context_line":"        volume \u003d snapshot.get(\u0027volume\u0027)"},{"line_number":711,"context_line":"        if not volume:"},{"line_number":712,"context_line":"            msg \u003d (_(\"Can\u0027t get volume id from snapshot, snapshot: %(id)s\")"},{"line_number":713,"context_line":"                   % {\"id\": snapshot[\u0027id\u0027]})"},{"line_number":714,"context_line":"            LOG.error(msg)"},{"line_number":715,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_47576eca","line":712,"in_reply_to":"bae84128_deb8992c","updated":"2016-02-25 00:56:31.000000000","message":"Thank you for your opinions\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#using-a-marker-function\n\nThe docs have the example\nFor example, do not do this:\n# WRONG\nmsg \u003d _LE(\u0027There was an error.\u0027)\nLOG.exception(msg)\nraise LocalExceptionClass(msg)\nInstead, use this style:\n# RIGHT\nmsg \u003d _(\u0027There was an error.\u0027)\nLOG.exception(msg)\nraise LocalExceptionClass(msg)","commit_id":"43277f291519e82bffd100705944c192b6262376"}]}