)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"856e120c7a5ffd812b9cf38c9484d0cd903ece4b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Wait for periodic tasks to stop on exit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a Service in Cinder exits it stops all operations and waits for"},{"line_number":10,"context_line":"them to complete, and it also stops all periodica tasks created with"},{"line_number":11,"context_line":"FixedIntervalLoop, but it doesn\u0027t wait until these are completed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch will wait for all periodic tasks that received the stop"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_66bdfa67","line":10,"range":{"start_line":10,"start_character":40,"end_line":10,"end_character":49},"updated":"2016-02-16 19:33:21.000000000","message":"typo nit","commit_id":"598e35c337c6acf0f7558a874e85c727fc0fbde2"}],"cinder/service.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"856e120c7a5ffd812b9cf38c9484d0cd903ece4b","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                x.stop()"},{"line_number":286,"context_line":"            except Exception:"},{"line_number":287,"context_line":"                pass"},{"line_number":288,"context_line":"        self.timers \u003d []"},{"line_number":289,"context_line":"        super(Service, self).stop()"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def wait(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e678eac6","side":"PARENT","line":288,"range":{"start_line":288,"start_character":8,"end_line":288,"end_character":24},"updated":"2016-02-16 19:33:21.000000000","message":"It took me few minutes to understand that so for the record:\n\nThis is the line that was causing this problem - wait() executed after stop() was iterating over an empty list so it actually wasn\u0027t waiting for anything.\n\nI, by the way, love to see \"initial fork out of nova\" in git blame.","commit_id":"686da43b27ebb20af62acf4e48753eafd8e2297f"}]}