)]}'
{"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"f3508aa5fa390355847e175b2d7c71938e88f1cb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from cinder.volume.drivers.emc import emc_vmax_provision_v3"},{"line_number":38,"context_line":"from cinder.volume.drivers.emc import emc_vmax_utils"},{"line_number":39,"context_line":"from cinder.volume import volume_types"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"CINDER_EMC_CONFIG_DIR \u003d \u0027/etc/cinder/\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_e2eb22af","side":"PARENT","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":0},"updated":"2016-03-11 11:38:25.000000000","message":"This change is unnecessary and is required to have 2 blank lines after imports as per the standard [1].\n[1] http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"b31088f0a6a566eaca2e9cba9c4ecc4a4a974692"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"f3508aa5fa390355847e175b2d7c71938e88f1cb","unresolved":false,"context_lines":[{"line_number":3797,"context_line":"        return_value\u003d{1, 2, 3})"},{"line_number":3798,"context_line":"    def test_ssl_support(self, pool_stats):"},{"line_number":3799,"context_line":"        self.driver.common.update_volume_stats()"},{"line_number":3800,"context_line":"        self.assertIs(True, self.driver.common.ecomUseSSL)"},{"line_number":3801,"context_line":""},{"line_number":3802,"context_line":"    def _cleanup(self):"},{"line_number":3803,"context_line":"        if self.config_file_path:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_2286aab9","line":3800,"range":{"start_line":3800,"start_character":9,"end_line":3800,"end_character":58},"updated":"2016-03-11 11:38:25.000000000","message":"Can we use self.assertTrue(self.driver.common.ecomUseSSL) instead.","commit_id":"12a94a799e3d4a80565e5d678840860819fac25f"}],"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e5fd9aad6128a76c38e9253d3c188f13092f138a","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                          \u0027driver_client_cert_key\u0027),"},{"line_number":1243,"context_line":"                      \"cert_file\":"},{"line_number":1244,"context_line":"                      self.configuration.safe_get(\u0027driver_client_cert\u0027)},"},{"line_number":1245,"context_line":"                ca_certs\u003dstr(self.ecomCACert),"},{"line_number":1246,"context_line":"                no_verification\u003dself.ecomNoVerification)"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_0033ed14","line":1245,"updated":"2016-03-03 16:44:41.000000000","message":"str() -\u003e six.text_type()","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8abd3a77a2814e26cb2e800bfeb4748ab7a78965","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                          \u0027driver_client_cert_key\u0027),"},{"line_number":1243,"context_line":"                      \"cert_file\":"},{"line_number":1244,"context_line":"                      self.configuration.safe_get(\u0027driver_client_cert\u0027)},"},{"line_number":1245,"context_line":"                ca_certs\u003dstr(self.ecomCACert),"},{"line_number":1246,"context_line":"                no_verification\u003dself.ecomNoVerification)"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_ccd65e4e","line":1245,"in_reply_to":"7af24918_0033ed14","updated":"2016-03-03 17:13:33.000000000","message":"we will change this","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e5fd9aad6128a76c38e9253d3c188f13092f138a","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"        if self.ecomUseSSL:"},{"line_number":1631,"context_line":"            self.url \u003d (\"https://%(ip_port)s\""},{"line_number":1632,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"},{"line_number":1633,"context_line":"            if self.ecomNoVerification is not None:"},{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_366c73cf","line":1633,"updated":"2016-03-03 16:44:41.000000000","message":"if self.ecomNoVerification:","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8abd3a77a2814e26cb2e800bfeb4748ab7a78965","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"        if self.ecomUseSSL:"},{"line_number":1631,"context_line":"            self.url \u003d (\"https://%(ip_port)s\""},{"line_number":1632,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"},{"line_number":1633,"context_line":"            if self.ecomNoVerification is not None:"},{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_acbcb206","line":1633,"in_reply_to":"7af24918_366c73cf","updated":"2016-03-03 17:13:33.000000000","message":"Will change, thanks","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e5fd9aad6128a76c38e9253d3c188f13092f138a","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"},{"line_number":1633,"context_line":"            if self.ecomNoVerification is not None:"},{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_9bf77258","line":1635,"updated":"2016-03-03 16:44:41.000000000","message":"Why assigning it to bool(\"True\")?  bool(\"True\") returns True.  Just assign it to True directly:\n\nself.ecomNoVerification \u003d True","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8abd3a77a2814e26cb2e800bfeb4748ab7a78965","unresolved":false,"context_lines":[{"line_number":1632,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"},{"line_number":1633,"context_line":"            if self.ecomNoVerification is not None:"},{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_8c50d6d5","line":1635,"in_reply_to":"7af24918_9bf77258","updated":"2016-03-03 17:13:33.000000000","message":"Will change, thanks","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e5fd9aad6128a76c38e9253d3c188f13092f138a","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"},{"line_number":1639,"context_line":"                self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1640,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_1bb9a279","line":1637,"updated":"2016-03-03 16:44:41.000000000","message":"bool(\"\") returns False.  Why don\u0027t you just say:\n\nself.ecomNoVerification \u003d False","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8abd3a77a2814e26cb2e800bfeb4748ab7a78965","unresolved":false,"context_lines":[{"line_number":1634,"context_line":"                if self.ecomNoVerification is True:"},{"line_number":1635,"context_line":"                    self.ecomNoVerification \u003d bool(\"True\")"},{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"},{"line_number":1639,"context_line":"                self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1640,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_cc649eba","line":1637,"in_reply_to":"7af24918_1bb9a279","updated":"2016-03-03 17:13:33.000000000","message":"Will change, thanks","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e5fd9aad6128a76c38e9253d3c188f13092f138a","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"},{"line_number":1639,"context_line":"                self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1640,"context_line":"        else:"},{"line_number":1641,"context_line":"            self.url \u003d (\"http://%(ip_port)s\""},{"line_number":1642,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_5bafaa29","line":1639,"updated":"2016-03-03 16:44:41.000000000","message":"Same","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8abd3a77a2814e26cb2e800bfeb4748ab7a78965","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                else:"},{"line_number":1637,"context_line":"                    self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1638,"context_line":"            else:"},{"line_number":1639,"context_line":"                self.ecomNoVerification \u003d bool(\"\")"},{"line_number":1640,"context_line":"        else:"},{"line_number":1641,"context_line":"            self.url \u003d (\"http://%(ip_port)s\""},{"line_number":1642,"context_line":"                        % {\u0027ip_port\u0027: ip_port})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_0c5b26f7","line":1639,"in_reply_to":"7af24918_5bafaa29","updated":"2016-03-03 17:13:33.000000000","message":"Will change, thanks","commit_id":"b4899fcae0fbe61f484fead47e28e341786ffbab"}]}