)]}'
{"cinder/volume/drivers/emc/emc_vmax_masking.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"96ae9a855ddbc47ea0c7931e0980c231cdad84b5","unresolved":false,"context_lines":[{"line_number":1817,"context_line":"        \"\"\"Steps if the volume is the last in a storage group."},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"        1. Check if the volume is in a masking view."},{"line_number":1820,"context_line":"        2. If it is in a masking view, delete the masking view,"},{"line_number":1821,"context_line":"           remove the volume from the storage group, and delete"},{"line_number":1822,"context_line":"           the storage group."},{"line_number":1823,"context_line":"        3. If it is not in a masking view, remove the volume from the"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_8fa1f8fa","line":1820,"updated":"2016-02-17 17:10:28.000000000","message":"Commented could be amended to include IG cleanup.","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"17ff16b25eec958fac438079185779c33087ff6d","unresolved":false,"context_lines":[{"line_number":1817,"context_line":"        \"\"\"Steps if the volume is the last in a storage group."},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"        1. Check if the volume is in a masking view."},{"line_number":1820,"context_line":"        2. If it is in a masking view, delete the masking view,"},{"line_number":1821,"context_line":"           remove the volume from the storage group, and delete"},{"line_number":1822,"context_line":"           the storage group."},{"line_number":1823,"context_line":"        3. If it is not in a masking view, remove the volume from the"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_0eadae9a","line":1820,"in_reply_to":"dae33548_8fa1f8fa","updated":"2016-02-18 15:02:26.000000000","message":"We will add this","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"96ae9a855ddbc47ea0c7931e0980c231cdad84b5","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        :param initiatorGroupInstanceName - the initiator group instance name"},{"line_number":2531,"context_line":"        \"\"\""},{"line_number":2532,"context_line":"        storageHardwareIdInstances \u003d ("},{"line_number":2533,"context_line":"            conn.Associators(initiatorGroupInstanceName,"},{"line_number":2534,"context_line":"                             ResultClass\u003d\u0027SE_StorageHardwareID\u0027))"},{"line_number":2535,"context_line":"        if len(storageHardwareIdInstances) \u003d\u003d 0:"},{"line_number":2536,"context_line":"            LOG.debug(\"No initiators found in Initiator group \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_caeace0e","line":2533,"updated":"2016-02-17 17:10:28.000000000","message":"You probably should get AssociatorNames here rather than the full instances since that is all that is needed below.","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"17ff16b25eec958fac438079185779c33087ff6d","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        :param initiatorGroupInstanceName - the initiator group instance name"},{"line_number":2531,"context_line":"        \"\"\""},{"line_number":2532,"context_line":"        storageHardwareIdInstances \u003d ("},{"line_number":2533,"context_line":"            conn.Associators(initiatorGroupInstanceName,"},{"line_number":2534,"context_line":"                             ResultClass\u003d\u0027SE_StorageHardwareID\u0027))"},{"line_number":2535,"context_line":"        if len(storageHardwareIdInstances) \u003d\u003d 0:"},{"line_number":2536,"context_line":"            LOG.debug(\"No initiators found in Initiator group \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_2e8192fb","line":2533,"in_reply_to":"dae33548_caeace0e","updated":"2016-02-18 15:02:26.000000000","message":"ok","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"96ae9a855ddbc47ea0c7931e0980c231cdad84b5","unresolved":false,"context_lines":[{"line_number":2541,"context_line":"        hardwareIdManagementService \u003d ("},{"line_number":2542,"context_line":"            self.utils.find_storage_hardwareid_service(conn,"},{"line_number":2543,"context_line":"                                                       storageSystemName))"},{"line_number":2544,"context_line":"        for storageHardwareIdInstance in storageHardwareIdInstances:"},{"line_number":2545,"context_line":"            initiatorName \u003d storageHardwareIdInstance[\u0027StorageID\u0027]"},{"line_number":2546,"context_line":"            hardwareIdPath \u003d storageHardwareIdInstance.path"},{"line_number":2547,"context_line":"            LOG.debug(\"Initiator %(initiatorName)s \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_2a7b7a29","line":2544,"updated":"2016-02-17 17:10:28.000000000","message":"I\u0027m wondering if you may be required by SMI-S to remove the HW IDs from the IG before deleting them? The method name seems to indicate they will be removed. i.e.:\n\n        rc, job \u003d self.common.conn.InvokeMethod(\n            \u0027RemoveMembers\u0027, controllerConfigService,\n            MaskingGroup\u003dinitiatorGroupInstanceName,\n            Members\u003dhardwareIdinstanceNames)\n\nIf the DeleteStorageHardwareID operation both removes them and deletes them, then you are OK.","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"17ff16b25eec958fac438079185779c33087ff6d","unresolved":false,"context_lines":[{"line_number":2541,"context_line":"        hardwareIdManagementService \u003d ("},{"line_number":2542,"context_line":"            self.utils.find_storage_hardwareid_service(conn,"},{"line_number":2543,"context_line":"                                                       storageSystemName))"},{"line_number":2544,"context_line":"        for storageHardwareIdInstance in storageHardwareIdInstances:"},{"line_number":2545,"context_line":"            initiatorName \u003d storageHardwareIdInstance[\u0027StorageID\u0027]"},{"line_number":2546,"context_line":"            hardwareIdPath \u003d storageHardwareIdInstance.path"},{"line_number":2547,"context_line":"            LOG.debug(\"Initiator %(initiatorName)s \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_4ea17693","line":2544,"in_reply_to":"dae33548_2a7b7a29","updated":"2016-02-18 15:02:26.000000000","message":"We will look into this","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"25f3eda91a0a1922299e0454f40187a82ff08294","unresolved":false,"context_lines":[{"line_number":2541,"context_line":"        hardwareIdManagementService \u003d ("},{"line_number":2542,"context_line":"            self.utils.find_storage_hardwareid_service(conn,"},{"line_number":2543,"context_line":"                                                       storageSystemName))"},{"line_number":2544,"context_line":"        for storageHardwareIdInstance in storageHardwareIdInstances:"},{"line_number":2545,"context_line":"            initiatorName \u003d storageHardwareIdInstance[\u0027StorageID\u0027]"},{"line_number":2546,"context_line":"            hardwareIdPath \u003d storageHardwareIdInstance.path"},{"line_number":2547,"context_line":"            LOG.debug(\"Initiator %(initiatorName)s \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8ebae3be","line":2544,"in_reply_to":"dae33548_4ea17693","updated":"2016-02-22 10:49:00.000000000","message":"DeleteStorageHardwareId will implicitly remove initiators from initiator group. So we don’t have to explicitly ‘remove’ it from the IG.","commit_id":"b3ac891c2dcbce758ba966c595fa2a0ee223a1d4"}]}