)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"ab5af5e60efd4c4808e82b79cea467ea94e73747","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Manage volume fails due to lower array version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we try to import a existing volume to cinder, we try"},{"line_number":10,"context_line":"to find whether the volume already exists in a hypermetro."},{"line_number":11,"context_line":"But if the array version is lower than V3R3, the request"},{"line_number":12,"context_line":"to find the hypermetro info will fails array version lower"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_763076e9","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":23},"updated":"2016-02-19 03:09:07.000000000","message":"s/a/an","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9a3d094da5521fe8bd8dc85e8aba250993161a99","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When we try to import a existing volume to cinder, we try"},{"line_number":10,"context_line":"to find whether the volume already exists in a hypermetro."},{"line_number":11,"context_line":"But if the array version is lower than V3R3, the request"},{"line_number":12,"context_line":"to find the hypermetro info will fails array version lower"},{"line_number":13,"context_line":"than V3R3 not support hypermetro."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1546375"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_f2d8e91f","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":38},"updated":"2016-02-19 23:00:42.000000000","message":"fail on an","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"ab5af5e60efd4c4808e82b79cea467ea94e73747","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to find whether the volume already exists in a hypermetro."},{"line_number":11,"context_line":"But if the array version is lower than V3R3, the request"},{"line_number":12,"context_line":"to find the hypermetro info will fails array version lower"},{"line_number":13,"context_line":"than V3R3 not support hypermetro."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1546375"},{"line_number":16,"context_line":"Change-Id: Ia28e62f3924155e813df80f3c4932e3f0f10333e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_9661bad6","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":13},"updated":"2016-02-19 03:09:07.000000000","message":"s/V3R3/V3R3 which doesn\u0027t","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"ab5af5e60efd4c4808e82b79cea467ea94e73747","unresolved":false,"context_lines":[{"line_number":1833,"context_line":"            return result[\"data\"][\"AVAILABLEHOSTLUNIDLIST\"]"},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"    def get_hypermetro_pairs(self):"},{"line_number":1836,"context_line":"        url \u003d \"/HyperMetroPair?range\u003d[0-100]\""},{"line_number":1837,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1838,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1839,"context_line":"            LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_b6615eab","line":1836,"range":{"start_line":1836,"start_character":40,"end_line":1836,"end_character":43},"updated":"2016-02-19 03:09:07.000000000","message":"Just curious why [0-65535] in your patchset 1 will fail the test cases and what\u0027s the exact meaning of the range?","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"ab5af5e60efd4c4808e82b79cea467ea94e73747","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1839,"context_line":"            LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))"},{"line_number":1840,"context_line":"            return []"},{"line_number":1841,"context_line":"        else:"},{"line_number":1842,"context_line":"            msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1843,"context_line":"            self._assert_rest_result(result, msg)"},{"line_number":1844,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_167bea7c","line":1841,"range":{"start_line":1841,"start_character":8,"end_line":1841,"end_character":12},"updated":"2016-02-19 03:09:07.000000000","message":"Seems the \"else:\" is not needed here.","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"61e338c1a3931e7ba3f16a07e01d6555ef1553d4","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1839,"context_line":"            LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))"},{"line_number":1840,"context_line":"            return []"},{"line_number":1841,"context_line":"        else:"},{"line_number":1842,"context_line":"            msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1843,"context_line":"            self._assert_rest_result(result, msg)"},{"line_number":1844,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_ef581859","line":1841,"range":{"start_line":1841,"start_character":8,"end_line":1841,"end_character":12},"in_reply_to":"dae33548_167bea7c","updated":"2016-02-19 16:08:00.000000000","message":"I think so too.\n[...]\nif result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:\n   LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))\n   return []\nmsg \u003d _(\u0027Get HyperMetroPair error.\u0027)\n[...]","commit_id":"0db43ca2799fffbcfbb675dca49bbc3a7c4d2177"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"46d042fa9874c7f15242d93247cd55a2bb2e1caf","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"        url \u003d \"/HyperMetroPair?range\u003d[0-65535]\""},{"line_number":1838,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1839,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1840,"context_line":"            LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))"},{"line_number":1841,"context_line":"            return []"},{"line_number":1842,"context_line":"        msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1843,"context_line":"        self._assert_rest_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_d8276cc8","line":1840,"updated":"2016-02-29 07:43:32.000000000","message":"Can we say what HyperMetro doesn\u0027t support so it\u0027s useful when the operators are reading this among a bunch of other log messages?","commit_id":"70d8ff786c689752b0d43b7e57a54f0fbec519f5"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"a381004f3ff9650fe8a1c21dcfd25b784d214901","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"        url \u003d \"/HyperMetroPair?range\u003d[0-65535]\""},{"line_number":1838,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1839,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1840,"context_line":"            LOG.warning(_LW(\u0027HyperMetro is not supported.\u0027))"},{"line_number":1841,"context_line":"            return []"},{"line_number":1842,"context_line":"        msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1843,"context_line":"        self._assert_rest_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_31c313ef","line":1840,"in_reply_to":"9aed3d3a_d8276cc8","updated":"2016-02-29 09:05:54.000000000","message":"Thanks for your check Mike. We don\u0027t expect operators seeing this message, we just want this function return a empty list indicating that we got nothing from array about hypermetro, and let the volume imported successfully into cinder. For other operations relating to hypermetro, I think it\u0027s OK to return a empty list indicating that we got nothing from array about hypermetro. Thanks!","commit_id":"70d8ff786c689752b0d43b7e57a54f0fbec519f5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b41f7ba8a50c08cdfedacb70460d424669d8aca7","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"        url \u003d \"/HyperMetroPair?range\u003d[0-65535]\""},{"line_number":1844,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1845,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1846,"context_line":"            LOG.debug(\u0027HyperMetro is not supported.\u0027)"},{"line_number":1847,"context_line":"            return []"},{"line_number":1848,"context_line":"        msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1849,"context_line":"        self._assert_rest_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_822201b8","line":1846,"updated":"2016-03-01 17:18:28.000000000","message":"IMO, it should be info level, not debug","commit_id":"05c1e823f98c4030faa4c6facdd64220318d3cea"},{"author":{"_account_id":8202,"name":"chenzongliang","email":"chenzongliang@huawei.com","username":"zongliang"},"change_message_id":"6aefd021df6e93e4e9be546f1fd873c35a2dad6d","unresolved":false,"context_lines":[{"line_number":1844,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1845,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.NOT_SUPPORTED:"},{"line_number":1846,"context_line":"            LOG.debug(\u0027HyperMetro is not supported.\u0027)"},{"line_number":1847,"context_line":"            return []"},{"line_number":1848,"context_line":"        msg \u003d _(\u0027Get HyperMetroPair error.\u0027)"},{"line_number":1849,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":1850,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_eb22a4b8","line":1847,"range":{"start_line":1847,"start_character":19,"end_line":1847,"end_character":21},"updated":"2016-03-02 03:38:08.000000000","message":"IMO, it should be warning info level,not debug.","commit_id":"05c1e823f98c4030faa4c6facdd64220318d3cea"}]}