)]}'
{"cinder/transfer/api.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"b9b5f42beeeb87b492161ab38b18fa9f5583047d","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        volume_utils.notify_about_volume_usage(context, vol_ref,"},{"line_number":171,"context_line":"                                               \"transfer.accept.start\")"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        reservations \u003d None"},{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: 1, \u0027gigabytes\u0027: vol_ref.size}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_619b9673","line":172,"updated":"2016-02-18 23:42:26.000000000","message":"Is this required for the patch?","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"051abf052970f156687e651b8bb4bd7df9b4fd56","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        volume_utils.notify_about_volume_usage(context, vol_ref,"},{"line_number":171,"context_line":"                                               \"transfer.accept.start\")"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        reservations \u003d None"},{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: 1, \u0027gigabytes\u0027: vol_ref.size}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_831695ef","line":172,"in_reply_to":"dae33548_619b9673","updated":"2016-02-19 05:35:29.000000000","message":"Deleted","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"b9b5f42beeeb87b492161ab38b18fa9f5583047d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            def _consumed(name):"},{"line_number":186,"context_line":"                return (usages[name][\u0027reserved\u0027] + usages[name][\u0027in_use\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"            for over in overs:"},{"line_number":189,"context_line":"                if \u0027gigabytes\u0027 in over:"},{"line_number":190,"context_line":"                    msg \u003d _LW(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":191,"context_line":"                              \"%(s_size)sG volume (%(d_consumed)dG of \""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_c19382ff","line":188,"updated":"2016-02-18 23:42:26.000000000","message":"I like the way we\u0027re doing this here, seems cleaner than  what we do for https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L603-L642.\n\nAt some point it would be nice to move a helper for this behavior into quota_utils that we use in both areas, but no need to convolute this patch with that change.","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"051abf052970f156687e651b8bb4bd7df9b4fd56","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            def _consumed(name):"},{"line_number":186,"context_line":"                return (usages[name][\u0027reserved\u0027] + usages[name][\u0027in_use\u0027])"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"            for over in overs:"},{"line_number":189,"context_line":"                if \u0027gigabytes\u0027 in over:"},{"line_number":190,"context_line":"                    msg \u003d _LW(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":191,"context_line":"                              \"%(s_size)sG volume (%(d_consumed)dG of \""}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_43cacd6f","line":188,"in_reply_to":"dae33548_c19382ff","updated":"2016-02-19 05:35:29.000000000","message":"Yeah, I agree that finally to have a helper method to deal with OverQuota. \n\nBut firstly I am going to fix the bug at first.","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"b9b5f42beeeb87b492161ab38b18fa9f5583047d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                    raise exception.VolumeLimitExceeded(allowed\u003dquotas[over],"},{"line_number":208,"context_line":"                                                        name\u003dover)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        donor_reservations \u003d None"},{"line_number":211,"context_line":"        try:"},{"line_number":212,"context_line":"            donor_id \u003d vol_ref[\u0027project_id\u0027]"},{"line_number":213,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: -1, \u0027gigabytes\u0027: -vol_ref.size}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_21ca2e6f","line":210,"updated":"2016-02-18 23:42:26.000000000","message":"Is this required for this patch?","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"051abf052970f156687e651b8bb4bd7df9b4fd56","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                    raise exception.VolumeLimitExceeded(allowed\u003dquotas[over],"},{"line_number":208,"context_line":"                                                        name\u003dover)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        donor_reservations \u003d None"},{"line_number":211,"context_line":"        try:"},{"line_number":212,"context_line":"            donor_id \u003d vol_ref[\u0027project_id\u0027]"},{"line_number":213,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: -1, \u0027gigabytes\u0027: -vol_ref.size}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_23dce945","line":210,"in_reply_to":"dae33548_21ca2e6f","updated":"2016-02-19 05:35:29.000000000","message":"Deleted","commit_id":"1f5309f225aec63ef82feb585c0bebcdeda6cba9"}]}