)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"be0ee9fc3675ff28ebe057c368c107cbba78ef61","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- backup_thread_pool_size"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"They take the same default value oslo.service currently has, 1000."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4da8f8f3acc286049642aaee62efa7eba934e84d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_993d8fc6","line":18,"updated":"2016-02-18 15:50:40.000000000","message":"Needs a DocImpact tag here since there are new config options being added.","commit_id":"3182f75e4257147de58264c4ee9d71443117884c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5fd8a77b81dcb9b1d98899efadc191719f4786bc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- backup_thread_pool_size"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"They take the same default value oslo.service currently has, 1000."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I4da8f8f3acc286049642aaee62efa7eba934e84d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_86f22e99","line":18,"in_reply_to":"dae33548_993d8fc6","updated":"2016-02-19 09:26:26.000000000","message":"I don\u0027t think we really need it, I\u0027ve already included release notes and new configuration options are detected by the Doc Team\u0027s automation.","commit_id":"3182f75e4257147de58264c4ee9d71443117884c"}],"cinder/service.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a1e6cdd860b8222f7a2e88f4aeb1813ed4d7e3a3","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Use the part after cinder- in the binary name to get the right thread"},{"line_number":142,"context_line":"        # configuration option for this service."},{"line_number":143,"context_line":"        cfg_name \u003d \u0027%s_thread_pool_size\u0027 % binary[7:]"},{"line_number":144,"context_line":"        num_threads \u003d getattr(CONF, cfg_name, DEFAULT_NUM_THREADS)"},{"line_number":145,"context_line":"        super(Service, self).__init__(threads\u003dnum_threads)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_e802c33d","line":143,"updated":"2016-03-01 18:25:29.000000000","message":"Suggestion:\ncfg_name \u003d \u0027%s_thread_pool_size\u0027 % binary.replace(\u0027cinder-\u0027, \u0027\u0027)","commit_id":"be35fd7f3a477374bfb5e7ac4bf8285346b31fa5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5b474edcf2ec0d9b0d693e59f88a66ce134e8321","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Use the part after cinder- in the binary name to get the right thread"},{"line_number":142,"context_line":"        # configuration option for this service."},{"line_number":143,"context_line":"        cfg_name \u003d \u0027%s_thread_pool_size\u0027 % binary[7:]"},{"line_number":144,"context_line":"        num_threads \u003d getattr(CONF, cfg_name, DEFAULT_NUM_THREADS)"},{"line_number":145,"context_line":"        super(Service, self).__init__(threads\u003dnum_threads)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_76fe6d39","line":143,"in_reply_to":"7af24918_e802c33d","updated":"2016-03-02 09:39:20.000000000","message":"I don\u0027t see a big win with this change, but ok.","commit_id":"be35fd7f3a477374bfb5e7ac4bf8285346b31fa5"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"2de6e01a806c88a7103bf83af19db738757dc860","unresolved":false,"context_lines":[{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEFAULT_NUM_THREADS \u003d 1000"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"service_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_30ff1036","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":26},"updated":"2016-03-11 12:10:39.000000000","message":"I think it had better to add comments to explain the value(1000) from which the oslo.service.","commit_id":"3067a5b2acb2e1f4d7a5aba4682d141ac4be5ef2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3783efcc2ecdb5006170960414089dd922d64ad2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    \u0027The default is equal to the number of CPUs available.\u0027),"},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027volume_thread_pool_size\u0027,"},{"line_number":77,"context_line":"               default\u003dDEFAULT_NUM_THREADS,"},{"line_number":78,"context_line":"               help\u003d\u0027Size of the pool of greenthreads used by the volume \u0027"},{"line_number":79,"context_line":"                    \u0027service.\u0027),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027backup_thread_pool_size\u0027,"},{"line_number":81,"context_line":"               default\u003dDEFAULT_NUM_THREADS,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_b2cf68af","line":78,"range":{"start_line":78,"start_character":41,"end_line":78,"end_character":53},"updated":"2016-05-28 21:07:31.000000000","message":"I\u0027m not sure the user editing the sample config file and reading this help text will know what a greenthread is, but I think it\u0027s probably contextually obvious enough that it won\u0027t cause too much confusion.\n\nThen again, we may want a little confusion there so they don\u0027t just start changing the default not really knowing what they are doing.","commit_id":"3067a5b2acb2e1f4d7a5aba4682d141ac4be5ef2"}]}