)]}'
{"cinder/volume/drivers/pure.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"63b4dcebed1348951580cb496ac6a28dfdb5e17e","unresolved":false,"context_lines":[{"line_number":958,"context_line":"        # Older versions of the module (1.4.0) do not support setting ssl certs"},{"line_number":959,"context_line":"        # TODO(patrickeast): In future releases drop support for 1.4.0"},{"line_number":960,"context_line":"        module_version \u003d purestorage.VERSION.split(\u0027.\u0027)"},{"line_number":961,"context_line":"        if int(module_version[0]) \u003e\u003d 1 and int(module_version[1]) \u003e 4:"},{"line_number":962,"context_line":"            array \u003d purestorage.FlashArray(san_ip,"},{"line_number":963,"context_line":"                                           api_token\u003dapi_token,"},{"line_number":964,"context_line":"                                           rest_version\u003drest_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_cd39ffa5","line":961,"range":{"start_line":961,"start_character":43,"end_line":961,"end_character":69},"updated":"2016-02-18 18:49:52.000000000","message":"So, You are checking that the major version is \u003e\u003d 1.  If that goes to 2 then I assume the second number will be \u003c 4 and this will fail.  Is that not a concern?","commit_id":"8ca46c6680070f19c5ca9ff39ca71da97df6a76a"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"36fe0cc8fa1d0ef1eb904856ece1a6f51730acce","unresolved":false,"context_lines":[{"line_number":958,"context_line":"        # Older versions of the module (1.4.0) do not support setting ssl certs"},{"line_number":959,"context_line":"        # TODO(patrickeast): In future releases drop support for 1.4.0"},{"line_number":960,"context_line":"        module_version \u003d purestorage.VERSION.split(\u0027.\u0027)"},{"line_number":961,"context_line":"        if int(module_version[0]) \u003e\u003d 1 and int(module_version[1]) \u003e 4:"},{"line_number":962,"context_line":"            array \u003d purestorage.FlashArray(san_ip,"},{"line_number":963,"context_line":"                                           api_token\u003dapi_token,"},{"line_number":964,"context_line":"                                           rest_version\u003drest_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_8d753733","line":961,"range":{"start_line":961,"start_character":43,"end_line":961,"end_character":69},"in_reply_to":"dae33548_cd39ffa5","updated":"2016-02-18 18:55:34.000000000","message":"Oh derp, yea you\u0027re right.","commit_id":"8ca46c6680070f19c5ca9ff39ca71da97df6a76a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"acbe7509ada15db078242e35b7bf312e0f8ec267","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                                \u0027but cannot be enabled with purestorage \u0027"},{"line_number":973,"context_line":"                                \u0027module version %(version)s. Upgrade to a \u0027"},{"line_number":974,"context_line":"                                \u0027newer version to enable this feature.\u0027),"},{"line_number":975,"context_line":"                            {\u0027version\u0027: purestorage.VERSION})"},{"line_number":976,"context_line":"            array \u003d purestorage.FlashArray(san_ip,"},{"line_number":977,"context_line":"                                           api_token\u003dapi_token,"},{"line_number":978,"context_line":"                                           rest_version\u003drest_version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e57c4cb7","line":975,"updated":"2016-02-22 22:16:26.000000000","message":"If someone opts in to this option and it doesn\u0027t work, this probably should fail.  Otherwise someone deploying a handful of differing backends could not be getting the security guarantees they think they are.\n\nIf there\u0027s a reason to not do that, it would be appropriate to log at error instead of warning level.","commit_id":"943d81cc7b3a129efd515047c6455742d06e9664"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"5c4b7f6c492b054611899ef3ec37c926c4923fb7","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                                \u0027but cannot be enabled with purestorage \u0027"},{"line_number":973,"context_line":"                                \u0027module version %(version)s. Upgrade to a \u0027"},{"line_number":974,"context_line":"                                \u0027newer version to enable this feature.\u0027),"},{"line_number":975,"context_line":"                            {\u0027version\u0027: purestorage.VERSION})"},{"line_number":976,"context_line":"            array \u003d purestorage.FlashArray(san_ip,"},{"line_number":977,"context_line":"                                           api_token\u003dapi_token,"},{"line_number":978,"context_line":"                                           rest_version\u003drest_version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_b072ef7a","line":975,"in_reply_to":"bae84128_e57c4cb7","updated":"2016-02-26 01:40:59.000000000","message":"Excellent point, I\u0027ll change it to raise an exception.","commit_id":"943d81cc7b3a129efd515047c6455742d06e9664"}]}