)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/065_add_allocated_id_column_to_reservations.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55b04f1316532cf181693fd9695cfa0c49527c1a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def upgrade(migrate_engine):"},{"line_number":18,"context_line":"    \"\"\"Add replication info to services table.\"\"\""},{"line_number":19,"context_line":"    meta \u003d MetaData()"},{"line_number":20,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_cfd07b56","line":18,"range":{"start_line":18,"start_character":11,"end_line":18,"end_character":22},"updated":"2016-02-26 19:52:14.000000000","message":"This looks like a copy paste failure.","commit_id":"6d6bf99c6319a97b20405b2810f497e2efb18f9d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"79499fc308faf116ad0b02dcc2d51e6001f455a1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                          nullable\u003dTrue)"},{"line_number":26,"context_line":"    reservations.create_column(allocated_id)"},{"line_number":27,"context_line":"    usage_id \u003d reservations.c.usage_id"},{"line_number":28,"context_line":"    usage_id.alter(nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_e704f815","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":33},"updated":"2016-02-24 10:28:38.000000000","message":"According to [1] this should be fine as an exception from our online-schema-upgrades guidelines. It has same constraints as adding a new column which we allow.\n\n[1] https://dev.mysql.com/doc/refman/5.7/en/innodb-create-index-overview.html#innodb-online-ddl-summary-grid","commit_id":"6d6bf99c6319a97b20405b2810f497e2efb18f9d"}],"cinder/quota.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55b04f1316532cf181693fd9695cfa0c49527c1a","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"            # Validate each resource when compared to it\u0027s child quotas"},{"line_number":477,"context_line":"            for resource in cur_project_quotas.keys():"},{"line_number":478,"context_line":"                par_quota \u003d cur_project_quotas[resource]"},{"line_number":479,"context_line":"                parent_limit \u003d par_quota[\u0027limit\u0027]"},{"line_number":480,"context_line":"                parent_usage \u003d par_quota[\u0027in_use\u0027] + par_quota[\u0027reserved\u0027]"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_b2d63c25","line":478,"range":{"start_line":478,"start_character":16,"end_line":478,"end_character":25},"updated":"2016-02-26 19:52:14.000000000","message":"This is a nit, but I am not sure if this is a typo for per_quota or what.  I think this would be more readable as parent_quota to go with the other places here where it is spelled out.","commit_id":"6d6bf99c6319a97b20405b2810f497e2efb18f9d"}],"cinder/tests/unit/api/contrib/test_quotas.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"55b04f1316532cf181693fd9695cfa0c49527c1a","unresolved":false,"context_lines":[{"line_number":518,"context_line":"             self.E.id: 2, self.F.id: 0, self.G.id: 0})"},{"line_number":519,"context_line":"        mock_usage.side_effect \u003d self._fake_quota_usage_get_all_by_project"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        # Setting E-F as children of D for this test case to flex the muscles"},{"line_number":522,"context_line":"        # of more complex nesting"},{"line_number":523,"context_line":"        self.D.subtree \u003d {self.E.id: self.E.subtree}"},{"line_number":524,"context_line":"        self.E.parent_id \u003d self.D.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_1df45985","line":521,"range":{"start_line":521,"start_character":11,"end_line":521,"end_character":34},"updated":"2016-02-26 19:52:14.000000000","message":"I am not seeing F setup below.","commit_id":"6d6bf99c6319a97b20405b2810f497e2efb18f9d"}]}