)]}'
{"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5398a69832f6986279aa41a61c8746f3544f12e2","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        self.assertEqual(11, lun_info[\u0027provider_location\u0027])"},{"line_number":1984,"context_line":""},{"line_number":1985,"context_line":"    def test_delete_snapshot_success(self):"},{"line_number":1986,"context_line":"        self.driver.delete_snapshot(test_snap)"},{"line_number":1987,"context_line":""},{"line_number":1988,"context_line":"    def test_create_volume_from_snapsuccess(self):"},{"line_number":1989,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_097adf87","line":1986,"range":{"start_line":1986,"start_character":20,"end_line":1986,"end_character":35},"updated":"2016-02-24 06:33:26.000000000","message":"Now this test case does not test anything and is always passed. IMO you need to improve it after removing the return statements from delete_snapshot method.","commit_id":"272b4ebb70568d625bc2e8b46c6779271d5bced4"}],"cinder/volume/drivers/huawei/fc_zone_helper.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27f95e481a1b6af3b7d27d53bf94ef6c7e4dff8c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        for port in ports:"},{"line_number":83,"context_line":"            port_weight_map[port] \u003d self._count_port_weight(port, ports_info)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        LOG.debug(\"port_weight_map: %s\", port_weight_map)"},{"line_number":86,"context_line":"        sorted_ports \u003d sorted(port_weight_map.items(), key\u003dlambda d: d[1])"},{"line_number":87,"context_line":"        weighted_ports \u003d []"},{"line_number":88,"context_line":"        count \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_255bff88","line":85,"updated":"2016-02-22 06:22:03.000000000","message":"Not a related change as per the commit message; please update the commit message or remove this change.","commit_id":"bd059bd9af5adaf73c3f8be1cc585f0809262ecb"}],"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27f95e481a1b6af3b7d27d53bf94ef6c7e4dff8c","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            LOG.warning(_LW(\"Can\u0027t find snapshot on the array.\"))"},{"line_number":752,"context_line":"            return False"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        return True"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def retype(self, ctxt, volume, new_type, diff, host):"},{"line_number":757,"context_line":"        \"\"\"Convert the volume to be of the new type.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_65dce7e4","side":"PARENT","line":754,"updated":"2016-02-22 06:22:03.000000000","message":"Unrelated change.","commit_id":"58ad8d3e7e3160e24191f075598751bb799a8709"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"2147b4a1f432e2810b0d5db6169cb176d9f64bbe","unresolved":false,"context_lines":[{"line_number":1659,"context_line":"        if self.fcsan:"},{"line_number":1660,"context_line":"            # Use FC switch."},{"line_number":1661,"context_line":"            host_id \u003d self.client.add_host_with_check(host_name,"},{"line_number":1662,"context_line":"                                                      original_host_name)"},{"line_number":1663,"context_line":"            zone_helper \u003d fc_zone_helper.FCZoneHelper(self.fcsan, self.client)"},{"line_number":1664,"context_line":"            (tgt_port_wwns, portg_id, init_targ_map) \u003d ("},{"line_number":1665,"context_line":"                zone_helper.build_ini_targ_map(wwns, host_id, lun_id))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_2d9b6167","side":"PARENT","line":1662,"range":{"start_line":1662,"start_character":54,"end_line":1662,"end_character":72},"updated":"2016-02-24 11:07:50.000000000","message":"Please add a note to the commit message as to why this is no longer needed","commit_id":"4d7475dba6bebf6d0a15a29e0617fd3d8d13e480"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"2147b4a1f432e2810b0d5db6169cb176d9f64bbe","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"                    if not wwns_in_host and not iqns_in_host:"},{"line_number":1679,"context_line":"                        self.client.remove_host(host_id)"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"                    msg \u003d _(\u0027No FC initiator can be added to host.\u0027)"},{"line_number":1682,"context_line":"                    LOG.error(msg)"},{"line_number":1683,"context_line":"                    raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1684,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4d56a506","line":1681,"range":{"start_line":1681,"start_character":27,"end_line":1681,"end_character":29},"updated":"2016-02-24 11:07:50.000000000","message":"_LE() not _()","commit_id":"6ede7dd103f6e2fa71fd47cd7cf2830307b7db16"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"11c28c37d2a93ddddb8c1fe8903bef2aeffd5dcb","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"                    if not wwns_in_host and not iqns_in_host:"},{"line_number":1679,"context_line":"                        self.client.remove_host(host_id)"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"                    msg \u003d _(\u0027No FC initiator can be added to host.\u0027)"},{"line_number":1682,"context_line":"                    LOG.error(msg)"},{"line_number":1683,"context_line":"                    raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1684,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_bc1793a1","line":1681,"range":{"start_line":1681,"start_character":27,"end_line":1681,"end_character":29},"in_reply_to":"bae84128_4d56a506","updated":"2016-02-24 14:57:18.000000000","message":"LE should only be used when the message is put directly into LOG.error or LOG.exception.\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"6ede7dd103f6e2fa71fd47cd7cf2830307b7db16"}],"cinder/volume/drivers/huawei/huawei_utils.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27f95e481a1b6af3b7d27d53bf94ef6c7e4dff8c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return volume_size"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def get_remote_device_info(valid_hypermetro_devices):"},{"line_number":85,"context_line":"    remote_device_info \u003d {}"},{"line_number":86,"context_line":"    try:"},{"line_number":87,"context_line":"        if valid_hypermetro_devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_a5fd4f3c","line":84,"updated":"2016-02-22 06:22:03.000000000","message":"Unrelated change.","commit_id":"bd059bd9af5adaf73c3f8be1cc585f0809262ecb"}]}