)]}'
{"cinder/volume/drivers/netapp/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8e9314aea3861714f63a07ae50f8733c3e8d3e8d","unresolved":false,"context_lines":[{"line_number":207,"context_line":"          tunnelling."},{"line_number":208,"context_line":"          The vserver or vfiler should be set before this call"},{"line_number":209,"context_line":"          otherwise tunnelling remains disabled."},{"line_number":210,"context_line":"        \"\"\""},{"line_number":211,"context_line":"        result \u003d self.invoke_elem(na_element, enable_tunnelling)"},{"line_number":212,"context_line":"        if result.has_attr(\u0027status\u0027) and result.get_attr(\u0027status\u0027) \u003d\u003d \u0027passed\u0027:"},{"line_number":213,"context_line":"            return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbZQ%3D","line":210,"updated":"2013-05-09 22:31:25.000000000","message":"same nit as other docstring note","commit_id":"34e03fe99b75b32f3f8ad3df17a84f8d5c9f6318"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8e9314aea3861714f63a07ae50f8733c3e8d3e8d","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _enable_tunnel_request(self, netapp_elem):"},{"line_number":238,"context_line":"        \"\"\"Enables vserver or vfiler tunneling."},{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        if hasattr(self, \u0027_vfiler\u0027) and self._vfiler:"},{"line_number":241,"context_line":"            if hasattr(self, \u0027_api_major_version\u0027) and \\"},{"line_number":242,"context_line":"                    hasattr(self, \u0027_api_minor_version\u0027) and \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbZE%3D","line":239,"updated":"2013-05-09 22:31:25.000000000","message":"need to move your closing quotes up after the period of first line.","commit_id":"34e03fe99b75b32f3f8ad3df17a84f8d5c9f6318"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"788f7f43ac1430940c1cc552925fdea65dba6ee8","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _enable_tunnel_request(self, netapp_elem):"},{"line_number":238,"context_line":"        \"\"\"Enables vserver or vfiler tunneling."},{"line_number":239,"context_line":"        \"\"\""},{"line_number":240,"context_line":"        if hasattr(self, \u0027_vfiler\u0027) and self._vfiler:"},{"line_number":241,"context_line":"            if hasattr(self, \u0027_api_major_version\u0027) and \\"},{"line_number":242,"context_line":"                    hasattr(self, \u0027_api_minor_version\u0027) and \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FYg4%3D","line":239,"in_reply_to":"AAAAOn%2F%2FbZE%3D","updated":"2013-05-12 05:55:41.000000000","message":"will move all docstrings in this file to the said place.","commit_id":"34e03fe99b75b32f3f8ad3df17a84f8d5c9f6318"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def set_transport_type(self, transport_type):"},{"line_number":62,"context_line":"        \"\"\"Set the transport type protocol for api."},{"line_number":63,"context_line":"           Supports http and https transport types.\"\"\""},{"line_number":64,"context_line":"        if transport_type.lower() not in ("},{"line_number":65,"context_line":"                NaServer.TRANSPORT_TYPE_HTTP,"},{"line_number":66,"context_line":"                NaServer.TRANSPORT_TYPE_HTTPS):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX4A%3D","line":63,"updated":"2013-05-13 09:07:22.000000000","message":"Still missing newline just after the first line, as per HACKING.rst file.","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def set_style(self, style):"},{"line_number":86,"context_line":"        \"\"\"Set the authorization style for communicating with the server."},{"line_number":87,"context_line":"           Supports basic_auth for now."},{"line_number":88,"context_line":"           Certificate_auth mode to be done.\"\"\""},{"line_number":89,"context_line":"        if style.lower() not in (NaServer.STYLE_LOGIN_PASSWORD,"},{"line_number":90,"context_line":"                                 NaServer.STYLE_CERTIFICATE):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX34%3D","line":87,"updated":"2013-05-13 09:07:22.000000000","message":"Still missing newline just after the first line, as per HACKING.rst file.","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def set_server_type(self, server_type):"},{"line_number":99,"context_line":"        \"\"\"Set the target server type."},{"line_number":100,"context_line":"           Supports filer and dfm server types.\"\"\""},{"line_number":101,"context_line":"        if server_type.lower() not in (NaServer.SERVER_TYPE_FILER,"},{"line_number":102,"context_line":"                                       NaServer.SERVER_TYPE_DFM):"},{"line_number":103,"context_line":"            raise ValueError(\u0027Unsupported server type\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX30%3D","line":100,"updated":"2013-05-13 09:07:22.000000000","message":"Still missing newline just after the first line, as per HACKING.rst file.","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def invoke_successfully(self, na_element, enable_tunnelling\u003dFalse):"},{"line_number":201,"context_line":"        \"\"\"Invokes api and checks execution status as success."},{"line_number":202,"context_line":"          Need to set enable_tunnelling to True explicitly to achieve it."},{"line_number":203,"context_line":"          This helps to use same connection instance to enable or disable"},{"line_number":204,"context_line":"          tunnelling."},{"line_number":205,"context_line":"          The vserver or vfiler should be set before this call"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX3w%3D","line":202,"updated":"2013-05-13 09:07:22.000000000","message":"Still missing newline just after the first line, as per HACKING.rst file.","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"}],"cinder/volume/drivers/netapp/iscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8e9314aea3861714f63a07ae50f8733c3e8d3e8d","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"    def _map_lun(self, name, initiator, initiator_type\u003d\u0027iscsi\u0027, lun_id\u003dNone):"},{"line_number":1788,"context_line":"        \"\"\"Maps lun to the initiator."},{"line_number":1789,"context_line":"           Returns lun id assigned."},{"line_number":1790,"context_line":"        \"\"\""},{"line_number":1791,"context_line":"        metadata \u003d self._get_lun_attr(name, \u0027metadata\u0027)"},{"line_number":1792,"context_line":"        os \u003d metadata[\u0027OsType\u0027]"},{"line_number":1793,"context_line":"        path \u003d metadata[\u0027Path\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbZg%3D","line":1790,"updated":"2013-05-09 22:31:25.000000000","message":"same note about docstrings as in iscsi file.","commit_id":"34e03fe99b75b32f3f8ad3df17a84f8d5c9f6318"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"deafc268e357256699e7e5a5aabbafe9217a0783","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"        \"\"\"Does custom setup for ontap cluster.\"\"\""},{"line_number":1962,"context_line":"        self.vserver \u003d self.configuration.netapp_vserver"},{"line_number":1963,"context_line":"        # We set vserver in client permanently."},{"line_number":1964,"context_line":"        # To use tunnelling enable_tunneling while invoking api"},{"line_number":1965,"context_line":"        self.client.set_vserver(self.vserver)"},{"line_number":1966,"context_line":"        # Default values to run first api"},{"line_number":1967,"context_line":"        self.client.set_api_version(1, 15)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAO3%2F%2F%2F6o%3D","line":1964,"updated":"2013-05-15 06:28:49.000000000","message":"/tunnelling/tunneling/","commit_id":"86e26ab11d1ffc736a562eda061bf627247c6844"},{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"b6e114c0ae1fe6e61afc6a9c090a43ad0cc88454","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"        \"\"\"Does custom setup for ontap cluster.\"\"\""},{"line_number":1962,"context_line":"        self.vserver \u003d self.configuration.netapp_vserver"},{"line_number":1963,"context_line":"        # We set vserver in client permanently."},{"line_number":1964,"context_line":"        # To use tunnelling enable_tunneling while invoking api"},{"line_number":1965,"context_line":"        self.client.set_vserver(self.vserver)"},{"line_number":1966,"context_line":"        # Default values to run first api"},{"line_number":1967,"context_line":"        self.client.set_api_version(1, 15)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAO3%2F%2F%2F3w%3D","line":1964,"in_reply_to":"AAAAO3%2F%2F%2F6o%3D","updated":"2013-05-15 07:09:33.000000000","message":"Fixed the spelling. Also multi doc strings corrected.","commit_id":"86e26ab11d1ffc736a562eda061bf627247c6844"}],"cinder/volume/drivers/netapp/nfs.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8e9314aea3861714f63a07ae50f8733c3e8d3e8d","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        \"\"\"Invoke the api for successful result."},{"line_number":403,"context_line":"           Vserver implies vserver/vfiler api else filer/Cluster api."},{"line_number":404,"context_line":"           Represents vserver/vfiler name."},{"line_number":405,"context_line":"        \"\"\""},{"line_number":406,"context_line":"        self._is_naelement(na_element)"},{"line_number":407,"context_line":"        server \u003d copy.copy(self._client)"},{"line_number":408,"context_line":"        if vserver:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbZk%3D","line":405,"updated":"2013-05-09 22:31:25.000000000","message":"Docstring formatting needs some work here.  Multi-line docstrings as per HACKING.rst:\n\n  \"\"\"A multi line docstring has a one-line summary, less than 80 characters.\n                                                                                                                                    \n  Then a new paragraph after a newline that explains in more detail any\n  general information about the function, class or method. Example usages\n  are also great to have here if it is a complex class for function.\n\n  When writing the docstring for a class, an extra line should be placed\n  after the closing quotations. For more in-depth explanations for these\n  decisions see http://www.python.org/dev/peps/pep-0257/\n\n  If you are going to describe parameters and return values, use Sphinx, the\n  appropriate syntax is as follows.\n\n  :param foo: the foo parameter\n  :param bar: the bar parameter\n  :returns: return_type -- description of the return value\n  :returns: description of the return value\n  :raises: AttributeError, KeyError\n  \"\"\"","commit_id":"34e03fe99b75b32f3f8ad3df17a84f8d5c9f6318"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            raise ValueError(\u0027Expects NaElement\u0027)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _invoke_successfully(self, na_element, vserver\u003dNone):"},{"line_number":402,"context_line":"        \"\"\"Invoke the api for successful result."},{"line_number":403,"context_line":"           Vserver implies vserver/vfiler api else filer/Cluster api."},{"line_number":404,"context_line":"           Represents vserver/vfiler name."},{"line_number":405,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX3k%3D","line":402,"updated":"2013-05-13 09:07:22.000000000","message":"Still missing newline just after the first line, as per HACKING.rst file.","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"449b67e457f7412328493536e3c68cc2f43c8e75","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _invoke_successfully(self, na_element, vserver\u003dNone):"},{"line_number":402,"context_line":"        \"\"\"Invoke the api for successful result."},{"line_number":403,"context_line":"           Vserver implies vserver/vfiler api else filer/Cluster api."},{"line_number":404,"context_line":"           Represents vserver/vfiler name."},{"line_number":405,"context_line":"        \"\"\""},{"line_number":406,"context_line":"        self._is_naelement(na_element)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FX3g%3D","line":403,"updated":"2013-05-13 09:07:22.000000000","message":"Can use sphinx syntax for explaining method parameters","commit_id":"b9250654490fd6b0863613163138dd3f4823f5e5"}]}
