)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"9c84d369b941857146f0240590e2c20dee37e1a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Check before delete host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we delete the host without checking"},{"line_number":10,"context_line":"whether the host is already belonged to a host"},{"line_number":11,"context_line":"group. Now we will fix this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closed-Bug: #1548183"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_c83abce6","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":39},"updated":"2016-02-24 01:42:27.000000000","message":"s/already belonged to/already belongs to","commit_id":"041d56a41d17d96d0ac222a72d6c6b5d2ce5b9e4"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"9c84d369b941857146f0240590e2c20dee37e1a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Check before delete host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we delete the host without checking"},{"line_number":10,"context_line":"whether the host is already belonged to a host"},{"line_number":11,"context_line":"group. Now we will fix this."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closed-Bug: #1548183"},{"line_number":14,"context_line":"Change-Id: Ibfa0bb4930e6d932c332aacb19ae81f9daad55ce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_c3a73d09","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":28},"updated":"2016-02-24 01:42:27.000000000","message":"Will you give more details of the bug and the fix here? Why the host belongs to the host group here matters?","commit_id":"041d56a41d17d96d0ac222a72d6c6b5d2ce5b9e4"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f0646fb33f567ad9cac252110b387413faaf1a0b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently we delete the host without checking"},{"line_number":10,"context_line":"whether the host already belongs to a host"},{"line_number":11,"context_line":"group. If a host already belongs to a hostgroup,"},{"line_number":12,"context_line":"a error will occur. So we should do the check"},{"line_number":13,"context_line":"before delete it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closed-Bug: #1548183"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7af24918_a9739ae6","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2016-03-06 14:33:26.000000000","message":"s/a/an","commit_id":"1ef32b9bf4e650d378e8219bee399a575fa42692"}],"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"9c84d369b941857146f0240590e2c20dee37e1a2","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                    iqns_in_host \u003d ("},{"line_number":1681,"context_line":"                        self.client.get_host_iscsi_initiators(host_id))"},{"line_number":1682,"context_line":"                    if not (wwns_in_host or iqns_in_host or"},{"line_number":1683,"context_line":"                       self.client.is_host_associated_to_hostgroup(host_id)):"},{"line_number":1684,"context_line":"                        self.client.remove_host(host_id)"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"                    msg \u003d _(\u0027Can not add FC initiator to host.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_43ededb5","line":1683,"range":{"start_line":1683,"start_character":35,"end_line":1683,"end_character":66},"updated":"2016-02-24 01:42:27.000000000","message":"It\u0027s in an exception raising path. If we won\u0027t have the fix, what will happen?","commit_id":"041d56a41d17d96d0ac222a72d6c6b5d2ce5b9e4"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"88cf8dee094caf267999b95f1d83ffcb49954c92","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        if data:"},{"line_number":2097,"context_line":"            return data[\u0027ISADD2HOSTGROUP\u0027] \u003d\u003d \u0027true\u0027"},{"line_number":2098,"context_line":""},{"line_number":2099,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_fe05c879","line":2099,"updated":"2016-02-23 18:49:39.000000000","message":"So if the result doesn\u0027t have \u0027data\u0027 in it, you are going to default the return to True.  This means that you can\u0027t remove the host ?  Shouldn\u0027t this return False, because it didn\u0027t find it, and hence it\u0027s not part of the hostgroup?","commit_id":"041d56a41d17d96d0ac222a72d6c6b5d2ce5b9e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7e8903e6a4c70a0a7ac0984e380febc68279e015","unresolved":false,"context_lines":[{"line_number":2098,"context_line":"    def is_host_associated_to_hostgroup(self, host_id):"},{"line_number":2099,"context_line":"        url \u003d \"/host/\" + host_id"},{"line_number":2100,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":2101,"context_line":"        data \u003d result.get(\u0027data\u0027)"},{"line_number":2102,"context_line":"        return data.get(\u0027ISADD2HOSTGROUP\u0027) \u003d\u003d \u0027true\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_59226f01","line":2101,"updated":"2016-03-08 18:38:50.000000000","message":"-1: Next line will crash with a unhelpful error if there is an error and there is no \u0027data\u0027...","commit_id":"1ef32b9bf4e650d378e8219bee399a575fa42692"}]}