)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"e5c654fe73eb7d154a7ee96a7022627a2e8e5579","unresolved":false,"context_lines":[{"line_number":391,"context_line":"            return LegacyPayloadFilter(filterType)"},{"line_number":392,"context_line":"        return PayloadFilter(filterType)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def login(self, apiver):"},{"line_number":395,"context_line":"        payload \u003d {}"},{"line_number":396,"context_line":"        payload[\u0027Application\u0027] \u003d \u0027Cinder REST Driver\u0027"},{"line_number":397,"context_line":"        if apiver:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_3cc12655","line":394,"range":{"start_line":394,"start_character":20,"end_line":394,"end_character":26},"updated":"2016-02-23 02:31:49.000000000","message":"Maybe this is better?\ndef login(self, apiver\u003dNone)\nAnd then in line 413, you can just use \"r \u003d self.login()\".","commit_id":"2883ae2ec47d1260e9a22de43ea7ca311971048d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c7b79f2d9aa8cabe587b506160ad4b92e72fbb04","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        2.3.1 - Updated error handling."},{"line_number":210,"context_line":"        2.4.0 - Added Replication V2 support."},{"line_number":211,"context_line":"    \"\"\""},{"line_number":212,"context_line":"    APIVERSION \u003d \u00272.4.0\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    RESTAPIVERSION \u003d \u00272.0\u0027"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_4b6e0696","line":212,"updated":"2016-03-02 17:08:08.000000000","message":"Let\u0027s rename this to something more accurate: APPLICATION_VERSION?","commit_id":"680ce7cbb444a2608ac1e13a372a33ceb7cf9733"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"b078d7158276cffd9b5d58ec2f54f1cbdfdeaeb9","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        2.3.1 - Updated error handling."},{"line_number":210,"context_line":"        2.4.0 - Added Replication V2 support."},{"line_number":211,"context_line":"    \"\"\""},{"line_number":212,"context_line":"    APIVERSION \u003d \u00272.4.0\u0027"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    RESTAPIVERSION \u003d \u00272.0\u0027"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_a6489f88","line":212,"in_reply_to":"7af24918_4b6e0696","updated":"2016-03-02 17:22:29.000000000","message":"It is the version of the API driver.","commit_id":"680ce7cbb444a2608ac1e13a372a33ceb7cf9733"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"150b2322a685fc153c229d1d36e138d213abd62a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    \"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    APIDRIVERVERSION \u003d \u00272.4.0\u0027"},{"line_number":223,"context_line":"    apiversion \u003d \u00272.0\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, host, port, user, password, verify, apiversion):"},{"line_number":226,"context_line":"        \"\"\"This creates a connection to Dell SC or EM."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_4a50205f","line":223,"updated":"2016-03-04 22:50:25.000000000","message":"Is this one ever used? Maybe I\u0027m missing it, but it looks like the apiversion is always passed in at init.","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"76ae623e303dd7ac893c4356cd624161597460be","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    \"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    APIDRIVERVERSION \u003d \u00272.4.0\u0027"},{"line_number":223,"context_line":"    apiversion \u003d \u00272.0\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, host, port, user, password, verify, apiversion):"},{"line_number":226,"context_line":"        \"\"\"This creates a connection to Dell SC or EM."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_6a76bcd9","line":223,"in_reply_to":"7af24918_4a50205f","updated":"2016-03-04 22:57:07.000000000","message":"It absolutely is never used.  But without it I can\u0027t get the unit tests to pass.  So, yeah.  Any ideas?","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"b02bf5014794d6ee3b2da978f4dc931d8cda2bf9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    \"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    APIDRIVERVERSION \u003d \u00272.4.0\u0027"},{"line_number":223,"context_line":"    apiversion \u003d \u00272.0\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, host, port, user, password, verify, apiversion):"},{"line_number":226,"context_line":"        \"\"\"This creates a connection to Dell SC or EM."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_ac1c61c2","line":223,"in_reply_to":"7af24918_6a76bcd9","updated":"2016-03-05 00:05:49.000000000","message":"Hmm I think its because the __init__ method on the api object is being mocked out so the self.x variables aren\u0027t being set.","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"664908d7261f96a6d24dfe0d4d49d7e24cbc90ab","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    \"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    APIDRIVERVERSION \u003d \u00272.4.0\u0027"},{"line_number":223,"context_line":"    apiversion \u003d \u00272.0\u0027"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def __init__(self, host, port, user, password, verify, apiversion):"},{"line_number":226,"context_line":"        \"\"\"This creates a connection to Dell SC or EM."}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_761a0619","line":223,"in_reply_to":"7af24918_ac1c61c2","updated":"2016-03-07 06:09:31.000000000","message":"Yep.","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"150b2322a685fc153c229d1d36e138d213abd62a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                        \u0027the version must be in the range [\u0027):"},{"line_number":407,"context_line":"                # We\u0027re looking for something very specific. The except"},{"line_number":408,"context_line":"                # will catch any errors."},{"line_number":409,"context_line":"                # Update our version and update our header."},{"line_number":410,"context_line":"                self.apiversion \u003d response.text.split(\u0027[\u0027)[1].split(\u0027,\u0027)[0]"},{"line_number":411,"context_line":"                self.client.header[\u0027x-dell-api-version\u0027] \u003d self.apiversion"},{"line_number":412,"context_line":"                LOG.debug(\u0027API version updated to %s\u0027, self.apiversion)"},{"line_number":413,"context_line":"                # Give login another go."},{"line_number":414,"context_line":"                r \u003d self.client.post(\u0027ApiConnection/Login\u0027, payload)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_eadbec1f","line":411,"range":{"start_line":409,"start_character":16,"end_line":411,"end_character":74},"updated":"2016-03-04 22:50:25.000000000","message":"Not sure exactly how your API versioning works, so maybe nothing worth worrying about, but is this safe to do? Is there some kind of guarantee that the version the server gives back is something that the driver code knows how to deal with?","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"b02bf5014794d6ee3b2da978f4dc931d8cda2bf9","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                        \u0027the version must be in the range [\u0027):"},{"line_number":407,"context_line":"                # We\u0027re looking for something very specific. The except"},{"line_number":408,"context_line":"                # will catch any errors."},{"line_number":409,"context_line":"                # Update our version and update our header."},{"line_number":410,"context_line":"                self.apiversion \u003d response.text.split(\u0027[\u0027)[1].split(\u0027,\u0027)[0]"},{"line_number":411,"context_line":"                self.client.header[\u0027x-dell-api-version\u0027] \u003d self.apiversion"},{"line_number":412,"context_line":"                LOG.debug(\u0027API version updated to %s\u0027, self.apiversion)"},{"line_number":413,"context_line":"                # Give login another go."},{"line_number":414,"context_line":"                r \u003d self.client.post(\u0027ApiConnection/Login\u0027, payload)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_ec15c99b","line":411,"range":{"start_line":409,"start_character":16,"end_line":411,"end_character":74},"in_reply_to":"7af24918_8a2b4894","updated":"2016-03-05 00:05:49.000000000","message":"Ok, cool, sounds like its non-issue :)","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"76ae623e303dd7ac893c4356cd624161597460be","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                                        \u0027the version must be in the range [\u0027):"},{"line_number":407,"context_line":"                # We\u0027re looking for something very specific. The except"},{"line_number":408,"context_line":"                # will catch any errors."},{"line_number":409,"context_line":"                # Update our version and update our header."},{"line_number":410,"context_line":"                self.apiversion \u003d response.text.split(\u0027[\u0027)[1].split(\u0027,\u0027)[0]"},{"line_number":411,"context_line":"                self.client.header[\u0027x-dell-api-version\u0027] \u003d self.apiversion"},{"line_number":412,"context_line":"                LOG.debug(\u0027API version updated to %s\u0027, self.apiversion)"},{"line_number":413,"context_line":"                # Give login another go."},{"line_number":414,"context_line":"                r \u003d self.client.post(\u0027ApiConnection/Login\u0027, payload)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_8a2b4894","line":411,"range":{"start_line":409,"start_character":16,"end_line":411,"end_character":74},"in_reply_to":"7af24918_eadbec1f","updated":"2016-03-04 22:57:07.000000000","message":"Right now we work with all existing versions.  Below you can see where we check against 2.0, 2.1 and 2.2.  2.2 and later are, at the moment all the same in regards to the functions used by this driver.  If we have to make changes to how the driver handles things we will do that on the return to this call.  That\u0027s the bit that tells us what API we are talking to.","commit_id":"75a8da580320506cf9aaf393b9429f215894df4b"}]}