)]}'
{"cinder/volume/drivers/huawei/hypermetro.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"2b0e7908d1395aaee38ed7fa87361898c5e0fd9e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        map_info \u003d self.rmt_client.do_mapping(lun_id,"},{"line_number":163,"context_line":"                                              hostgroup_id,"},{"line_number":164,"context_line":"                                              host_id)"},{"line_number":165,"context_line":"        if map_info \u003d\u003d {}:"},{"line_number":166,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":167,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":168,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_475e3dea","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":25},"updated":"2016-02-26 08:34:40.000000000","message":"Will it be better?\n       if not map_info:","commit_id":"242d414112abf88ba35636722bec9a3774fc1b1c"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"73bbab8dacb2277cef46e50eb1770258799e1356","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        map_info \u003d self.rmt_client.do_mapping(lun_id,"},{"line_number":163,"context_line":"                                              hostgroup_id,"},{"line_number":164,"context_line":"                                              host_id)"},{"line_number":165,"context_line":"        if map_info \u003d\u003d {}:"},{"line_number":166,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":167,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":168,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_d345b870","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":25},"in_reply_to":"9aed3d3a_475e3dea","updated":"2016-02-27 01:34:55.000000000","message":"Done","commit_id":"242d414112abf88ba35636722bec9a3774fc1b1c"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"2b0e7908d1395aaee38ed7fa87361898c5e0fd9e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":167,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        host_lun_id \u003d self.rmt_client.get_host_lun_id(host_id, lun_id)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_a7f629d5","line":169,"range":{"start_line":169,"start_character":18,"end_line":169,"end_character":27},"updated":"2016-02-26 08:34:40.000000000","message":"Should a unit test be needed for the exception raising?","commit_id":"242d414112abf88ba35636722bec9a3774fc1b1c"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"73bbab8dacb2277cef46e50eb1770258799e1356","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":167,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        host_lun_id \u003d self.rmt_client.get_host_lun_id(host_id, lun_id)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_b348f488","line":169,"range":{"start_line":169,"start_character":18,"end_line":169,"end_character":27},"in_reply_to":"9aed3d3a_a7f629d5","updated":"2016-02-27 01:34:55.000000000","message":"Done","commit_id":"242d414112abf88ba35636722bec9a3774fc1b1c"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"b2bf276c00d4fc231cde75a1af4cef4ac7287db7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                              host_id)"},{"line_number":170,"context_line":"        if not map_info:"},{"line_number":171,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":172,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":173,"context_line":"            LOG.error(msg)"},{"line_number":174,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_578536ab","line":172,"range":{"start_line":172,"start_character":25,"end_line":172,"end_character":32},"updated":"2016-03-14 03:12:39.000000000","message":"support -\u003e supporting\n\nsuper minor though, nothing worth blocking the patch","commit_id":"9427d9b3060bf136ab66e0e8c744950364f064d9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1375df251b0d2a1eba0cb9abfe0118385cbfa89d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                              host_id)"},{"line_number":170,"context_line":"        if not map_info:"},{"line_number":171,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":172,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":173,"context_line":"            LOG.error(msg)"},{"line_number":174,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_497d8f1b","line":172,"range":{"start_line":172,"start_character":25,"end_line":172,"end_character":32},"in_reply_to":"3afc51ec_578536ab","updated":"2016-03-14 11:37:21.000000000","message":"-1: This message looks like could be improved: \"Array version doesn\u0027t support hypermetro (Empty Map info)\" or something like that may be more readable.\n\nNormally I wouldn\u0027t downvote for something like this, but since this is the whole reason for the patch I think it\u0027s worth fixing.\n\nI\u0027d be fine with Patrick\u0027s suggestion as well.","commit_id":"9427d9b3060bf136ab66e0e8c744950364f064d9"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"7e59132371c58084c55fcfac218ba01770732620","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                                              host_id)"},{"line_number":170,"context_line":"        if not map_info:"},{"line_number":171,"context_line":"            msg \u003d _(\u0027Map info is None due to array version \u0027"},{"line_number":172,"context_line":"                    \u0027not support hypermetro.\u0027)"},{"line_number":173,"context_line":"            LOG.error(msg)"},{"line_number":174,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_9bcdee5f","line":172,"range":{"start_line":172,"start_character":25,"end_line":172,"end_character":32},"in_reply_to":"3afc51ec_578536ab","updated":"2016-03-15 03:10:58.000000000","message":"When the array does not support Hypermetro, we does not know the reason by log, so we add this.","commit_id":"9427d9b3060bf136ab66e0e8c744950364f064d9"}]}