)]}'
{"cinder/volume/drivers/nexenta/volume.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"07a18a9dc64cd945579ea205840b113e7c97c2e7","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        MB \u003d KB ** 2"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":318,"context_line":"        data \u003d {}"},{"line_number":319,"context_line":"        backend_name \u003d self.__class__.__name__"},{"line_number":320,"context_line":"        if self.configuration:"},{"line_number":321,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff8Q%3D","line":318,"updated":"2013-05-07 18:38:51.000000000","message":"See my comment in the code changes for the \"sheepdog\" driver.  It seems to me that it would be clearer to try the self.configuration and then set backend_name if it didn\u0027t come out of the configuration.","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"380d49b8ad8fcedf366724a9f8312f659669ee9f","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        MB \u003d KB ** 2"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":318,"context_line":"        data \u003d {}"},{"line_number":319,"context_line":"        backend_name \u003d self.__class__.__name__"},{"line_number":320,"context_line":"        if self.configuration:"},{"line_number":321,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff7U%3D","line":318,"in_reply_to":"AAAAOn%2F%2Ff8Q%3D","updated":"2013-05-07 19:01:59.000000000","message":"This is the same issue as the sheepdog code.  It\u0027s an artifact of self.configuration not existing for the unit tests.","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"}],"cinder/volume/drivers/sheepdog.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"07a18a9dc64cd945579ea205840b113e7c97c2e7","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _update_volume_stats(self):"},{"line_number":112,"context_line":"        stats \u003d {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        backend_name \u003d \"sheepdog\""},{"line_number":115,"context_line":"        if self.configuration:"},{"line_number":116,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff8k%3D","line":113,"updated":"2013-05-07 18:38:51.000000000","message":"Perhaps this is just a stylistic thing, but this approach is a little confusing to me.  Why are you setting the backend_name before trying self.configuration.  I see that we need to try backend_name or \u0027sheepdog\u0027 because there could be configuration data that doesn\u0027t include volume_backend_name, we need to catch that case.  Wouldn\u0027t it, however, be more straightforward to try self.configuration and at that point if backend_name is not set set it to \"sheepdog\"  Then you can just do:\nstats[\"volume_backend_name\"] \u003d backend_name\n\nThat would be much easier to read.","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0d9c3cf112b49f40114d6b38f16239ed02f27192","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _update_volume_stats(self):"},{"line_number":112,"context_line":"        stats \u003d {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        backend_name \u003d \"sheepdog\""},{"line_number":115,"context_line":"        if self.configuration:"},{"line_number":116,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff5E%3D","line":113,"in_reply_to":"AAAAOn%2F%2Ff5k%3D","updated":"2013-05-07 19:31:20.000000000","message":"So I\u0027m not sure technically what the difference between the two proposals is here?  granted, we\u0027re setting backend_name on 114 which is somewhat pointless.\n\nThe other side of the coin here is that this is the backport and as such we don\u0027t want to be diverging from what the original patch to master did.  Right or wrong.  If the issue is valid enough to say that the patch shouldn\u0027t go in as it is because it introduces a problem or is blatantly wrong that\u0027s one thing.  I don\u0027t think that\u0027s the case here, so I think the patch should go in as is and maintain alignment with the change set in master.","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cf92cb9ca32547a4464ec09ac62498030430ce53","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _update_volume_stats(self):"},{"line_number":112,"context_line":"        stats \u003d {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        backend_name \u003d \"sheepdog\""},{"line_number":115,"context_line":"        if self.configuration:"},{"line_number":116,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff5k%3D","line":113,"in_reply_to":"AAAAOn%2F%2Ff7Y%3D","updated":"2013-05-07 19:21:02.000000000","message":"I must be missing something here.  So you can\u0027t do:\n\nif self.configuration:\n    backend_name \u003d\n        self.configuration.safe_get(\u0027volume_backend_name\u0027)\nif backend_name is None:\n    backend_name \u003d \u0027sheepdog\u0027\nstats[\"volume_backend_name\"] \u003d backend_name","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"380d49b8ad8fcedf366724a9f8312f659669ee9f","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _update_volume_stats(self):"},{"line_number":112,"context_line":"        stats \u003d {}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        backend_name \u003d \"sheepdog\""},{"line_number":115,"context_line":"        if self.configuration:"},{"line_number":116,"context_line":"            backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff7Y%3D","line":113,"in_reply_to":"AAAAOn%2F%2Ff8k%3D","updated":"2013-05-07 19:01:59.000000000","message":"This is an artifact of the unit tests.  self.configuration doesn\u0027t exist for this driver when I ran the unit tests, so I had to initialize backend_name to something.","commit_id":"995a3100fcaa7eb445b2838c4b4799a482c817cc"}]}