)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"888473fd3863b00283cf025aa9b1c8482f0831b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use assert(Not)Equal(A, B) instead of assertTrue/False(A * B)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using assertFalse(A * B) / assertTrue(A * B), developers should"},{"line_number":10,"context_line":"use assertEqual(A, B) or assertNotEqual(A, B)."},{"line_number":11,"context_line":"The * operator: \u0027\u003d\u003d\u0027 and \u0027!\u003d\u0027"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aed3d3a_dc1e0e6f","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":74},"updated":"2016-02-29 22:11:19.000000000","message":"Body lines should be wrapped at 72 characters. Thanks! \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"d3bf18b42849782b46496bf517ab7fae3f383f6c"}],"cinder/tests/unit/api/openstack/test_api_version_request.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertEqual(v1, v4)"},{"line_number":96,"context_line":"        self.assertNotEqual(v1, v_null)"},{"line_number":97,"context_line":"        self.assertEqual(v_null, v_null)"},{"line_number":98,"context_line":"        self.assertNotEqual(v1, \u00272.0\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_version_matches(self):"},{"line_number":101,"context_line":"        v1 \u003d api_version_request.APIVersionRequest(\u00272.0\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_b208212f","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":38},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order, use \"expected, observed\".","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"}],"cinder/tests/unit/backup/drivers/test_backup_google.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acbc8a24bad1089ee67837e473521925eb769863","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        result \u003d service._prepare_output_data(fake_data)"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        self.assertEqual(\u0027zlib\u0027, result[0])"},{"line_number":543,"context_line":"        self.assertLess(len(result), len(fake_data))"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @gcs_client"},{"line_number":546,"context_line":"    def test_prepare_output_data_no_compresssion(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_4ddca212","line":543,"range":{"start_line":543,"start_character":0,"end_line":543,"end_character":52},"updated":"2016-07-04 15:22:07.000000000","message":"expected, observed","commit_id":"04437b04a15000d2ac43486f6407d8838f36ec3a"}],"cinder/tests/unit/backup/drivers/test_backup_nfs.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f3787b6cfb95b0bd7aec81f638333bb26df488ae","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        result \u003d service._prepare_output_data(fake_data)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        self.assertEqual(\u0027zlib\u0027, result[0])"},{"line_number":637,"context_line":"        self.assertLess(len(result), len(fake_data))"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def test_prepare_output_data_no_compresssion(self):"},{"line_number":640,"context_line":"        self.flags(backup_compression_algorithm\u003d\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_d05aec82","line":637,"updated":"2016-07-04 13:58:17.000000000","message":"If you do another update, please swap \"result\" and \"fake_data\" so it\u0027s in the (expected, actual) argument order. That\u0027s such a trivial nit though, so don\u0027t change it unless there is need for some other update.","commit_id":"8fab6084145c64b4f43d411fbbfb9712504361a7"}],"cinder/tests/unit/backup/drivers/test_backup_swift.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f3787b6cfb95b0bd7aec81f638333bb26df488ae","unresolved":false,"context_lines":[{"line_number":811,"context_line":"        result \u003d service._prepare_output_data(fake_data)"},{"line_number":812,"context_line":""},{"line_number":813,"context_line":"        self.assertEqual(\u0027zlib\u0027, result[0])"},{"line_number":814,"context_line":"        self.assertLess(len(result), len(fake_data))"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def test_prepare_output_data_no_compresssion(self):"},{"line_number":817,"context_line":"        self.flags(backup_compression_algorithm\u003d\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_b0d640c3","line":814,"updated":"2016-07-04 13:58:17.000000000","message":"Same as last file.","commit_id":"8fab6084145c64b4f43d411fbbfb9712504361a7"}],"cinder/tests/unit/keymgr/test_key.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def test___eq__(self):"},{"line_number":56,"context_line":"        self.assertEqual(self.key, self.key)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.assertFalse(self.key is None)"},{"line_number":59,"context_line":"        self.assertIsNotNone(self.key)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test___ne__(self):"},{"line_number":62,"context_line":"        self.assertEqual(self.key, self.key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_52627517","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":38},"updated":"2016-02-25 11:08:42.000000000","message":"This was supposed to check more, also the, possibly overloaded, comparison operator. You\u0027ve changed the logic here.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test___ne__(self):"},{"line_number":62,"context_line":"        self.assertEqual(self.key, self.key)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.assertTrue(self.key is not None)"},{"line_number":65,"context_line":"        self.assertIsNotNone(self.key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_727179e0","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":38},"updated":"2016-02-25 11:08:42.000000000","message":"ditto","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b4196dddfe9e95f35ffe47ecd87b0f155117dabd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertFalse(None \u003d\u003d self.key)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test___ne__(self):"},{"line_number":62,"context_line":"        self.assertEqual(self.key, self.key)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.assertTrue(self.key is not None)"},{"line_number":65,"context_line":"        self.assertTrue(None !\u003d self.key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_943066a0","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":44},"updated":"2016-02-25 12:08:48.000000000","message":"This isn\u0027t an equivalent when __ne__ is overloaded [1].\n\n[1] http://stackoverflow.com/questions/4352244/python-implementing-ne-operator-based-on-eq","commit_id":"a46b6276218aeba7aaf0c66b2e953b46d2bb1528"}],"cinder/tests/unit/test_backup_ceph.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"        def mock_read(*args):"},{"line_number":1134,"context_line":"            called.append(\u0027read\u0027)"},{"line_number":1135,"context_line":"            self.assertEqual(len(obj_data), 1)"},{"line_number":1136,"context_line":"            return obj_data[0]"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        def _mock_write(data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2d2af67e","line":1135,"range":{"start_line":1135,"start_character":12,"end_line":1135,"end_character":46},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"}],"cinder/tests/unit/test_dothill.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                     RequestException(\"error\")]"},{"line_number":187,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":188,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":189,"context_line":"        self.assertEqual(type(ret), etree._Element)"},{"line_number":190,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":191,"context_line":"                          self.client._request,"},{"line_number":192,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_cd39cada","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":51},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"6252323de66b663f18b8fcf4d983867d91eea9a3","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                                     RequestException(\"error\")]"},{"line_number":187,"context_line":"        mock_requests_get.return_value \u003d m"},{"line_number":188,"context_line":"        ret \u003d self.client._request(\u0027/path\u0027)"},{"line_number":189,"context_line":"        self.assertEqual(etree._Element, type(ret))"},{"line_number":190,"context_line":"        self.assertRaises(exception.DotHillConnectionError,"},{"line_number":191,"context_line":"                          self.client._request,"},{"line_number":192,"context_line":"                          \u0027/path\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_94ec35bc","line":189,"updated":"2016-03-04 11:04:15.000000000","message":"I think we can use assertIsInstance here.","commit_id":"6f66680bad0567f5020964d55fb8b48a7fca348b"}],"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"                conn, self.data.initiatorNames, self.data.storage_system))"},{"line_number":2646,"context_line":"        # The hardware id list has not been found as it has been removed"},{"line_number":2647,"context_line":"        # externally."},{"line_number":2648,"context_line":"        self.assertEqual(len(foundHardwareIdInstanceNames2), 0)"},{"line_number":2649,"context_line":""},{"line_number":2650,"context_line":"    # Bug 1393555 - controller has been deleted by another process."},{"line_number":2651,"context_line":"    def test_find_lunmasking_scsi_protocol_controller(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ad3606e5","line":2648,"range":{"start_line":2648,"start_character":8,"end_line":2648,"end_character":63},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":6464,"context_line":""},{"line_number":6465,"context_line":"        arrayInfo \u003d self.driver.utils.parse_file_to_get_array_map("},{"line_number":6466,"context_line":"            self.config_file_path)"},{"line_number":6467,"context_line":"        self.assertEqual(len(arrayInfo), 2)"},{"line_number":6468,"context_line":"        for arrayInfoRec in arrayInfo:"},{"line_number":6469,"context_line":"            self.assertEqual("},{"line_number":6470,"context_line":"                \u00271234567891011\u0027, arrayInfoRec[\u0027SerialNumber\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0d3452dc","line":6467,"range":{"start_line":6467,"start_character":8,"end_line":6467,"end_character":43},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":6752,"context_line":""},{"line_number":6753,"context_line":"        arrayInfo \u003d self.driver.utils.parse_file_to_get_array_map("},{"line_number":6754,"context_line":"            self.config_file_path)"},{"line_number":6755,"context_line":"        self.assertEqual(len(arrayInfo), 2)"},{"line_number":6756,"context_line":"        for arrayInfoRec in arrayInfo:"},{"line_number":6757,"context_line":"            self.assertEqual("},{"line_number":6758,"context_line":"                \u00271234567891011\u0027, arrayInfoRec[\u0027SerialNumber\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8d56a204","line":6755,"range":{"start_line":6755,"start_character":8,"end_line":6755,"end_character":43},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":7083,"context_line":"        pool \u003d \u0027gold+1234567891011\u0027"},{"line_number":7084,"context_line":"        arrayInfo \u003d self.driver.utils.parse_file_to_get_array_map("},{"line_number":7085,"context_line":"            self.config_file_path)"},{"line_number":7086,"context_line":"        self.assertEqual(len(arrayInfo), 4)"},{"line_number":7087,"context_line":"        poolRec \u003d self.driver.utils.extract_record(arrayInfo, pool)"},{"line_number":7088,"context_line":""},{"line_number":7089,"context_line":"        self.assertEqual(\u00271234567891011\u0027, poolRec[\u0027SerialNumber\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6d5b5e2f","line":7086,"range":{"start_line":7086,"start_character":8,"end_line":7086,"end_character":43},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":7099,"context_line":""},{"line_number":7100,"context_line":"        arrayInfo \u003d self.driver.utils.parse_file_to_get_array_map("},{"line_number":7101,"context_line":"            self.config_file_path)"},{"line_number":7102,"context_line":"        self.assertEqual(len(arrayInfo), 4)"},{"line_number":7103,"context_line":"        poolRec \u003d self.driver.utils.extract_record(arrayInfo, pool)"},{"line_number":7104,"context_line":""},{"line_number":7105,"context_line":"        self.assertEqual(\u00271234567891011\u0027, poolRec[\u0027SerialNumber\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ad3d66bd","line":7102,"range":{"start_line":7102,"start_character":8,"end_line":7102,"end_character":43},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":7412,"context_line":""},{"line_number":7413,"context_line":"        mvInstances \u003d self.driver._get_common_masking_views("},{"line_number":7414,"context_line":"            portGroupInstanceName, initiatorGroupInstanceName)"},{"line_number":7415,"context_line":"        self.assertEqual(len(mvInstances), 2)"},{"line_number":7416,"context_line":""},{"line_number":7417,"context_line":"    def test_get_common_masking_views_one_overlap(self):"},{"line_number":7418,"context_line":"        common \u003d self.driver.common"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4d73fab4","line":7415,"range":{"start_line":7415,"start_character":8,"end_line":7415,"end_character":45},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":7441,"context_line":""},{"line_number":7442,"context_line":"        mvInstances \u003d self.driver._get_common_masking_views("},{"line_number":7443,"context_line":"            portGroupInstanceName, initiatorGroupInstanceName)"},{"line_number":7444,"context_line":"        self.assertEqual(len(mvInstances), 1)"},{"line_number":7445,"context_line":""},{"line_number":7446,"context_line":"    def test_get_common_masking_views_no_overlap(self):"},{"line_number":7447,"context_line":"        common \u003d self.driver.common"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0d6292d8","line":7444,"range":{"start_line":7444,"start_character":8,"end_line":7444,"end_character":45},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":7468,"context_line":""},{"line_number":7469,"context_line":"        mvInstances \u003d self.driver._get_common_masking_views("},{"line_number":7470,"context_line":"            portGroupInstanceName, initiatorGroupInstanceName)"},{"line_number":7471,"context_line":"        self.assertEqual(len(mvInstances), 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2d9f96b5","line":7471,"range":{"start_line":7471,"start_character":8,"end_line":7471,"end_character":45},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b4196dddfe9e95f35ffe47ecd87b0f155117dabd","unresolved":false,"context_lines":[{"line_number":7468,"context_line":""},{"line_number":7469,"context_line":"        mvInstances \u003d self.driver._get_common_masking_views("},{"line_number":7470,"context_line":"            portGroupInstanceName, initiatorGroupInstanceName)"},{"line_number":7471,"context_line":"        self.assertEqual(len(mvInstances), 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_74f162cd","line":7471,"range":{"start_line":7471,"start_character":9,"end_line":7471,"end_character":45},"updated":"2016-02-25 12:08:48.000000000","message":"Still wrong argument order.","commit_id":"a46b6276218aeba7aaf0c66b2e953b46d2bb1528"}],"cinder/tests/unit/test_emc_vnx.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1897,"context_line":"        self.driverSetup(commands, results)"},{"line_number":1898,"context_line":"        stats \u003d self.driver.get_volume_stats(True)"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":1901,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":1902,"context_line":"        self.assertEqual("},{"line_number":1903,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"},{"line_number":1904,"context_line":"            \"storage_protocol is incorrect\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_edb5ae31","line":1901,"range":{"start_line":1900,"start_character":0,"end_line":1901,"end_character":55},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":1901,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":1902,"context_line":"        self.assertEqual("},{"line_number":1903,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"},{"line_number":1904,"context_line":"            \"storage_protocol is incorrect\")"},{"line_number":1905,"context_line":"        self.assertEqual("},{"line_number":1906,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":1907,"context_line":"            \"vendor name is incorrect\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2d867665","line":1904,"range":{"start_line":1902,"start_character":0,"end_line":1904,"end_character":44},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"        self.assertEqual("},{"line_number":1903,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"},{"line_number":1904,"context_line":"            \"storage_protocol is incorrect\")"},{"line_number":1905,"context_line":"        self.assertEqual("},{"line_number":1906,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":1907,"context_line":"            \"vendor name is incorrect\")"},{"line_number":1908,"context_line":"        self.assertEqual("},{"line_number":1909,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6d807e47","line":1906,"range":{"start_line":1905,"start_character":0,"end_line":1906,"end_character":40},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"        self.assertEqual("},{"line_number":1906,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":1907,"context_line":"            \"vendor name is incorrect\")"},{"line_number":1908,"context_line":"        self.assertEqual("},{"line_number":1909,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","},{"line_number":1910,"context_line":"            \"volume backend name is incorrect\")"},{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"        pool_stats \u003d stats[\u0027pools\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0d90d294","line":1909,"range":{"start_line":1908,"start_character":0,"end_line":1909,"end_character":57},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":2475,"context_line":"            self.testData.test_volume,"},{"line_number":2476,"context_line":"            self.testData.connector"},{"line_number":2477,"context_line":"        )"},{"line_number":2478,"context_line":"        self.assertEqual(iscsi_data[\u0027data\u0027][\u0027target_lun\u0027], 2,"},{"line_number":2479,"context_line":"                         \"iSCSI initialize connection returned wrong HLU\")"},{"line_number":2480,"context_line":"        expected \u003d [mock.call(*self.testData.STORAGEGROUP_LIST_CMD(\u0027fakehost\u0027),"},{"line_number":2481,"context_line":"                              poll\u003dFalse),"},{"line_number":2482,"context_line":"                    mock.call(\u0027storagegroup\u0027, \u0027-addhlu\u0027, \u0027-hlu\u0027, 2, \u0027-alu\u0027, 3,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8df22205","line":2479,"range":{"start_line":2478,"start_character":0,"end_line":2479,"end_character":74},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":2586,"context_line":"        iscsi_data \u003d self.driver.initialize_connection("},{"line_number":2587,"context_line":"            self.testData.test_volume,"},{"line_number":2588,"context_line":"            self.testData.connector)"},{"line_number":2589,"context_line":"        self.assertEqual(iscsi_data[\u0027data\u0027][\u0027target_lun\u0027], 2,"},{"line_number":2590,"context_line":"                         \"iSCSI initialize connection returned wrong HLU\")"},{"line_number":2591,"context_line":"        expected \u003d [mock.call(*self.testData.STORAGEGROUP_LIST_CMD(\u0027fakehost\u0027),"},{"line_number":2592,"context_line":"                              poll\u003dFalse),"},{"line_number":2593,"context_line":"                    mock.call(*self.testData.STORAGEGROUP_LIST_CMD(\u0027fakehost\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_cddc2a77","line":2590,"range":{"start_line":2589,"start_character":0,"end_line":2590,"end_character":74},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":3999,"context_line":"                                 new_type_data,"},{"line_number":4000,"context_line":"                                 diff_data,"},{"line_number":4001,"context_line":"                                 host_test_data)"},{"line_number":4002,"context_line":"        self.assertEqual(type(ret), tuple)"},{"line_number":4003,"context_line":"        self.assertTrue(ret[0])"},{"line_number":4004,"context_line":"        self.assertIn(\u0027type^lun\u0027, ret[1][\u0027provider_location\u0027])"},{"line_number":4005,"context_line":"        expect_cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_add9e685","line":4002,"range":{"start_line":4002,"start_character":8,"end_line":4002,"end_character":42},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":4966,"context_line":"        self.driverSetup(commands, results)"},{"line_number":4967,"context_line":"        stats \u003d self.driver.get_volume_stats(True)"},{"line_number":4968,"context_line":""},{"line_number":4969,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":4970,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":4971,"context_line":"        self.assertEqual("},{"line_number":4972,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0de73241","line":4969,"range":{"start_line":4969,"start_character":8,"end_line":4969,"end_character":58},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":4969,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":4970,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":4971,"context_line":"        self.assertEqual("},{"line_number":4972,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"},{"line_number":4973,"context_line":"            \"storage_protocol is not correct\")"},{"line_number":4974,"context_line":"        self.assertEqual("},{"line_number":4975,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4dcf7ab3","line":4972,"range":{"start_line":4972,"start_character":12,"end_line":4972,"end_character":47},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":4972,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027iSCSI\u0027,"},{"line_number":4973,"context_line":"            \"storage_protocol is not correct\")"},{"line_number":4974,"context_line":"        self.assertEqual("},{"line_number":4975,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":4976,"context_line":"            \"vendor name is not correct\")"},{"line_number":4977,"context_line":"        self.assertEqual("},{"line_number":4978,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2dd4b645","line":4975,"range":{"start_line":4975,"start_character":12,"end_line":4975,"end_character":40},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":4975,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":4976,"context_line":"            \"vendor name is not correct\")"},{"line_number":4977,"context_line":"        self.assertEqual("},{"line_number":4978,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","},{"line_number":4979,"context_line":"            \"volume backend name is not correct\")"},{"line_number":4980,"context_line":""},{"line_number":4981,"context_line":"        self.assertEqual(2, len(stats[\u0027pools\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6dcebeb5","line":4978,"range":{"start_line":4978,"start_character":12,"end_line":4978,"end_character":57},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5562,"context_line":"        self.driverSetup(commands, results)"},{"line_number":5563,"context_line":"        stats \u003d self.driver.get_volume_stats(True)"},{"line_number":5564,"context_line":""},{"line_number":5565,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":5566,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":5567,"context_line":"        self.assertEqual("},{"line_number":5568,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027FC\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0dbe12ff","line":5565,"range":{"start_line":5565,"start_character":25,"end_line":5565,"end_character":58},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5565,"context_line":"        self.assertEqual(stats[\u0027driver_version\u0027], VERSION,"},{"line_number":5566,"context_line":"                         \"driver_version is incorrect\")"},{"line_number":5567,"context_line":"        self.assertEqual("},{"line_number":5568,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027FC\u0027,"},{"line_number":5569,"context_line":"            \"storage_protocol is incorrect\")"},{"line_number":5570,"context_line":"        self.assertEqual("},{"line_number":5571,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4d365ab5","line":5568,"range":{"start_line":5568,"start_character":12,"end_line":5568,"end_character":44},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5568,"context_line":"            stats[\u0027storage_protocol\u0027], \u0027FC\u0027,"},{"line_number":5569,"context_line":"            \"storage_protocol is incorrect\")"},{"line_number":5570,"context_line":"        self.assertEqual("},{"line_number":5571,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":5572,"context_line":"            \"vendor name is incorrect\")"},{"line_number":5573,"context_line":"        self.assertEqual("},{"line_number":5574,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8d406209","line":5571,"range":{"start_line":5571,"start_character":12,"end_line":5571,"end_character":40},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5571,"context_line":"            stats[\u0027vendor_name\u0027], \"EMC\","},{"line_number":5572,"context_line":"            \"vendor name is incorrect\")"},{"line_number":5573,"context_line":"        self.assertEqual("},{"line_number":5574,"context_line":"            stats[\u0027volume_backend_name\u0027], \"namedbackend\","},{"line_number":5575,"context_line":"            \"volume backend name is incorrect\")"},{"line_number":5576,"context_line":""},{"line_number":5577,"context_line":"        pool_stats \u003d stats[\u0027pools\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6d451e16","line":5574,"range":{"start_line":5574,"start_character":12,"end_line":5574,"end_character":57},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5973,"context_line":"                \u0027create_lun_with_advance_feature\u0027,"},{"line_number":5974,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":5975,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":5976,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":5977,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":5978,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":5979,"context_line":"            self.assertDictMatch({\u0027system\u0027: self.target_device_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0d5572c5","line":5976,"range":{"start_line":5976,"start_character":29,"end_line":5976,"end_character":74},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":5974,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":5975,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":5976,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":5977,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":5978,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":5979,"context_line":"            self.assertDictMatch({\u0027system\u0027: self.target_device_id,"},{"line_number":5980,"context_line":"                                  \u0027host\u0027: rep_volume.host,"},{"line_number":5981,"context_line":"                                  \u0027snapcopy\u0027: \u0027False\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4d5dbaeb","line":5978,"range":{"start_line":5977,"start_character":0,"end_line":5978,"end_character":72},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order. I think… ;)","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":6006,"context_line":"                \u0027create_lun_with_advance_feature\u0027,"},{"line_number":6007,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":6008,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":6009,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":6010,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":6011,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":6012,"context_line":"        fake_cli.assert_has_calls("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8d57c2c9","line":6009,"range":{"start_line":6009,"start_character":12,"end_line":6009,"end_character":75},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":6007,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":6008,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":6009,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":6010,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":6011,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":6012,"context_line":"        fake_cli.assert_has_calls("},{"line_number":6013,"context_line":"            [mock.call(*self.testData.MIRROR_CREATE_CMD(mirror_name, 5),"},{"line_number":6014,"context_line":"                       poll\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ad6e0694","line":6011,"range":{"start_line":6010,"start_character":12,"end_line":6011,"end_character":72},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acbc8a24bad1089ee67837e473521925eb769863","unresolved":false,"context_lines":[{"line_number":4179,"context_line":"                                 new_type_data,"},{"line_number":4180,"context_line":"                                 diff_data,"},{"line_number":4181,"context_line":"                                 host_test_data)"},{"line_number":4182,"context_line":"        self.assertEqual(type(ret), tuple)"},{"line_number":4183,"context_line":"        self.assertTrue(ret[0])"},{"line_number":4184,"context_line":"        self.assertIn(\u0027type^lun\u0027, ret[1][\u0027provider_location\u0027])"},{"line_number":4185,"context_line":"        expect_cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_4de662b5","line":4182,"range":{"start_line":4182,"start_character":8,"end_line":4182,"end_character":42},"updated":"2016-07-04 15:22:07.000000000","message":"expected, observed","commit_id":"04437b04a15000d2ac43486f6407d8838f36ec3a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acbc8a24bad1089ee67837e473521925eb769863","unresolved":false,"context_lines":[{"line_number":6204,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":6205,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":6206,"context_line":"            self.assertEqual(\u0027enabled\u0027, model_update[\u0027replication_status\u0027])"},{"line_number":6207,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":6208,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":6209,"context_line":"            self.assertDictMatch({\u0027system\u0027: self.backend_id,"},{"line_number":6210,"context_line":"                                  \u0027snapcopy\u0027: \u0027False\u0027},"},{"line_number":6211,"context_line":"                                 model_update[\u0027metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_ed862eb8","line":6208,"range":{"start_line":6207,"start_character":0,"end_line":6208,"end_character":72},"updated":"2016-07-04 15:22:07.000000000","message":"expected, observed","commit_id":"04437b04a15000d2ac43486f6407d8838f36ec3a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acbc8a24bad1089ee67837e473521925eb769863","unresolved":false,"context_lines":[{"line_number":6236,"context_line":"                mock.Mock(return_value\u003d{\u0027lun_id\u0027: 5})):"},{"line_number":6237,"context_line":"            model_update \u003d self.driver.create_volume(rep_volume)"},{"line_number":6238,"context_line":"            self.assertEqual(\u0027enabled\u0027, model_update[\u0027replication_status\u0027])"},{"line_number":6239,"context_line":"            self.assertEqual(model_update[\u0027replication_driver_data\u0027],"},{"line_number":6240,"context_line":"                             build_replication_data(self.configuration))"},{"line_number":6241,"context_line":"        fake_cli.assert_has_calls("},{"line_number":6242,"context_line":"            [mock.call(*self.testData.MIRROR_CREATE_CMD(mirror_name, 5),"},{"line_number":6243,"context_line":"                       poll\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_4d94a2e1","line":6240,"range":{"start_line":6239,"start_character":0,"end_line":6240,"end_character":72},"updated":"2016-07-04 15:22:07.000000000","message":"ditto","commit_id":"04437b04a15000d2ac43486f6407d8838f36ec3a"}],"cinder/tests/unit/test_hitachi_hnas_iscsi.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"cbbfcc3e3b0ed0d91c66e8a2b1d219b624808ea9","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        self.driver.delete_volume(vol)"},{"line_number":351,"context_line":"        # should not be deletable twice"},{"line_number":352,"context_line":"        prov_loc \u003d self.backend.getVolumebyProvider(vol[\u0027provider_location\u0027])"},{"line_number":353,"context_line":"        self.assertTrue(prov_loc is None)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def test_extend_volume(self):"},{"line_number":356,"context_line":"        vol \u003d self._create_volume()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_9a6d0c9b","line":353,"range":{"start_line":353,"start_character":33,"end_line":353,"end_character":35},"updated":"2016-03-02 14:15:35.000000000","message":"Following the pattern of your changes, it should be changed to assertIsNone?","commit_id":"13ca20356033115e1e183005d1be18ba9ac9add2"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"cbbfcc3e3b0ed0d91c66e8a2b1d219b624808ea9","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        lun \u003d svol[\u0027provider_location\u0027]"},{"line_number":396,"context_line":"        m_id_to_vol.return_value \u003d svol"},{"line_number":397,"context_line":"        self.driver.delete_snapshot(svol)"},{"line_number":398,"context_line":"        self.assertTrue(self.backend.getVolumebyProvider(lun) is None)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_create_volume_from_snapshot(self):"},{"line_number":401,"context_line":"        svol \u003d self._create_volume()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_9a1b4c1b","line":398,"range":{"start_line":398,"start_character":37,"end_line":398,"end_character":56},"updated":"2016-03-02 14:15:35.000000000","message":"It should be assertIsNone?","commit_id":"13ca20356033115e1e183005d1be18ba9ac9add2"}],"cinder/tests/unit/test_utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1389,"context_line":"        self.assertTrue(self.one \u003c\u003d self.one)"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"    def test_eq(self):"},{"line_number":1392,"context_line":"        self.assertNotEqual(self.one, self.two)"},{"line_number":1393,"context_line":"        self.assertNotEqual(self.two, self.one)"},{"line_number":1394,"context_line":"        self.assertEqual(self.one, self.one)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"    def test_ge(self):"},{"line_number":1397,"context_line":"        self.assertFalse(self.one \u003e\u003d self.two)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6db87ee6","line":1394,"range":{"start_line":1392,"start_character":0,"end_line":1394,"end_character":44},"updated":"2016-02-25 11:08:42.000000000","message":"I would probably prefer to keep older version to maintain consistency. And to fulfill \"explicit is better than implicit\".","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"        self.assertFalse(self.one \u003e self.one)"},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    def test_ne(self):"},{"line_number":1407,"context_line":"        self.assertNotEqual(self.one, self.two)"},{"line_number":1408,"context_line":"        self.assertNotEqual(self.two, self.one)"},{"line_number":1409,"context_line":"        self.assertEqual(self.one, self.one)"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"    def test_compare(self):"},{"line_number":1412,"context_line":"        self.assertEqual(NotImplemented,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_adca866c","line":1409,"range":{"start_line":1407,"start_character":2,"end_line":1409,"end_character":44},"updated":"2016-02-25 11:08:42.000000000","message":"ditto","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b81d4917682d97ef0fb5dd442f77466a5e81be78","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"        return self.value"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":""},{"line_number":1374,"context_line":"class TestComparableMixin(test.TestCase):"},{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"    def setUp(self):"},{"line_number":1377,"context_line":"        super(TestComparableMixin, self).setUp()"},{"line_number":1378,"context_line":"        self.one \u003d Comparable(1)"},{"line_number":1379,"context_line":"        self.two \u003d Comparable(2)"},{"line_number":1380,"context_line":""},{"line_number":1381,"context_line":"    def test_lt(self):"},{"line_number":1382,"context_line":"        self.assertLess(self.one, self.two)"},{"line_number":1383,"context_line":"        self.assertLessEqual(self.one, self.two)"},{"line_number":1384,"context_line":"        self.assertLessEqual(self.one, self.one)"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":"    def test_le(self):"},{"line_number":1387,"context_line":"        self.assertLessEqual(self.one, self.two)"},{"line_number":1388,"context_line":"        self.assertGreater(self.two, self.one)"},{"line_number":1389,"context_line":"        self.assertGreaterEqual(self.one, self.one)"},{"line_number":1390,"context_line":""},{"line_number":1391,"context_line":"    def test_eq(self):"},{"line_number":1392,"context_line":"        self.assertFalse(self.one \u003d\u003d self.two)"},{"line_number":1393,"context_line":"        self.assertFalse(self.two \u003d\u003d self.one)"},{"line_number":1394,"context_line":"        self.assertTrue(self.one \u003d\u003d self.one)"},{"line_number":1395,"context_line":""},{"line_number":1396,"context_line":"    def test_ge(self):"},{"line_number":1397,"context_line":"        self.assertLess(self.one, self.two)"},{"line_number":1398,"context_line":"        self.assertGreaterEqual(self.two, self.one)"},{"line_number":1399,"context_line":"        self.assertGreaterEqual(self.one, self.one)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def test_gt(self):"},{"line_number":1402,"context_line":"        self.assertLessEqual(self.one, self.two)"},{"line_number":1403,"context_line":"        self.assertGreater(self.two, self.one)"},{"line_number":1404,"context_line":"        self.assertLessEqual(self.one, self.one)"},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    def test_ne(self):"},{"line_number":1407,"context_line":"        self.assertTrue(self.one !\u003d self.two)"},{"line_number":1408,"context_line":"        self.assertTrue(self.two !\u003d self.one)"},{"line_number":1409,"context_line":"        self.assertFalse(self.one !\u003d self.one)"},{"line_number":1410,"context_line":""},{"line_number":1411,"context_line":"    def test_compare(self):"},{"line_number":1412,"context_line":"        self.assertEqual(NotImplemented,"},{"line_number":1413,"context_line":"                         self.one._compare(1, self.one._cmpkey))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_78f9814d","line":1413,"range":{"start_line":1374,"start_character":0,"end_line":1413,"end_character":64},"updated":"2016-03-01 12:28:26.000000000","message":"I have doubts if this is an exact equivalent - each method is supposed to test just one operator I think and you change this fact. E.g. test_lt should use only assertLess, and test_le should use only assertLessEqual.","commit_id":"0779ff537901411ada857dcd38f381a44523b2ab"}],"cinder/tests/unit/test_v7000_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        test_snap_id \u003d \"12345678-abcd-1234-cdef-0123456789ab\""},{"line_number":548,"context_line":"        expected \u003d \"12345678abcd1234cdef0123456789ab\""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        self.assertEqual(len(expected), 32)"},{"line_number":551,"context_line":"        result \u003d self.driver._compress_snapshot_id(test_snap_id)"},{"line_number":552,"context_line":"        self.assertEqual(result, expected)"},{"line_number":553,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_edc48e60","line":550,"range":{"start_line":550,"start_character":8,"end_line":550,"end_character":43},"updated":"2016-02-25 11:08:42.000000000","message":"This assert is actually useless. Anyway - wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        self.assertEqual(len(expected), 32)"},{"line_number":551,"context_line":"        result \u003d self.driver._compress_snapshot_id(test_snap_id)"},{"line_number":552,"context_line":"        self.assertEqual(result, expected)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def test_ensure_snapshot_resource_area(self):"},{"line_number":555,"context_line":"        result_dict \u003d {\u0027success\u0027: True, \u0027res\u0027: \u0027Successful\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4da01aa6","line":552,"range":{"start_line":552,"start_character":8,"end_line":552,"end_character":42},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acbc8a24bad1089ee67837e473521925eb769863","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        self.assertEqual(32, len(expected))"},{"line_number":576,"context_line":"        result \u003d self.driver._compress_snapshot_id(test_snap_id)"},{"line_number":577,"context_line":"        self.assertEqual(result, expected)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"    def test_ensure_snapshot_resource_area(self):"},{"line_number":580,"context_line":"        result_dict \u003d {\u0027success\u0027: True, \u0027res\u0027: \u0027Successful\u0027}"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_802651b8","line":577,"range":{"start_line":577,"start_character":8,"end_line":577,"end_character":42},"updated":"2016-07-04 15:22:07.000000000","message":"expected, observed","commit_id":"04437b04a15000d2ac43486f6407d8838f36ec3a"}],"cinder/tests/unit/test_vmware_datastore.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        res \u003d self._ds_sel._filter_datastores("},{"line_number":159,"context_line":"            datastores, size_bytes, profile_id, hard_anti_affinity_datastores,"},{"line_number":160,"context_line":"            hard_affinity_ds_types)"},{"line_number":161,"context_line":"        self.assertEqual(len(res), 1)"},{"line_number":162,"context_line":"        self.assertEqual(ds_4, res[0].datastore)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # Extend the previous case by adding a datastore satisfying"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ed9bee70","line":161,"range":{"start_line":161,"start_character":7,"end_line":161,"end_character":37},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        res \u003d self._ds_sel._filter_datastores("},{"line_number":176,"context_line":"            datastores, size_bytes, profile_id, hard_anti_affinity_datastores,"},{"line_number":177,"context_line":"            hard_affinity_ds_types)"},{"line_number":178,"context_line":"        self.assertEqual(len(res), 1)"},{"line_number":179,"context_line":"        self.assertEqual(ds_5, res[0].datastore)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        # Modify the previous case to have two datastores satisfying"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2d8cb634","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":37},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c6422240b7dd80a08bd250c9925adeb9a448e05","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        res \u003d self._ds_sel._filter_datastores("},{"line_number":189,"context_line":"            datastores, size_bytes, profile_id, hard_anti_affinity_datastores,"},{"line_number":190,"context_line":"            hard_affinity_ds_types)"},{"line_number":191,"context_line":"        self.assertEqual(len(res), 2)"},{"line_number":192,"context_line":"        self.assertEqual(ds_4, res[0].datastore)"},{"line_number":193,"context_line":"        self.assertEqual(ds_5, res[1].datastore)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6d86be14","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":37},"updated":"2016-02-25 11:08:42.000000000","message":"Wrong argument order.","commit_id":"62be98a922bcb684ecae25b8b3cd476f9676acfa"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b81d4917682d97ef0fb5dd442f77466a5e81be78","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        res \u003d self._ds_sel._filter_datastores("},{"line_number":189,"context_line":"            datastores, size_bytes, profile_id, hard_anti_affinity_datastores,"},{"line_number":190,"context_line":"            hard_affinity_ds_types)"},{"line_number":191,"context_line":"        self.assertEqual(1, len(res))"},{"line_number":192,"context_line":"        self.assertEqual(ds_4, res[0].datastore)"},{"line_number":193,"context_line":"        self.assertEqual(ds_5, res[1].datastore)"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_0d263d68","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":37},"updated":"2016-03-01 12:28:26.000000000","message":"That was 2 before your change. And this is why UT jobs are failing.","commit_id":"0779ff537901411ada857dcd38f381a44523b2ab"}]}