)]}'
{"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                     \u0027free_capacity\u0027, \u0027virtual_capacity\u0027, \u0027used_capacity\u0027,"},{"line_number":386,"context_line":"                     \u0027real_capacity\u0027, \u0027overallocation\u0027, \u0027warning\u0027,"},{"line_number":387,"context_line":"                     \u0027easy_tier\u0027, \u0027easy_tier_status\u0027])"},{"line_number":388,"context_line":"        for i in range(0, pool_num):"},{"line_number":389,"context_line":"            row_data \u003d [str(i + 1),"},{"line_number":390,"context_line":"                        self._flags[\u0027storwize_svc_volpool_name\u0027][i], \u0027online\u0027,"},{"line_number":391,"context_line":"                        \u00271\u0027, six.text_type(len(self._volumes_list)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_7918be1e","line":388,"updated":"2016-02-29 18:44:16.000000000","message":"Just FYI, range defaults to starting from 0","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                     \u0027free_capacity\u0027, \u0027virtual_capacity\u0027, \u0027used_capacity\u0027,"},{"line_number":386,"context_line":"                     \u0027real_capacity\u0027, \u0027overallocation\u0027, \u0027warning\u0027,"},{"line_number":387,"context_line":"                     \u0027easy_tier\u0027, \u0027easy_tier_status\u0027])"},{"line_number":388,"context_line":"        for i in range(0, pool_num):"},{"line_number":389,"context_line":"            row_data \u003d [str(i + 1),"},{"line_number":390,"context_line":"                        self._flags[\u0027storwize_svc_volpool_name\u0027][i], \u0027online\u0027,"},{"line_number":391,"context_line":"                        \u00271\u0027, six.text_type(len(self._volumes_list)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_968fc4cb","line":388,"in_reply_to":"9aed3d3a_7918be1e","updated":"2016-03-02 11:33:36.000000000","message":"Thanksa lot! It is addressed in new bug fix patch https://review.openstack.org/#/c/287120/","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                        row \u003d each_row"},{"line_number":416,"context_line":"                        break"},{"line_number":417,"context_line":"            elif pool_name \u003d\u003d \u0027openstack2\u0027:"},{"line_number":418,"context_line":"                row \u003d rows[-2]"},{"line_number":419,"context_line":"            elif pool_name \u003d\u003d \u0027openstack3\u0027:"},{"line_number":420,"context_line":"                row \u003d rows[-1]"},{"line_number":421,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_79ab9e75","line":418,"updated":"2016-02-29 18:44:16.000000000","message":"Is there a reason you changed this to -2? I get that it will be the same value, but since we\u0027re looking for openstack2 and openstack3 it seems reasonable to index them as 2 and 3","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                        row \u003d each_row"},{"line_number":416,"context_line":"                        break"},{"line_number":417,"context_line":"            elif pool_name \u003d\u003d \u0027openstack2\u0027:"},{"line_number":418,"context_line":"                row \u003d rows[-2]"},{"line_number":419,"context_line":"            elif pool_name \u003d\u003d \u0027openstack3\u0027:"},{"line_number":420,"context_line":"                row \u003d rows[-1]"},{"line_number":421,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_7942eb3f","line":418,"in_reply_to":"9aed3d3a_79ab9e75","updated":"2016-03-02 11:33:36.000000000","message":"Sine the length of rows changes according to the config storwize_svc_volpool_name. For example, in this case, storwize_svc_volpool_name changes to [openstack,openstack1], so the rows length is changed to 5, the data for penstack2 is rows[3] and the data for openstack3 is rows[4]. So just update it to rows[-2] and rows[-1]. If the length of storwize_svc_volpool_name changes again, we do need to update it any more.","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                if mdiskgrp \u003d\u003d self._flags[\u0027storwize_svc_volpool_name\u0027][i]:"},{"line_number":441,"context_line":"                    return i + 1"},{"line_number":442,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack2\u0027:"},{"line_number":443,"context_line":"            return grp_num + 1"},{"line_number":444,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack3\u0027:"},{"line_number":445,"context_line":"            return grp_num + 2"},{"line_number":446,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_f9804ec1","line":443,"updated":"2016-02-29 18:44:16.000000000","message":"Shouldn\u0027t this just return 2? Right now I think it\u0027d return 4 (length of 3 + 1)","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                if mdiskgrp \u003d\u003d self._flags[\u0027storwize_svc_volpool_name\u0027][i]:"},{"line_number":441,"context_line":"                    return i + 1"},{"line_number":442,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack2\u0027:"},{"line_number":443,"context_line":"            return grp_num + 1"},{"line_number":444,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack3\u0027:"},{"line_number":445,"context_line":"            return grp_num + 2"},{"line_number":446,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_399a2364","line":443,"in_reply_to":"9aed3d3a_f9804ec1","updated":"2016-03-02 11:33:36.000000000","message":"See the comments above, mdiskgrp id for openstack2 is 3 since it is the third pool in rows array. and  mdiskgrp id for openstack3 is 4 and it is the last pool in rows array. grp_num is 2 since there are two pools in storwize_svc_volpool_name.","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack2\u0027:"},{"line_number":443,"context_line":"            return grp_num + 1"},{"line_number":444,"context_line":"        elif mdiskgrp \u003d\u003d \u0027openstack3\u0027:"},{"line_number":445,"context_line":"            return grp_num + 2"},{"line_number":446,"context_line":"        else:"},{"line_number":447,"context_line":"            return None"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_196c1234","line":445,"updated":"2016-02-29 18:44:16.000000000","message":"Same as above","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                rows.append([six.text_type(vol[\u0027id\u0027]), vol[\u0027name\u0027],"},{"line_number":797,"context_line":"                             vol[\u0027IO_group_id\u0027],"},{"line_number":798,"context_line":"                             vol[\u0027IO_group_name\u0027], \u0027online\u0027, \u00270\u0027,"},{"line_number":799,"context_line":"                             self._flags[\u0027storwize_svc_volpool_name\u0027][0],"},{"line_number":800,"context_line":"                             cap, \u0027striped\u0027,"},{"line_number":801,"context_line":"                             fcmap_info[\u0027fc_id\u0027], fcmap_info[\u0027fc_name\u0027],"},{"line_number":802,"context_line":"                             \u0027\u0027, \u0027\u0027, vol[\u0027uid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_1d287d85","line":799,"updated":"2016-02-29 18:44:16.000000000","message":"Since we\u0027re doing this same self._flags[\u0027storwize_svc_volpool_name\u0027][0] a bunch of times, it may be nice to have to have some _get_pool which just grabs some pool name","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                rows.append([six.text_type(vol[\u0027id\u0027]), vol[\u0027name\u0027],"},{"line_number":797,"context_line":"                             vol[\u0027IO_group_id\u0027],"},{"line_number":798,"context_line":"                             vol[\u0027IO_group_name\u0027], \u0027online\u0027, \u00270\u0027,"},{"line_number":799,"context_line":"                             self._flags[\u0027storwize_svc_volpool_name\u0027][0],"},{"line_number":800,"context_line":"                             cap, \u0027striped\u0027,"},{"line_number":801,"context_line":"                             fcmap_info[\u0027fc_id\u0027], fcmap_info[\u0027fc_name\u0027],"},{"line_number":802,"context_line":"                             \u0027\u0027, \u0027\u0027, vol[\u0027uid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_99a9b77e","line":799,"in_reply_to":"9aed3d3a_1d287d85","updated":"2016-03-02 11:33:36.000000000","message":"Thanks a lot! It is addressed in new bug fix patch https://review.openstack.org/#/c/287120/","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        for k, v in self._def_flags.items():"},{"line_number":1832,"context_line":"            self._set_flag(k, v)"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":"    def _create_volume(self, **kwargs):"},{"line_number":1835,"context_line":"        pool \u003d self._def_flags[\u0027storwize_svc_volpool_name\u0027][0]"},{"line_number":1836,"context_line":"        prop \u003d {\u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool,"},{"line_number":1837,"context_line":"                \u0027size\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_1d9d1dbc","line":1834,"updated":"2016-02-29 18:44:16.000000000","message":"Instead of defining this in multiple places we could move this to the common test base and call super from here. Or we can move lines 1835-1840 to a helper method so we don\u0027t duplicate the code","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        for k, v in self._def_flags.items():"},{"line_number":1832,"context_line":"            self._set_flag(k, v)"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":"    def _create_volume(self, **kwargs):"},{"line_number":1835,"context_line":"        pool \u003d self._def_flags[\u0027storwize_svc_volpool_name\u0027][0]"},{"line_number":1836,"context_line":"        prop \u003d {\u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool,"},{"line_number":1837,"context_line":"                \u0027size\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_59cd6f5c","line":1834,"in_reply_to":"9aed3d3a_1d9d1dbc","updated":"2016-03-02 11:33:36.000000000","message":"Address it in new patch","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":2990,"context_line":"        attributes \u003d self.driver._helpers.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":2991,"context_line":"        attr_size \u003d float(attributes[\u0027capacity\u0027]) / units.Gi  # bytes to GB"},{"line_number":2992,"context_line":"        self.assertEqual(attr_size, float(volume[\u0027size\u0027]))"},{"line_number":2993,"context_line":"        pool \u003d\\"},{"line_number":2994,"context_line":"            self.driver.configuration.local_conf.storwize_svc_volpool_name[0]"},{"line_number":2995,"context_line":"        self.assertEqual(attributes[\u0027mdisk_grp_name\u0027], pool)"},{"line_number":2996,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_1d399da4","line":2993,"updated":"2016-02-29 18:44:16.000000000","message":"This should be wrapped with parens, e.g.\n\npool \u003d (self.driver.configuration.\nlocal_conf.storwize_svc_volpool_name[0])","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":2990,"context_line":"        attributes \u003d self.driver._helpers.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":2991,"context_line":"        attr_size \u003d float(attributes[\u0027capacity\u0027]) / units.Gi  # bytes to GB"},{"line_number":2992,"context_line":"        self.assertEqual(attr_size, float(volume[\u0027size\u0027]))"},{"line_number":2993,"context_line":"        pool \u003d\\"},{"line_number":2994,"context_line":"            self.driver.configuration.local_conf.storwize_svc_volpool_name[0]"},{"line_number":2995,"context_line":"        self.assertEqual(attributes[\u0027mdisk_grp_name\u0027], pool)"},{"line_number":2996,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_59f44f86","line":2993,"in_reply_to":"9aed3d3a_1d399da4","updated":"2016-03-02 11:33:36.000000000","message":"Thanksa lot! It is addressed in new bug fix patch https://review.openstack.org/#/c/287120/","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":3455,"context_line":"        volume \u003d self._generate_vol_info(None, None)"},{"line_number":3456,"context_line":"        old_type \u003d volume_types.get_volume_type(ctxt, old_type_ref[\u0027id\u0027])"},{"line_number":3457,"context_line":"        volume[\u0027volume_type\u0027] \u003d old_type"},{"line_number":3458,"context_line":"        volume[\u0027host\u0027] \u003d \u0027openstack@svc#openstack\u0027"},{"line_number":3459,"context_line":"        new_type \u003d volume_types.get_volume_type(ctxt, new_type_ref[\u0027id\u0027])"},{"line_number":3460,"context_line":""},{"line_number":3461,"context_line":"        self.driver.create_volume(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_fd8e792c","line":3458,"updated":"2016-02-29 18:44:16.000000000","message":"Would be nicer to do volume[\u0027host\u0027] \u003d host[\u0027host\u0027] instead of hardcoding the string twice.  Same for a few instances below","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"eabb7ac0ffbb080c11b0bb61059f8b024fdf58cd","unresolved":false,"context_lines":[{"line_number":3455,"context_line":"        volume \u003d self._generate_vol_info(None, None)"},{"line_number":3456,"context_line":"        old_type \u003d volume_types.get_volume_type(ctxt, old_type_ref[\u0027id\u0027])"},{"line_number":3457,"context_line":"        volume[\u0027volume_type\u0027] \u003d old_type"},{"line_number":3458,"context_line":"        volume[\u0027host\u0027] \u003d \u0027openstack@svc#openstack\u0027"},{"line_number":3459,"context_line":"        new_type \u003d volume_types.get_volume_type(ctxt, new_type_ref[\u0027id\u0027])"},{"line_number":3460,"context_line":""},{"line_number":3461,"context_line":"        self.driver.create_volume(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_593baf38","line":3458,"in_reply_to":"9aed3d3a_fd8e792c","updated":"2016-03-02 11:33:36.000000000","message":"Address it in new bug fix patch https://review.openstack.org/#/c/287120/","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":4336,"context_line":"                          self.driver.manage_existing, new_volume, ref)"},{"line_number":4337,"context_line":""},{"line_number":4338,"context_line":"        new_volume[\u0027volume_type_id\u0027] \u003d type_thick_ref[\u0027id\u0027]"},{"line_number":4339,"context_line":"        no_exist_pool \u003d \u0027i-dont-exist-%s\u0027 % random.randint(10000, 99999)"},{"line_number":4340,"context_line":"        new_volume[\u0027host\u0027] \u003d \u0027openstack@svc#%s\u0027 % no_exist_pool"},{"line_number":4341,"context_line":"        self.assertRaises(exception.ManageExistingVolumeTypeMismatch,"},{"line_number":4342,"context_line":"                          self.driver.manage_existing, new_volume, ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_fde319d7","line":4339,"updated":"2016-02-29 18:44:16.000000000","message":"a _get_host method that does this may be nice also","commit_id":"4d70db314d980233df83d178480c0cca97427318"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"03c0347f2be61600803abb8cba8eb3ffb769aad7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"storwize_svc_opts \u003d ["},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027storwize_svc_volpool_name\u0027,"},{"line_number":53,"context_line":"                default\u003d\u0027volpool\u0027,"},{"line_number":54,"context_line":"                help\u003d\u0027List of storage system storage pools for volumes\u0027),"},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_rsize\u0027,"},{"line_number":56,"context_line":"               default\u003d2,"},{"line_number":57,"context_line":"               min\u003d-1, max\u003d100,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_bd31ed0d","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":72},"updated":"2016-02-26 20:08:49.000000000","message":"Can we specify here how to create the list?  Assuming comma separated?","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"258b580c973a615bea214ba9da48b42593738740","unresolved":false,"context_lines":[{"line_number":51,"context_line":"storwize_svc_opts \u003d ["},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027storwize_svc_volpool_name\u0027,"},{"line_number":53,"context_line":"                default\u003d\u0027volpool\u0027,"},{"line_number":54,"context_line":"                help\u003d\u0027List of storage system storage pools for volumes\u0027),"},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_rsize\u0027,"},{"line_number":56,"context_line":"               default\u003d2,"},{"line_number":57,"context_line":"               min\u003d-1, max\u003d100,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_5e86a9db","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":72},"in_reply_to":"9aed3d3a_bd31ed0d","updated":"2016-02-29 06:51:28.000000000","message":"Jay, Thanks a lot! It\u0027s addressed in patch 4.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"03c0347f2be61600803abb8cba8eb3ffb769aad7","unresolved":false,"context_lines":[{"line_number":1929,"context_line":"        # v2 replication setup"},{"line_number":1930,"context_line":"        self._do_replication_setup()"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"    def _valid_pool_exist(self):"},{"line_number":1933,"context_line":"        # Validate that the pool exists"},{"line_number":1934,"context_line":"        pools \u003d self.configuration.storwize_svc_volpool_name"},{"line_number":1935,"context_line":"        for pool in pools:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_f841c30c","line":1932,"range":{"start_line":1932,"start_character":8,"end_line":1932,"end_character":25},"updated":"2016-02-26 20:08:49.000000000","message":"Sorry this is a nit, but I think this would be clearer as \u0027_validate_pool_exists\u0027","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"258b580c973a615bea214ba9da48b42593738740","unresolved":false,"context_lines":[{"line_number":1929,"context_line":"        # v2 replication setup"},{"line_number":1930,"context_line":"        self._do_replication_setup()"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"    def _valid_pool_exist(self):"},{"line_number":1933,"context_line":"        # Validate that the pool exists"},{"line_number":1934,"context_line":"        pools \u003d self.configuration.storwize_svc_volpool_name"},{"line_number":1935,"context_line":"        for pool in pools:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_de72b910","line":1932,"range":{"start_line":1932,"start_character":8,"end_line":1932,"end_character":25},"in_reply_to":"9aed3d3a_f841c30c","updated":"2016-02-29 06:51:28.000000000","message":"Thanks a lot! It is addressed in patch 4.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"03c0347f2be61600803abb8cba8eb3ffb769aad7","unresolved":false,"context_lines":[{"line_number":2534,"context_line":"                elif key in no_copy_keys:"},{"line_number":2535,"context_line":"                    vdisk_changes.append(key)"},{"line_number":2536,"context_line":""},{"line_number":2537,"context_line":"        if utils.extract_host(volume[\u0027host\u0027], \u0027pool\u0027) !\u003d\\"},{"line_number":2538,"context_line":"                utils.extract_host(host[\u0027host\u0027], \u0027pool\u0027):"},{"line_number":2539,"context_line":"            need_copy \u003d True"},{"line_number":2540,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_b82c5b4b","line":2537,"range":{"start_line":2537,"start_character":54,"end_line":2537,"end_character":57},"updated":"2016-02-26 20:08:49.000000000","message":"Should use () for this long line instead of \\.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"258b580c973a615bea214ba9da48b42593738740","unresolved":false,"context_lines":[{"line_number":2534,"context_line":"                elif key in no_copy_keys:"},{"line_number":2535,"context_line":"                    vdisk_changes.append(key)"},{"line_number":2536,"context_line":""},{"line_number":2537,"context_line":"        if utils.extract_host(volume[\u0027host\u0027], \u0027pool\u0027) !\u003d\\"},{"line_number":2538,"context_line":"                utils.extract_host(host[\u0027host\u0027], \u0027pool\u0027):"},{"line_number":2539,"context_line":"            need_copy \u003d True"},{"line_number":2540,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_be56d559","line":2537,"range":{"start_line":2537,"start_character":54,"end_line":2537,"end_character":57},"in_reply_to":"9aed3d3a_b82c5b4b","updated":"2016-02-29 06:51:28.000000000","message":"Thanks a lot!. It is addressed in patch 4.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"03c0347f2be61600803abb8cba8eb3ffb769aad7","unresolved":false,"context_lines":[{"line_number":2916,"context_line":"                }"},{"line_number":2917,"context_line":"            if self._replication_enabled:"},{"line_number":2918,"context_line":"                pool_stats[\u0027replication_enabled\u0027] \u003d self._replication_enabled"},{"line_number":2919,"context_line":"                pool_stats[\u0027replication_type\u0027] \u003d\\"},{"line_number":2920,"context_line":"                    self._supported_replication_types"},{"line_number":2921,"context_line":"                pool_stats[\u0027replication_count\u0027] \u003d\\"},{"line_number":2922,"context_line":"                    len(self._replication_targets)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_38a4cba4","line":2919,"range":{"start_line":2919,"start_character":47,"end_line":2919,"end_character":49},"updated":"2016-02-26 20:08:49.000000000","message":"Same comment here if there is a way to do this without \\ it would be better.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"258b580c973a615bea214ba9da48b42593738740","unresolved":false,"context_lines":[{"line_number":2916,"context_line":"                }"},{"line_number":2917,"context_line":"            if self._replication_enabled:"},{"line_number":2918,"context_line":"                pool_stats[\u0027replication_enabled\u0027] \u003d self._replication_enabled"},{"line_number":2919,"context_line":"                pool_stats[\u0027replication_type\u0027] \u003d\\"},{"line_number":2920,"context_line":"                    self._supported_replication_types"},{"line_number":2921,"context_line":"                pool_stats[\u0027replication_count\u0027] \u003d\\"},{"line_number":2922,"context_line":"                    len(self._replication_targets)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_fe4cddc9","line":2919,"range":{"start_line":2919,"start_character":47,"end_line":2919,"end_character":49},"in_reply_to":"9aed3d3a_38a4cba4","updated":"2016-02-29 06:51:28.000000000","message":"Thanks a lot!. It is addressed in patch 4 using pool_stats.update.","commit_id":"a7f1b5ca5b932a1d3c74663519f47cb3852916a4"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"        # v2 replication setup"},{"line_number":1931,"context_line":"        self._do_replication_setup()"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"    def _validate_pool_exists(self):"},{"line_number":1934,"context_line":"        # Validate that the pool exists"},{"line_number":1935,"context_line":"        pools \u003d self.configuration.storwize_svc_volpool_name"},{"line_number":1936,"context_line":"        for pool in pools:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_b9d1a659","line":1933,"updated":"2016-02-29 18:44:16.000000000","message":"Nit, but this should likely be \"_validate_pools_exist\" since we\u0027re checking a list of pools now","commit_id":"4d70db314d980233df83d178480c0cca97427318"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"5671d43a5510656396e90c5c00585d04fc45f552","unresolved":false,"context_lines":[{"line_number":2888,"context_line":""},{"line_number":2889,"context_line":"    def _build_pool_stats(self, pool):"},{"line_number":2890,"context_line":"        \"\"\"Build pool status\"\"\""},{"line_number":2891,"context_line":"        QoS_support \u003d True"},{"line_number":2892,"context_line":"        pool_stats \u003d {}"},{"line_number":2893,"context_line":"        try:"},{"line_number":2894,"context_line":"            pool_data \u003d self._helpers.get_pool_attrs(pool)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_59505ad4","line":2891,"updated":"2016-02-29 18:44:16.000000000","message":"don\u0027t see where this value is changing, so it seems like we should just set the value on line 2913 to True","commit_id":"4d70db314d980233df83d178480c0cca97427318"}]}