)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2aaeb728b5ebf80b88c7fc841cd6252677b1a388","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        svc_host \u003d vol_utils.extract_host(self.host, \u0027backend\u0027)"},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            service \u003d objects.Service.get_by_args("},{"line_number":250,"context_line":"                context.get_admin_context(), svc_host,"},{"line_number":251,"context_line":"                CONF.volume_topic)"},{"line_number":252,"context_line":"        except exception.HostBinaryNotFound:"},{"line_number":253,"context_line":"            # NOTE(jdg): This is to solve problems with unit tests"},{"line_number":254,"context_line":"            LOG.warning(_LW(\"Service not found for updating \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_ab7f9dde","line":251,"range":{"start_line":249,"start_character":0,"end_line":251,"end_character":34},"updated":"2016-02-29 15:02:48.000000000","message":"Wait, this is a bad idea. get_by_args is taking hostname and *binary*. By default CONF.volume_topic will match binary (\u0027cinder-volume\u0027), but this isn\u0027t granted. You should still use get_by_host_and_topic, but add disabled parameter there (through Service object and to the DB).","commit_id":"54ef8947c6d7633b6bab093664ac1cf1249281de"}]}