)]}'
{"cinder/tests/unit/test_emc_xtremio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e79f8d2e4c39a84abfa3d63022e3b31d16f0de5b","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":706,"context_line":"                                         self.data.connector)"},{"line_number":707,"context_line":"        self.driver.delete_volume(self.data.test_volume)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def test_initialize_existing_ig_terminate_connection(self, req):"},{"line_number":710,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":711,"context_line":"        self.driver.client \u003d xtremio.XtremIOClient4("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_464e9fc1","line":708,"updated":"2016-03-01 05:52:36.000000000","message":"Can you add a unit test that calls terminate_connection and assert that _get_ig_indexes_from_initiators is called with correct parameters?","commit_id":"4914f78a22e53cc2455b67da444b8b2ee513ce71"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"db385f5c0ab1845443be4255e989cbd591d2b2ea","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":706,"context_line":"                                         self.data.connector)"},{"line_number":707,"context_line":"        self.driver.delete_volume(self.data.test_volume)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def test_initialize_existing_ig_terminate_connection(self, req):"},{"line_number":710,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":711,"context_line":"        self.driver.client \u003d xtremio.XtremIOClient4("}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_6430579f","line":708,"in_reply_to":"7af24918_6ba054f5","updated":"2016-03-02 16:23:29.000000000","message":"done, thanks for clarifying","commit_id":"4914f78a22e53cc2455b67da444b8b2ee513ce71"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e42e9aeac203159160f92fbafa6450ab7c2149ea","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":706,"context_line":"                                         self.data.connector)"},{"line_number":707,"context_line":"        self.driver.delete_volume(self.data.test_volume)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def test_initialize_existing_ig_terminate_connection(self, req):"},{"line_number":710,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":711,"context_line":"        self.driver.client \u003d xtremio.XtremIOClient4("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_df00a904","line":708,"in_reply_to":"9aed3d3a_464e9fc1","updated":"2016-03-01 09:13:46.000000000","message":"Hi Xing, the scenario you describe is in line 732","commit_id":"4914f78a22e53cc2455b67da444b8b2ee513ce71"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c955e4fc501f3c471490b509ccced5abf3e389e6","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":706,"context_line":"                                         self.data.connector)"},{"line_number":707,"context_line":"        self.driver.delete_volume(self.data.test_volume)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def test_initialize_existing_ig_terminate_connection(self, req):"},{"line_number":710,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":711,"context_line":"        self.driver.client \u003d xtremio.XtremIOClient4("}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_6ba054f5","line":708,"in_reply_to":"9aed3d3a_df00a904","updated":"2016-03-02 03:13:43.000000000","message":"Hi Shay,\n\nI mean to call assert_called_once_with on _get_ig_indexes_from_initiators.","commit_id":"4914f78a22e53cc2455b67da444b8b2ee513ce71"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3659a3ebe21b437819df3005137bbb8df58bb9f1","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                          self.data.test_volume,"},{"line_number":470,"context_line":"                          self.data.connector)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def test_get_ig_indexes_form_initiaitors_called_once(self, req):"},{"line_number":473,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":474,"context_line":"        self.driver.create_volume(self.data.test_volume)"},{"line_number":475,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_cf1f4db5","line":472,"range":{"start_line":472,"start_character":28,"end_line":472,"end_character":44},"updated":"2016-03-10 16:07:29.000000000","message":"/form/from/ ?\n/initiaitors/initiators/","commit_id":"c183c973408cdcf586bf68b453971242799864d9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"94a23496e7211d86350d5f25be7daf628468c98b","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                          self.data.test_volume,"},{"line_number":470,"context_line":"                          self.data.connector)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    def test_get_ig_indexes_form_initiaitors_called_once(self, req):"},{"line_number":473,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":474,"context_line":"        self.driver.create_volume(self.data.test_volume)"},{"line_number":475,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_ac60bd36","line":472,"range":{"start_line":472,"start_character":28,"end_line":472,"end_character":44},"in_reply_to":"5aef4532_cf1f4db5","updated":"2016-03-13 09:16:47.000000000","message":"Done","commit_id":"c183c973408cdcf586bf68b453971242799864d9"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ad1ecc500b7d87f7b83ec96e37548c8de3b42c4e","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"},{"line_number":717,"context_line":"                                                     self.data.connector)"},{"line_number":718,"context_line":"        self.assertEqual(1, map_data[\u0027data\u0027][\u0027target_lun\u0027])"},{"line_number":719,"context_line":"        for i1 in xms_data[\u0027initiators\u0027].values():"},{"line_number":720,"context_line":"            i1[\u0027ig-id\u0027] \u003d [\u0027\u0027, i1[\u0027ig-id\u0027], 1]"},{"line_number":721,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":722,"context_line":"                                         self.data.connector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_4df594c9","line":719,"updated":"2016-03-14 13:23:39.000000000","message":"Please, don\u0027t change global variables with tests data. It makes tests more complicated","commit_id":"fb68584b9a7b61664328017c25c72ce295b4c8a6"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"919a952b064447cb6724ed548be0fb85a1b966c0","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"},{"line_number":717,"context_line":"                                                     self.data.connector)"},{"line_number":718,"context_line":"        self.assertEqual(1, map_data[\u0027data\u0027][\u0027target_lun\u0027])"},{"line_number":719,"context_line":"        for i1 in xms_data[\u0027initiators\u0027].values():"},{"line_number":720,"context_line":"            i1[\u0027ig-id\u0027] \u003d [\u0027\u0027, i1[\u0027ig-id\u0027], 1]"},{"line_number":721,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":722,"context_line":"                                         self.data.connector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_dbd2f3d1","line":719,"in_reply_to":"3afc51ec_4df594c9","updated":"2016-03-14 15:27:57.000000000","message":"we initialize xms_data, the pseodo management DB, before every test, I don\u0027t see any problem with changing it\u0027s data.","commit_id":"fb68584b9a7b61664328017c25c72ce295b4c8a6"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e9fbac826892edcef49ba2c3282313e4527fd303","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"},{"line_number":717,"context_line":"                                                     self.data.connector)"},{"line_number":718,"context_line":"        self.assertEqual(1, map_data[\u0027data\u0027][\u0027target_lun\u0027])"},{"line_number":719,"context_line":"        for i1 in xms_data[\u0027initiators\u0027].values():"},{"line_number":720,"context_line":"            i1[\u0027ig-id\u0027] \u003d [\u0027\u0027, i1[\u0027ig-id\u0027], 1]"},{"line_number":721,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":722,"context_line":"                                         self.data.connector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_199a44b9","line":719,"in_reply_to":"3afc51ec_8a72c9ab","updated":"2016-03-24 07:29:21.000000000","message":"excellent point, we\u0027ll open a bug for this and fix it in another commit, no point to mix this bug fix with the need for better overall design to this drivers test suite.","commit_id":"fb68584b9a7b61664328017c25c72ce295b4c8a6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9d0a37acd9f70a8bb2dc78f4d953c36716a6099b","unresolved":false,"context_lines":[{"line_number":716,"context_line":"        map_data \u003d self.driver.initialize_connection(self.data.test_volume,"},{"line_number":717,"context_line":"                                                     self.data.connector)"},{"line_number":718,"context_line":"        self.assertEqual(1, map_data[\u0027data\u0027][\u0027target_lun\u0027])"},{"line_number":719,"context_line":"        for i1 in xms_data[\u0027initiators\u0027].values():"},{"line_number":720,"context_line":"            i1[\u0027ig-id\u0027] \u003d [\u0027\u0027, i1[\u0027ig-id\u0027], 1]"},{"line_number":721,"context_line":"        self.driver.terminate_connection(self.data.test_volume,"},{"line_number":722,"context_line":"                                         self.data.connector)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_8a72c9ab","line":719,"in_reply_to":"3afc51ec_dbd2f3d1","updated":"2016-03-14 19:10:54.000000000","message":"It means, that these tests have a bad design and should be refactored","commit_id":"fb68584b9a7b61664328017c25c72ce295b4c8a6"}]}