)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4cb44033054ca39acc6976d71dfdeda9c88f6ba5","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def tearDown(self):"},{"line_number":631,"context_line":"        shutil.rmtree(self.tempdir)"},{"line_number":632,"context_line":"        self. _hosts \u003d {}"},{"line_number":633,"context_line":"        super(TestHP3PARISCSIDriver, self).tearDown()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def fake_iscsi_discover_target_iqn(self, ip_address):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbpE%3D","line":632,"updated":"2013-05-09 20:56:02.000000000","message":"Unintentional space?","commit_id":"8aa558054a25cd98330afc527338419f98e96ac5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"4ca6cb737217149603e8b84ff21d6cef41828559","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def tearDown(self):"},{"line_number":631,"context_line":"        shutil.rmtree(self.tempdir)"},{"line_number":632,"context_line":"        self. _hosts \u003d {}"},{"line_number":633,"context_line":"        super(TestHP3PARISCSIDriver, self).tearDown()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def fake_iscsi_discover_target_iqn(self, ip_address):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fbi0%3D","line":632,"in_reply_to":"AAAAOn%2F%2FbpE%3D","updated":"2013-05-09 23:29:44.000000000","message":"Yes, unintentional.","commit_id":"8aa558054a25cd98330afc527338419f98e96ac5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4cb44033054ca39acc6976d71dfdeda9c88f6ba5","unresolved":false,"context_lines":[{"line_number":819,"context_line":"def pack(arg):"},{"line_number":820,"context_line":"    HEADER \u003d \u0027\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":821,"context_line":"    FOOTER \u003d \u0027\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":822,"context_line":"#    FOOTER \u003d \u0027\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":823,"context_line":"    return HEADER + arg + FOOTER"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"SSH_FC_SHOWHOST_RETURN \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fbo8%3D","line":822,"updated":"2013-05-09 20:56:02.000000000","message":"Commented line should be removed?","commit_id":"8aa558054a25cd98330afc527338419f98e96ac5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"4ca6cb737217149603e8b84ff21d6cef41828559","unresolved":false,"context_lines":[{"line_number":819,"context_line":"def pack(arg):"},{"line_number":820,"context_line":"    HEADER \u003d \u0027\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":821,"context_line":"    FOOTER \u003d \u0027\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":822,"context_line":"#    FOOTER \u003d \u0027\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\u0027"},{"line_number":823,"context_line":"    return HEADER + arg + FOOTER"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"SSH_FC_SHOWHOST_RETURN \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fbiw%3D","line":822,"in_reply_to":"AAAAOn%2F%2Fbo8%3D","updated":"2013-05-09 23:29:44.000000000","message":"Yes, I forgot to remove.","commit_id":"8aa558054a25cd98330afc527338419f98e96ac5"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9b72a4e2119f490f0258bec7eea24efdf420add8","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":564,"context_line":"            AndReturn([pack(SSH_FC_SHOWHOST_NO_FC_RETURN), \u0027\u0027])"},{"line_number":565,"context_line":"        self.driver.common._run_ssh(\u0027createhost -add fakehost \\"},{"line_number":566,"context_line":"123456789012345 123456789054321\u0027, False).AndReturn([\u0027r\\n\u0027, \u0027\u0027])"},{"line_number":567,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":568,"context_line":"            AndReturn([pack(SSH_FC_SHOWHOST_RETURN), \u0027\u0027])"},{"line_number":569,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbjk%3D","line":566,"updated":"2013-05-09 21:25:07.000000000","message":"Maybe you can fit the text commands in a variable?  Might make this code easier to read.   It\u0027s nice to eliminate the need for \\ chars and line continuation if possible.","commit_id":"19a5b9d7b31bbb9421912877786cc4f5d8dcc547"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"aef3419021e1aa8646fbcf12da5cf126e0f02418","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":564,"context_line":"            AndReturn([pack(SSH_FC_SHOWHOST_NO_FC_RETURN), \u0027\u0027])"},{"line_number":565,"context_line":"        self.driver.common._run_ssh(\u0027createhost -add fakehost \\"},{"line_number":566,"context_line":"123456789012345 123456789054321\u0027, False).AndReturn([\u0027r\\n\u0027, \u0027\u0027])"},{"line_number":567,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":568,"context_line":"            AndReturn([pack(SSH_FC_SHOWHOST_RETURN), \u0027\u0027])"},{"line_number":569,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbg4%3D","line":566,"in_reply_to":"AAAAOn%2F%2Fbjk%3D","updated":"2013-05-09 23:15:32.000000000","message":"Yes, good idea.","commit_id":"19a5b9d7b31bbb9421912877786cc4f5d8dcc547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9b72a4e2119f490f0258bec7eea24efdf420add8","unresolved":false,"context_lines":[{"line_number":725,"context_line":"            AndReturn([pack(\u0027no hosts listed\u0027), \u0027\u0027])"},{"line_number":726,"context_line":"        self.driver.common._run_ssh(\u0027createhost -iscsi -persona 1 -domain \\"},{"line_number":727,"context_line":"(\\\u0027OpenStack\\\u0027,) fakehost iqn.1993-08.org.debian:01:222\u0027, False).\\"},{"line_number":728,"context_line":"            AndReturn([\u0027\\r\\n\u0027, \u0027\u0027])"},{"line_number":729,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":730,"context_line":"            AndReturn([pack(SSH_ISCSI_SHOWHOST_RETURN), \u0027\u0027])"},{"line_number":731,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbjc%3D","line":728,"updated":"2013-05-09 21:25:07.000000000","message":"Same here, can we git the text string commands in a var and add that to the run_ssh() call to eliminate the \\ ?","commit_id":"19a5b9d7b31bbb9421912877786cc4f5d8dcc547"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"aef3419021e1aa8646fbcf12da5cf126e0f02418","unresolved":false,"context_lines":[{"line_number":725,"context_line":"            AndReturn([pack(\u0027no hosts listed\u0027), \u0027\u0027])"},{"line_number":726,"context_line":"        self.driver.common._run_ssh(\u0027createhost -iscsi -persona 1 -domain \\"},{"line_number":727,"context_line":"(\\\u0027OpenStack\\\u0027,) fakehost iqn.1993-08.org.debian:01:222\u0027, False).\\"},{"line_number":728,"context_line":"            AndReturn([\u0027\\r\\n\u0027, \u0027\u0027])"},{"line_number":729,"context_line":"        self.driver.common._run_ssh(\u0027showhost -verbose fakehost\u0027, False).\\"},{"line_number":730,"context_line":"            AndReturn([pack(SSH_ISCSI_SHOWHOST_RETURN), \u0027\u0027])"},{"line_number":731,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fbgs%3D","line":728,"in_reply_to":"AAAAOn%2F%2Fbjc%3D","updated":"2013-05-09 23:15:32.000000000","message":"Yes, that should make it more readable.","commit_id":"19a5b9d7b31bbb9421912877786cc4f5d8dcc547"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"acf34e6a1fb93b9c8ac5e4bb99b379c6cf608c26","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        _run_ssh \u003d self.mox.CreateMock(hpdriver.hpcommon.HP3PARCommon._run_ssh)"},{"line_number":524,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"_run_ssh\", _run_ssh)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        SHOW_HOST_CMD \u003d \u0027showhost -verbose fakehost\u0027"},{"line_number":527,"context_line":"        _run_ssh(SHOW_HOST_CMD, False).AndReturn([pack(\u0027no hosts listed\u0027), \u0027\u0027])"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        CREATE_HOST_CMD \u003d (\u0027createhost -persona 1 -domain (\\\u0027OpenStack\\\u0027,) \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FbFQ%3D","line":526,"updated":"2013-05-10 01:22:42.000000000","message":"I\u0027d probably not use all upper case for a local var here and the rest of the tests.   I think most folks use all upper case for global or class wide constants.  You have CLI_CR as a global file wide constant and are using all upper caps for local vars here.","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"3cb4c11224a36e96d8ebbf0ef00ec81e9d2d3340","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        _run_ssh \u003d self.mox.CreateMock(hpdriver.hpcommon.HP3PARCommon._run_ssh)"},{"line_number":524,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"_run_ssh\", _run_ssh)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        SHOW_HOST_CMD \u003d \u0027showhost -verbose fakehost\u0027"},{"line_number":527,"context_line":"        _run_ssh(SHOW_HOST_CMD, False).AndReturn([pack(\u0027no hosts listed\u0027), \u0027\u0027])"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        CREATE_HOST_CMD \u003d (\u0027createhost -persona 1 -domain (\\\u0027OpenStack\\\u0027,) \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FW9I%3D","line":526,"in_reply_to":"AAAAOn%2F%2FbFQ%3D","updated":"2013-05-13 18:10:14.000000000","message":"OK, I have changed all local string literals to lower case.","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"acf34e6a1fb93b9c8ac5e4bb99b379c6cf608c26","unresolved":false,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        CREATE_HOST_CMD \u003d (\u0027createhost -iscsi -add fakehost \u0027"},{"line_number":784,"context_line":"                           \u0027iqn.1993-08.org.debian:01:222\u0027)"},{"line_number":785,"context_line":"        _run_ssh(CREATE_HOST_CMD, False).AndReturn([CLI_CR, \u0027\u0027])"},{"line_number":786,"context_line":"        _run_ssh(SHOW_HOST_CMD, False).AndReturn([pack(ISCSI_HOST_RET), \u0027\u0027])"},{"line_number":787,"context_line":"        self.mox.ReplayAll()"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FbFE%3D","line":785,"updated":"2013-05-10 01:22:42.000000000","message":"Another example of a mix of upper case for a local method var as well as a global file var....\nCREATE_HOST_CMD v. CLI_CR","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"3cb4c11224a36e96d8ebbf0ef00ec81e9d2d3340","unresolved":false,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        CREATE_HOST_CMD \u003d (\u0027createhost -iscsi -add fakehost \u0027"},{"line_number":784,"context_line":"                           \u0027iqn.1993-08.org.debian:01:222\u0027)"},{"line_number":785,"context_line":"        _run_ssh(CREATE_HOST_CMD, False).AndReturn([CLI_CR, \u0027\u0027])"},{"line_number":786,"context_line":"        _run_ssh(SHOW_HOST_CMD, False).AndReturn([pack(ISCSI_HOST_RET), \u0027\u0027])"},{"line_number":787,"context_line":"        self.mox.ReplayAll()"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FW8w%3D","line":785,"in_reply_to":"AAAAOn%2F%2FbFE%3D","updated":"2013-05-13 18:10:14.000000000","message":"Done.","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"acf34e6a1fb93b9c8ac5e4bb99b379c6cf608c26","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        SHOW_PORT_CMD \u003d \u0027showport -ids\u0027"},{"line_number":801,"context_line":"        _run_ssh(SHOW_PORT_CMD, False).AndReturn([pack(ISCSI_PORT_IDS_RET),"},{"line_number":802,"context_line":"                                                 \u0027\u0027])"},{"line_number":803,"context_line":"        self.mox.ReplayAll()"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        iqn \u003d self.driver._iscsi_discover_target_iqn(\u002710.10.120.253\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FbFA%3D","line":802,"updated":"2013-05-10 01:22:42.000000000","message":"Can this line not fit on the line above and be under 80 chars?","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"3cb4c11224a36e96d8ebbf0ef00ec81e9d2d3340","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        SHOW_PORT_CMD \u003d \u0027showport -ids\u0027"},{"line_number":801,"context_line":"        _run_ssh(SHOW_PORT_CMD, False).AndReturn([pack(ISCSI_PORT_IDS_RET),"},{"line_number":802,"context_line":"                                                 \u0027\u0027])"},{"line_number":803,"context_line":"        self.mox.ReplayAll()"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        iqn \u003d self.driver._iscsi_discover_target_iqn(\u002710.10.120.253\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FW8Y%3D","line":802,"in_reply_to":"AAAAOn%2F%2FbFA%3D","updated":"2013-05-13 18:10:14.000000000","message":"It will not fit on the above line with a space after the comma as required my pep8.","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"acf34e6a1fb93b9c8ac5e4bb99b379c6cf608c26","unresolved":false,"context_lines":[{"line_number":864,"context_line":"OS         : --\\r\\n\\"},{"line_number":865,"context_line":"Model      : --\\r\\n\\"},{"line_number":866,"context_line":"Contact    : --\\r\\n\\"},{"line_number":867,"context_line":"Comment    : --  \\r\\n\\r\\n\\r\\n\u0027"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"NO_FC_HOST_RET \u003d \\"},{"line_number":870,"context_line":"    \u0027Id,Name,Persona,-WWN/iSCSI_Name-,Port,IP_addr\\r\\n\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FbE8%3D","line":867,"updated":"2013-05-10 01:22:42.000000000","message":"You can also use the python \u0027\u0027\u0027 or \"\"\" for long strings w/o the need for last char \\","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"3cb4c11224a36e96d8ebbf0ef00ec81e9d2d3340","unresolved":false,"context_lines":[{"line_number":864,"context_line":"OS         : --\\r\\n\\"},{"line_number":865,"context_line":"Model      : --\\r\\n\\"},{"line_number":866,"context_line":"Contact    : --\\r\\n\\"},{"line_number":867,"context_line":"Comment    : --  \\r\\n\\r\\n\\r\\n\u0027"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"NO_FC_HOST_RET \u003d \\"},{"line_number":870,"context_line":"    \u0027Id,Name,Persona,-WWN/iSCSI_Name-,Port,IP_addr\\r\\n\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FW8M%3D","line":867,"in_reply_to":"AAAAOn%2F%2FbE8%3D","updated":"2013-05-13 18:10:14.000000000","message":"I have changed all these string literals to use the python (\u0027 \u0027) string format.","commit_id":"846e163e828faa9eb0c1648a4338af595ff18bae"}]}