)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b5dc54759fc50608204da790255b6b229ffd684f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def getVLUNs(self):"},{"line_number":279,"context_line":"        return self.vluns"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def getVLUN(self, volumeName):"},{"line_number":282,"context_line":"        for vlun in self.vluns:"},{"line_number":283,"context_line":"            if vlun[\u0027volumeName\u0027] \u003d\u003d volumeName:"},{"line_number":284,"context_line":"                return vlun"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbYI%3D","line":281,"updated":"2013-05-09 22:38:51.000000000","message":"\"def get_vlun()\"\n\nYou\u0027ve got a mix of camel case versus lower-case with underscores in here which is kinda ugly.  The standard is mostly lower-case with underscores.\n\nAgain, I know it\u0027s a test file but we should be consistent.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99eb2cfaecfef81fcb2a47bec55134ee5697a6e2","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def getVLUNs(self):"},{"line_number":279,"context_line":"        return self.vluns"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def getVLUN(self, volumeName):"},{"line_number":282,"context_line":"        for vlun in self.vluns:"},{"line_number":283,"context_line":"            if vlun[\u0027volumeName\u0027] \u003d\u003d volumeName:"},{"line_number":284,"context_line":"                return vlun"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbUc%3D","line":281,"in_reply_to":"AAAAOn%2F%2FbYI%3D","updated":"2013-05-09 23:10:44.000000000","message":"The only non camel case here is the debug_rest() method. \n  It\u0027s not being used directly in the tests, but can be called by the driver depending on config options.   This is an artifact of being the fake 3par client.  The real 3par client API is camel case, which the driver calls, so I need to match the APIs.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b5dc54759fc50608204da790255b6b229ffd684f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"               \u0027desc\u0027: \"VLUN \u0027%s\u0027 was not found\" % volumeName}"},{"line_number":288,"context_line":"        raise hpexceptions.HTTPNotFound(msg)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _mergeDict(selft, dict1, dict2):"},{"line_number":291,"context_line":"        \"\"\""},{"line_number":292,"context_line":"        Safely merge 2 dictionaries together"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbYo%3D","line":290,"updated":"2013-05-09 22:38:51.000000000","message":"This seems to be docstring day...  take a look at the examples in HACKING.rst\n\nAlso, you have some methods with docstrings and some without.  I\u0027m not overly concerned about them being in test files at all but we should try to be consistent.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99eb2cfaecfef81fcb2a47bec55134ee5697a6e2","unresolved":false,"context_lines":[{"line_number":287,"context_line":"               \u0027desc\u0027: \"VLUN \u0027%s\u0027 was not found\" % volumeName}"},{"line_number":288,"context_line":"        raise hpexceptions.HTTPNotFound(msg)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _mergeDict(selft, dict1, dict2):"},{"line_number":291,"context_line":"        \"\"\""},{"line_number":292,"context_line":"        Safely merge 2 dictionaries together"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbU4%3D","line":290,"in_reply_to":"AAAAOn%2F%2FbYo%3D","updated":"2013-05-09 23:10:44.000000000","message":"ok thanks, this was a copy/paste method from the actual python 3par client.   I\u0027ll just nuke the docstrings.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"24027b521f127dba56ec03066a0ef10bf36e197b","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        raise hpexceptions.HTTPNotFound(msg)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _mergeDict(selft, dict1, dict2):"},{"line_number":291,"context_line":"        \"\"\""},{"line_number":292,"context_line":"        Safely merge 2 dictionaries together"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param dict1: The first dictionary"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbW0%3D","line":291,"updated":"2013-05-09 22:44:07.000000000","message":"I am thinking \u0027selft\u0027 is a typo here.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99eb2cfaecfef81fcb2a47bec55134ee5697a6e2","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        raise hpexceptions.HTTPNotFound(msg)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _mergeDict(selft, dict1, dict2):"},{"line_number":291,"context_line":"        \"\"\""},{"line_number":292,"context_line":"        Safely merge 2 dictionaries together"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        :param dict1: The first dictionary"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbUo%3D","line":291,"in_reply_to":"AAAAOn%2F%2FbW0%3D","updated":"2013-05-09 23:10:44.000000000","message":"Done","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b5dc54759fc50608204da790255b6b229ffd684f","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        :raises Exception: dict1, dict2 is not a dictionary"},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        if type(dict1) is not dict:"},{"line_number":304,"context_line":"            raise Exception(\"dict1 is not a dictionary\")"},{"line_number":305,"context_line":"        if type(dict2) is not dict:"},{"line_number":306,"context_line":"            raise Exception(\"dict2 is not a dictionary\")"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbYU%3D","line":304,"updated":"2013-05-09 22:38:51.000000000","message":"bare exception are no good in code, in tests I suppose it\u0027s fine, but you\u0027re not catching these as far as I can tell or did I just not look closely enough?","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"99eb2cfaecfef81fcb2a47bec55134ee5697a6e2","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        :raises Exception: dict1, dict2 is not a dictionary"},{"line_number":302,"context_line":"        \"\"\""},{"line_number":303,"context_line":"        if type(dict1) is not dict:"},{"line_number":304,"context_line":"            raise Exception(\"dict1 is not a dictionary\")"},{"line_number":305,"context_line":"        if type(dict2) is not dict:"},{"line_number":306,"context_line":"            raise Exception(\"dict2 is not a dictionary\")"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbUk%3D","line":304,"in_reply_to":"AAAAOn%2F%2FbYU%3D","updated":"2013-05-09 23:10:44.000000000","message":"I\u0027ll nuke this method.  It\u0027s not really needed but once.","commit_id":"ee04dc9234ce034f87d109e778a71317949344c3"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"755e0c5d6d6182a8914880493c835f00c4d8deec","unresolved":false,"context_lines":[{"line_number":279,"context_line":"    def getVLUNs(self):"},{"line_number":280,"context_line":"        return self.vluns"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def getVLUN(self, volumeName):"},{"line_number":283,"context_line":"        for vlun in self.vluns:"},{"line_number":284,"context_line":"            if vlun[\u0027volumeName\u0027] \u003d\u003d volumeName:"},{"line_number":285,"context_line":"                return vlun"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FbRs%3D","line":282,"updated":"2013-05-09 23:13:36.000000000","message":"cool,thanks for the explanation","commit_id":"9201848a14590d3b05e1298f6d2b1c50a7e7fcd7"}]}