)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"46c799be863f63ab88ae2c68b2c701471e3c8c69","unresolved":false,"context_lines":[{"line_number":13,"context_line":"before it has shown up in the OS. This has only been"},{"line_number":14,"context_line":"seen on FC hosts."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I27b02647ca22ca388d1cbc6f46d80d1b6d76bb54"},{"line_number":17,"context_line":"Closes-Bug: #1551023"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_ee1eefb9","line":16,"updated":"2016-03-02 21:46:12.000000000","message":"Please, add DocImpact flag","commit_id":"1d216869da0a14301a541222d97baf99145205d4"}],"cinder/tests/unit/test_xio.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"46c799be863f63ab88ae2c68b2c701471e3c8c69","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"DRIVER \u003d \"cinder.volume.drivers.xio.XIOISEDriver\""},{"line_number":732,"context_line":""},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"@mock.patch(DRIVER + \"._opener\", autospec\u003dTrue)"},{"line_number":735,"context_line":"class XIOISEDriverTestCase(object):"},{"line_number":736,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_aedd07e2","line":733,"updated":"2016-03-02 21:46:12.000000000","message":"We have to mock time.sleep now","commit_id":"1d216869da0a14301a541222d97baf99145205d4"}],"cinder/volume/drivers/xio.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04f7d86094988332c05a901a87fb7c35d4a9ceda","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.IntOpt(\u0027ise_completion_retries\u0027, default\u003d30,"},{"line_number":45,"context_line":"               help\u003d\u0027Number on retries to get completion status after \u0027"},{"line_number":46,"context_line":"               \u0027issuing a command to ISE.\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027ise_present_wait\u0027, default\u003d1,"},{"line_number":48,"context_line":"               help\u003d\u0027Seconds to wait to let device show up on host.\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a53999f4","line":47,"updated":"2016-03-09 12:53:38.000000000","message":"I think that Walter makes a valid point, but considering that no other configuration option is setting upper bound restrictions I don\u0027t think it\u0027s that important.\n\nAlthough it could be easily done here (even making sure it\u0027s a positive number):\n\n default\u003d1, max\u003d120, min\u003d0,","commit_id":"546d794a61bf249ca5a8787c5405ab3fe966ab52"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"39d4e9067612b2f3330097a3b428fe1a0eddfee0","unresolved":false,"context_lines":[{"line_number":1353,"context_line":"        data[\u0027volume_id\u0027] \u003d volume[\u0027id\u0027]"},{"line_number":1354,"context_line":""},{"line_number":1355,"context_line":"        # Wait a moment to allow device to show up on host"},{"line_number":1356,"context_line":"        time.sleep(self.configuration.ise_present_wait)"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"        return data"},{"line_number":1359,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_ccd22ed2","line":1356,"updated":"2016-03-08 23:58:50.000000000","message":"would it make sense to have some upper bounds tests on the value?","commit_id":"546d794a61bf249ca5a8787c5405ab3fe966ab52"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"79b5858028ff33139c58cba584d7bf758239c632","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Number on retries to get completion status after \u0027"},{"line_number":46,"context_line":"               \u0027issuing a command to ISE.\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027ise_present_wait\u0027, default\u003d1,"},{"line_number":48,"context_line":"               help\u003d\u0027Seconds to wait to let device show up on host.\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_0bf3b474","line":48,"updated":"2016-06-06 13:03:53.000000000","message":"Might be good to note the 10 second max in the help text to make it clear.","commit_id":"5d2dcabbac47dcad92faab3c9777ae5af8c2a2e8"}]}