)]}'
{"tools/lintstack.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"57f346cdf12a202281b8e30fd0597a700fecced7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    errors \u003d LintOutput.from_msg_to_dict(newmsg)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    print \"Unique errors reported by pylint: was %d, now %d.\" \\"},{"line_number":157,"context_line":"           % (len(known), len(errors))"},{"line_number":158,"context_line":"    passed \u003d True"},{"line_number":159,"context_line":"    for err_key, err_list in errors.items():"},{"line_number":160,"context_line":"        for err in err_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fav4%3D","line":157,"updated":"2013-05-10 06:14:41.000000000","message":"How about this?\n\nprint (\"Unique errors reported by pylint: was %d, now %d.\" %\n          (len(known), len(errors)))\n\nOr:\n\nprint \"Unique errors reported by pylint: was \", \n\nprint \"%d, now %d.\" % (len(known), len(errors))","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"121601f8946ff6eb9d0868a5dea8de1725424606","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    errors \u003d LintOutput.from_msg_to_dict(newmsg)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    print \"Unique errors reported by pylint: was %d, now %d.\" \\"},{"line_number":157,"context_line":"           % (len(known), len(errors))"},{"line_number":158,"context_line":"    passed \u003d True"},{"line_number":159,"context_line":"    for err_key, err_list in errors.items():"},{"line_number":160,"context_line":"        for err in err_list:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FalE%3D","line":157,"in_reply_to":"AAAAOn%2F%2Fav4%3D","updated":"2013-05-10 10:17:50.000000000","message":"Actually pep8 wants you to align with the quote, this works:\n@@ -154,7 +154,7 @@ def validate(newmsg\u003dNone):\n     errors \u003d LintOutput.from_msg_to_dict(newmsg)\n \n     print \"Unique errors reported by pylint: was %d, now %d.\" \\\n-           % (len(known), len(errors))\n+          % (len(known), len(errors))","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"57f346cdf12a202281b8e30fd0597a700fecced7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            print \"Consider regenerating the exception file if you will.\""},{"line_number":173,"context_line":"    else:"},{"line_number":174,"context_line":"        print (\"Please fix the errors above. If you believe they are false\""},{"line_number":175,"context_line":"              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")"},{"line_number":176,"context_line":"        sys.exit(1)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fav0%3D","line":175,"updated":"2013-05-10 06:14:41.000000000","message":"need a space before \\\"","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a2fe54e9e10826c32d50ef7c0a5e6e0b14873ec5","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            print \"Consider regenerating the exception file if you will.\""},{"line_number":173,"context_line":"    else:"},{"line_number":174,"context_line":"        print (\"Please fix the errors above. If you believe they are false\""},{"line_number":175,"context_line":"              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")"},{"line_number":176,"context_line":"        sys.exit(1)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FakI%3D","line":175,"in_reply_to":"AAAAOn%2F%2Fak4%3D","updated":"2013-05-10 10:34:26.000000000","message":"Some formatter messed with my last edit, try again:\n\n@@ -171,8 +171,8 @@ def validate(newmsg\u003dNone):\n                 print json.dumps(i)\n             print \"Consider regenerating the exception file if you will.\"\n     else:\n-        print (\"Please fix the errors above. If you believe they are false\"\n-              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")\n+        print (\"Please fix the errors above. If you believe they are false \"\n+               \"positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")\n         sys.exit(1)","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"121601f8946ff6eb9d0868a5dea8de1725424606","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            print \"Consider regenerating the exception file if you will.\""},{"line_number":173,"context_line":"    else:"},{"line_number":174,"context_line":"        print (\"Please fix the errors above. If you believe they are false\""},{"line_number":175,"context_line":"              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")"},{"line_number":176,"context_line":"        sys.exit(1)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fak4%3D","line":175,"in_reply_to":"AAAAOn%2F%2Fav0%3D","updated":"2013-05-10 10:17:50.000000000","message":"Here pep8 wants you to align the bracket, so this will work:\n\n@@ -172,7 +172,7 @@ def validate(newmsg\u003dNone):\n             print \"Consider regenerating the exception file if you will.\"\n     else:\n         print (\"Please fix the errors above. If you believe they are false\"\n-              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")\n+               \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")\n\nThough convention puts the space at the end of the truncated line rather than at the start of the continuation line. So:\n-        print (\"Please fix the errors above. If you believe they are false\"\n-              \" positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")\n+        print (\"Please fix the errors above. If you believe they are false \"\n+               \"positives, run \u0027tools/lintstack.py generate\u0027 to overwrite.\")","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"}],"tox.ini":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fdb3d1e41da843a6c5435f58e586a8f03e9635b0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"[testenv:pylint]"},{"line_number":40,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":41,"context_line":"deps \u003d -r{toxinidir}/tools/pip-requires"},{"line_number":42,"context_line":"       pylint\u003d\u003d0.26.0"},{"line_number":43,"context_line":"commands \u003d bash tools/lintstack.sh"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAOn%2F%2FbAs%3D","line":42,"updated":"2013-05-10 02:10:14.000000000","message":"I am not very familiar with pylint and tox.  So this is dumb question: there\u0027s one dependency of pylint\u003d\u003d0.25.2 in tools/test-requires.  Does it have anything to do with you want put into tox.ini here?","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"62ae8af5491a0414acb79ea1ba24767ce84bc356","unresolved":false,"context_lines":[{"line_number":39,"context_line":"[testenv:pylint]"},{"line_number":40,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":41,"context_line":"deps \u003d -r{toxinidir}/tools/pip-requires"},{"line_number":42,"context_line":"       pylint\u003d\u003d0.26.0"},{"line_number":43,"context_line":"commands \u003d bash tools/lintstack.sh"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAOn%2F%2Fa%2FU%3D","line":42,"in_reply_to":"AAAAOn%2F%2FbAs%3D","updated":"2013-05-10 02:22:58.000000000","message":"not a dump question. :) To run pylint efficiently, we only dependencies in pip-requires, and pylint. We don\u0027t need to install everything in test-requires.\n\nI also think that pylint\u003d\u003d0.25.2 is no longer needed for test-requires. I guess that belongs to a separate commit. Thanks.","commit_id":"671747d1f59f55f8f3d4f526d4d617c6e1c68a29"}]}